Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 6081,
    "url": "http://patches.dpdk.org/api/patches/6081/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1436118000-132275-2-git-send-email-maryam.tahhan@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1436118000-132275-2-git-send-email-maryam.tahhan@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1436118000-132275-2-git-send-email-maryam.tahhan@intel.com",
    "date": "2015-07-05T17:39:53",
    "name": "[dpdk-dev,v4,1/8] ixgbe: move stats register reads to a new function",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "64b5a08401392a4abceb91e116c8f28fe013706e",
    "submitter": {
        "id": 259,
        "url": "http://patches.dpdk.org/api/people/259/?format=api",
        "name": "Tahhan, Maryam",
        "email": "maryam.tahhan@intel.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1436118000-132275-2-git-send-email-maryam.tahhan@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/6081/comments/",
    "check": "pending",
    "checks": "http://patches.dpdk.org/api/patches/6081/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 20B07C390;\n\tSun,  5 Jul 2015 19:40:09 +0200 (CEST)",
            "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 28A72C380\n\tfor <dev@dpdk.org>; Sun,  5 Jul 2015 19:40:06 +0200 (CEST)",
            "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga102.jf.intel.com with ESMTP; 05 Jul 2015 10:40:06 -0700",
            "from sie-lab-212-170.ir.intel.com (HELO\n\tsilpixa00378251.ir.intel.com) ([10.237.212.170])\n\tby orsmga002.jf.intel.com with ESMTP; 05 Jul 2015 10:40:05 -0700"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.15,410,1432623600\"; d=\"scan'208\";a=\"758772992\"",
        "From": "Maryam Tahhan <maryam.tahhan@intel.com>",
        "To": "dev@dpdk.org",
        "Date": "Sun,  5 Jul 2015 18:39:53 +0100",
        "Message-Id": "<1436118000-132275-2-git-send-email-maryam.tahhan@intel.com>",
        "X-Mailer": "git-send-email 1.9.3",
        "In-Reply-To": "<1436118000-132275-1-git-send-email-maryam.tahhan@intel.com>",
        "References": "<1436118000-132275-1-git-send-email-maryam.tahhan@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v4 1/8] ixgbe: move stats register reads to a new\n\tfunction",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Move stats register reads to ixgbe_read_stats_registers() as it will be\nused by the functions to retrieve stats and extended stats.\n\nSigned-off-by: Maryam Tahhan <maryam.tahhan@intel.com>\n---\n drivers/net/ixgbe/ixgbe_ethdev.c | 64 +++++++++++++++++++++++++++-------------\n 1 file changed, 44 insertions(+), 20 deletions(-)",
    "diff": "diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex f18550c..927021f 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -1761,24 +1761,16 @@ ixgbe_dev_close(struct rte_eth_dev *dev)\n \tixgbe_set_rar(hw, 0, hw->mac.addr, 0, IXGBE_RAH_AV);\n }\n \n-/*\n- * This function is based on ixgbe_update_stats_counters() in base/ixgbe.c\n- */\n static void\n-ixgbe_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)\n+ixgbe_read_stats_registers(struct ixgbe_hw *hw, struct ixgbe_hw_stats\n+\t\t\t\t\t\t   *hw_stats, uint64_t *total_missed_rx,\n+\t\t\t\t\t\t   uint64_t *total_qbrc, uint64_t *total_qprc,\n+\t\t\t\t\t\t   uint64_t *rxnfgpc, uint64_t *txdgpc,\n+\t\t\t\t\t\t   uint64_t *total_qprdc)\n {\n-\tstruct ixgbe_hw *hw =\n-\t\t\tIXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n-\tstruct ixgbe_hw_stats *hw_stats =\n-\t\t\tIXGBE_DEV_PRIVATE_TO_STATS(dev->data->dev_private);\n \tuint32_t bprc, lxon, lxoff, total;\n-\tuint64_t total_missed_rx, total_qbrc, total_qprc;\n \tunsigned i;\n \n-\ttotal_missed_rx = 0;\n-\ttotal_qbrc = 0;\n-\ttotal_qprc = 0;\n-\n \thw_stats->crcerrs += IXGBE_READ_REG(hw, IXGBE_CRCERRS);\n \thw_stats->illerrc += IXGBE_READ_REG(hw, IXGBE_ILLERRC);\n \thw_stats->errbc += IXGBE_READ_REG(hw, IXGBE_ERRBC);\n@@ -1790,7 +1782,7 @@ ixgbe_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)\n \t\t/* global total per queue */\n \t\thw_stats->mpc[i] += mp;\n \t\t/* Running comprehensive total for stats display */\n-\t\ttotal_missed_rx += hw_stats->mpc[i];\n+\t\t*total_missed_rx += hw_stats->mpc[i];\n \t\tif (hw->mac.type == ixgbe_mac_82598EB)\n \t\t\thw_stats->rnbc[i] +=\n \t\t\t    IXGBE_READ_REG(hw, IXGBE_RNBC(i));\n@@ -1814,10 +1806,11 @@ ixgbe_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)\n \t\thw_stats->qbtc[i] += IXGBE_READ_REG(hw, IXGBE_QBTC_L(i));\n \t\thw_stats->qbtc[i] +=\n \t\t    ((uint64_t)IXGBE_READ_REG(hw, IXGBE_QBTC_H(i)) << 32);\n-\t\thw_stats->qprdc[i] += IXGBE_READ_REG(hw, IXGBE_QPRDC(i));\n+\t\t*total_qprdc += hw_stats->qprdc[i] +=\n+\t\t\t\tIXGBE_READ_REG(hw, IXGBE_QPRDC(i));\n \n-\t\ttotal_qprc += hw_stats->qprc[i];\n-\t\ttotal_qbrc += hw_stats->qbrc[i];\n+\t\t*total_qprc += hw_stats->qprc[i];\n+\t\t*total_qbrc += hw_stats->qbrc[i];\n \t}\n \thw_stats->mlfc += IXGBE_READ_REG(hw, IXGBE_MLFC);\n \thw_stats->mrfc += IXGBE_READ_REG(hw, IXGBE_MRFC);\n@@ -1825,6 +1818,8 @@ ixgbe_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)\n \n \t/* Note that gprc counts missed packets */\n \thw_stats->gprc += IXGBE_READ_REG(hw, IXGBE_GPRC);\n+\t*rxnfgpc += IXGBE_READ_REG(hw, IXGBE_RXNFGPC);\n+\t*txdgpc += IXGBE_READ_REG(hw, IXGBE_TXDGPC);\n \n \tif (hw->mac.type != ixgbe_mac_82598EB) {\n \t\thw_stats->gorc += IXGBE_READ_REG(hw, IXGBE_GORCL);\n@@ -1902,6 +1897,35 @@ ixgbe_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)\n \t\thw_stats->fcoedwtc += IXGBE_READ_REG(hw, IXGBE_FCOEDWTC);\n \t}\n \n+\t/* Flow Director Stats registers */\n+\thw_stats->fdirmatch += IXGBE_READ_REG(hw, IXGBE_FDIRMATCH);\n+\thw_stats->fdirmiss += IXGBE_READ_REG(hw, IXGBE_FDIRMISS);\n+}\n+\n+/*\n+ * This function is based on ixgbe_update_stats_counters() in ixgbe/ixgbe.c\n+ */\n+static void\n+ixgbe_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)\n+{\n+\tstruct ixgbe_hw *hw =\n+\t\t\tIXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n+\tstruct ixgbe_hw_stats *hw_stats =\n+\t\t\tIXGBE_DEV_PRIVATE_TO_STATS(dev->data->dev_private);\n+\tuint64_t total_missed_rx, total_qbrc, total_qprc, total_qprdc;\n+\tuint64_t rxnfgpc, txdgpc;\n+\tunsigned i;\n+\n+\ttotal_missed_rx = 0;\n+\ttotal_qbrc = 0;\n+\ttotal_qprc = 0;\n+\ttotal_qprdc = 0;\n+\trxnfgpc = 0;\n+\ttxdgpc = 0;\n+\n+\tixgbe_read_stats_registers(hw, hw_stats, &total_missed_rx, &total_qbrc,\n+\t\t\t&total_qprc, &rxnfgpc, &txdgpc, &total_qprdc);\n+\n \tif (stats == NULL)\n \t\treturn;\n \n@@ -1930,7 +1954,9 @@ ixgbe_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)\n \t                  hw_stats->illerrc + hw_stats->errbc;\n \n \t/* Tx Errors */\n-\tstats->oerrors  = 0;\n+\t/*txdgpc: packets that are DMA'ed*/\n+\t/*gptc: packets that are sent*/\n+\tstats->oerrors  = txdgpc - hw_stats->gptc;\n \n \t/* XON/XOFF pause frames */\n \tstats->tx_pause_xon  = hw_stats->lxontxc;\n@@ -1939,8 +1965,6 @@ ixgbe_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)\n \tstats->rx_pause_xoff = hw_stats->lxoffrxc;\n \n \t/* Flow Director Stats registers */\n-\thw_stats->fdirmatch += IXGBE_READ_REG(hw, IXGBE_FDIRMATCH);\n-\thw_stats->fdirmiss += IXGBE_READ_REG(hw, IXGBE_FDIRMISS);\n \tstats->fdirmatch = hw_stats->fdirmatch;\n \tstats->fdirmiss = hw_stats->fdirmiss;\n }\n",
    "prefixes": [
        "dpdk-dev",
        "v4",
        "1/8"
    ]
}