Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 60665,
    "url": "http://patches.dpdk.org/api/patches/60665/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191008015018.17086-10-qi.z.zhang@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20191008015018.17086-10-qi.z.zhang@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20191008015018.17086-10-qi.z.zhang@intel.com",
    "date": "2019-10-08T01:50:15",
    "name": "[v3,09/12] net/ice/base: fix flow raw field vector extraction",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "74671150a75cfd2382a9d4b390dba992d332c020",
    "submitter": {
        "id": 504,
        "url": "http://patches.dpdk.org/api/people/504/?format=api",
        "name": "Qi Zhang",
        "email": "qi.z.zhang@intel.com"
    },
    "delegate": {
        "id": 31221,
        "url": "http://patches.dpdk.org/api/users/31221/?format=api",
        "username": "yexl",
        "first_name": "xiaolong",
        "last_name": "ye",
        "email": "xiaolong.ye@intel.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191008015018.17086-10-qi.z.zhang@intel.com/mbox/",
    "series": [
        {
            "id": 6732,
            "url": "http://patches.dpdk.org/api/series/6732/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6732",
            "date": "2019-10-08T01:50:06",
            "name": "net/ice: base code update",
            "version": 3,
            "mbox": "http://patches.dpdk.org/series/6732/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/60665/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/60665/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6310E1C0CB;\n\tTue,  8 Oct 2019 03:47:47 +0200 (CEST)",
            "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n\tby dpdk.org (Postfix) with ESMTP id C1F721C038\n\tfor <dev@dpdk.org>; Tue,  8 Oct 2019 03:47:41 +0200 (CEST)",
            "from orsmga006.jf.intel.com ([10.7.209.51])\n\tby fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t07 Oct 2019 18:47:41 -0700",
            "from dpdk51.sh.intel.com ([10.67.110.245])\n\tby orsmga006.jf.intel.com with ESMTP; 07 Oct 2019 18:47:39 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.67,269,1566889200\"; d=\"scan'208\";a=\"197556249\"",
        "From": "Qi Zhang <qi.z.zhang@intel.com>",
        "To": "wenzhuo.lu@intel.com,\n\tqiming.yang@intel.com",
        "Cc": "dev@dpdk.org, xiaolong.ye@intel.com, Qi Zhang <qi.z.zhang@intel.com>,\n\tDan Nowlin <dan.nowlin@intel.com>,\n\tPaul M Stillwell Jr <paul.m.stillwell.jr@intel.com>",
        "Date": "Tue,  8 Oct 2019 09:50:15 +0800",
        "Message-Id": "<20191008015018.17086-10-qi.z.zhang@intel.com>",
        "X-Mailer": "git-send-email 2.13.6",
        "In-Reply-To": "<20191008015018.17086-1-qi.z.zhang@intel.com>",
        "References": "<20190902035551.16852-1-qi.z.zhang@intel.com>\n\t<20191008015018.17086-1-qi.z.zhang@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v3 09/12] net/ice/base: fix flow raw field vector\n\textraction",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Correct the ordering of raw field extraction in the field vector\nby taking into account the ordering setting for requesting block.\n\nFixes: aa1cd410fa64 (\"net/ice/base: add flow module\")\n\nSigned-off-by: Dan Nowlin <dan.nowlin@intel.com>\nSigned-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n drivers/net/ice/base/ice_flow.c | 15 +++++++++++++--\n 1 file changed, 13 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/drivers/net/ice/base/ice_flow.c b/drivers/net/ice/base/ice_flow.c\nindex 370ad9ba3..38c7c42f7 100644\n--- a/drivers/net/ice/base/ice_flow.c\n+++ b/drivers/net/ice/base/ice_flow.c\n@@ -806,6 +806,7 @@ static enum ice_status\n ice_flow_xtract_raws(struct ice_hw *hw, struct ice_flow_prof_params *params,\n \t\t     u8 seg)\n {\n+\tu16 fv_words;\n \tu16 hdrs_sz;\n \tu8 i;\n \n@@ -821,6 +822,8 @@ ice_flow_xtract_raws(struct ice_hw *hw, struct ice_flow_prof_params *params,\n \tif (!hdrs_sz)\n \t\treturn ICE_ERR_PARAM;\n \n+\tfv_words = hw->blk[params->blk].es.fvw;\n+\n \tfor (i = 0; i < params->prof->segs[seg].raws_cnt; i++) {\n \t\tstruct ice_flow_seg_fld_raw *raw;\n \t\tu16 off, cnt, j;\n@@ -853,6 +856,8 @@ ice_flow_xtract_raws(struct ice_hw *hw, struct ice_flow_prof_params *params,\n \t\t\t\t\t   BITS_PER_BYTE));\n \t\toff = raw->info.xtrct.off;\n \t\tfor (j = 0; j < cnt; j++) {\n+\t\t\tu16 idx;\n+\n \t\t\t/* Make sure the number of extraction sequence required\n \t\t\t * does not exceed the block's capability\n \t\t\t */\n@@ -860,8 +865,14 @@ ice_flow_xtract_raws(struct ice_hw *hw, struct ice_flow_prof_params *params,\n \t\t\t    params->es_cnt >= ICE_MAX_FV_WORDS)\n \t\t\t\treturn ICE_ERR_MAX_LIMIT;\n \n-\t\t\tparams->es[params->es_cnt].prot_id = ICE_PROT_PAY;\n-\t\t\tparams->es[params->es_cnt].off = off;\n+\t\t\t/* some blocks require a reversed field vector layout */\n+\t\t\tif (hw->blk[params->blk].es.reverse)\n+\t\t\t\tidx = fv_words - params->es_cnt - 1;\n+\t\t\telse\n+\t\t\t\tidx = params->es_cnt;\n+\n+\t\t\tparams->es[idx].prot_id = ICE_PROT_PAY;\n+\t\t\tparams->es[idx].off = off;\n \t\t\tparams->es_cnt++;\n \t\t\toff += ICE_FLOW_FV_EXTRACT_SZ;\n \t\t}\n",
    "prefixes": [
        "v3",
        "09/12"
    ]
}