Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 60627,
    "url": "http://patches.dpdk.org/api/patches/60627/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191007154343.8556-4-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20191007154343.8556-4-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20191007154343.8556-4-stephen@networkplumber.org",
    "date": "2019-10-07T15:43:41",
    "name": "[v5,3/5] mbuf: deinline rte_pktmbuf_clone",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "d8ce50019ace1d217fcaff5613d22b351de1870d",
    "submitter": {
        "id": 27,
        "url": "http://patches.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191007154343.8556-4-stephen@networkplumber.org/mbox/",
    "series": [
        {
            "id": 6725,
            "url": "http://patches.dpdk.org/api/series/6725/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6725",
            "date": "2019-10-07T15:43:38",
            "name": "mbuf copy/cloning enhancements",
            "version": 5,
            "mbox": "http://patches.dpdk.org/series/6725/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/60627/comments/",
    "check": "warning",
    "checks": "http://patches.dpdk.org/api/patches/60627/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5309F1C29D;\n\tMon,  7 Oct 2019 17:44:01 +0200 (CEST)",
            "from mail-pg1-f193.google.com (mail-pg1-f193.google.com\n\t[209.85.215.193]) by dpdk.org (Postfix) with ESMTP id EFB381C1C6\n\tfor <dev@dpdk.org>; Mon,  7 Oct 2019 17:43:55 +0200 (CEST)",
            "by mail-pg1-f193.google.com with SMTP id e1so8450980pgj.6\n\tfor <dev@dpdk.org>; Mon, 07 Oct 2019 08:43:55 -0700 (PDT)",
            "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tk5sm20779345pfp.109.2019.10.07.08.43.53\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 07 Oct 2019 08:43:53 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=zxcyCp/RJwDdLRu+ORBLRDdv/Ir5nLTZyoyCxr19E5Q=;\n\tb=UW2Q8BMSu302YJMIJqQw/LN+tjqUhFqQCW9wYr2K/ZlujztUktMFseegtv8n9Wp8iq\n\tSfpW1QJSRIEtn0YhAkVMzLBbFlpCTS6CQK03QywmyiqmEIkWCkuZmHDp4yjgtEr/Rub+\n\tLnCGfeoBTSP+Am1KfvU+7E9OLZ/uZXCd/y0kx+ltTr4tjlbXCcn8AUIVCGyfUDTgLxpq\n\tCCKmh1U2LsmlwNv2FiRPKFbNw/Sr3TDkb6tp1dfCPRxwW3b0wUw+FmNFuMTF+uDItSOR\n\tN65mMdoO+DpOIDNysWu3l9gJwqZEfDHDmkxcSZ9YcpnbM9gTYd5TI5kEiotBS5Y2Rx1Z\n\tMi/g==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=zxcyCp/RJwDdLRu+ORBLRDdv/Ir5nLTZyoyCxr19E5Q=;\n\tb=aW47qldgoAsEjF5RQDTaTBt/D973VBD3DzsgbfJUdl2DYEz2m9hWTrpvQWQtUo1KHQ\n\tzmKv3A9CUpwLhHV9DOOjdctisNpfvCRbhwjdMKcJVJDS1rMJTJMsPan1QBfLmwigEpau\n\t5aahpRBZFkTs4zj3PANASxsQDxeSKYr5Nrk8YQMkQbZyN0o8+7aSL7X62hhnGL9i0Wcs\n\tfp+6C2oXntDLo1xIFb3Pzo7HpxOk6IpIS4dZYCvBCkET34djX/l2Vl/wtQDgr7GoiJQZ\n\tKFbJollFMmMCw+fc20Lib1a8Wn0tGg6g7OzrZAsxoGXKdO3dUNHYy80nYT/D9Auhw7U6\n\tjfZA==",
        "X-Gm-Message-State": "APjAAAWXV3UdYAjnnbr/2DJ0f9ZHgrBPmwUcaTsPg/CauZFT+7o9teAd\n\tfIwbIBYrCzAyclRtsUorPyuJTGt/nGYcWQ==",
        "X-Google-Smtp-Source": "APXvYqw8qx4zQ6E8dUT5ZLNWlxIuQkVDnTYnblbCNBrsjFBjfX/57FwWPbWTvd/sx0vNam+mg3Ibeg==",
        "X-Received": "by 2002:a63:fc60:: with SMTP id\n\tr32mr17205297pgk.160.1570463034747; \n\tMon, 07 Oct 2019 08:43:54 -0700 (PDT)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "dev@dpdk.org",
        "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n\tAndrew Rybchenko <arybchenko@solarflare.com>",
        "Date": "Mon,  7 Oct 2019 08:43:41 -0700",
        "Message-Id": "<20191007154343.8556-4-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.20.1",
        "In-Reply-To": "<20191007154343.8556-1-stephen@networkplumber.org>",
        "References": "<20190928003758.18489-1-stephen@networkplumber.org>\n\t<20191007154343.8556-1-stephen@networkplumber.org>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH v5 3/5] mbuf: deinline rte_pktmbuf_clone",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Cloning mbufs requires allocations and iteration\nand therefore should not be an inline.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nAcked-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n lib/librte_mbuf/rte_mbuf.c           | 39 ++++++++++++++++++++++++++++\n lib/librte_mbuf/rte_mbuf.h           | 38 ++-------------------------\n lib/librte_mbuf/rte_mbuf_version.map |  1 +\n 3 files changed, 42 insertions(+), 36 deletions(-)",
    "diff": "diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c\nindex e2c661c97522..9a1a1b5f9468 100644\n--- a/lib/librte_mbuf/rte_mbuf.c\n+++ b/lib/librte_mbuf/rte_mbuf.c\n@@ -245,6 +245,45 @@ int rte_mbuf_check(const struct rte_mbuf *m, int is_header,\n \treturn 0;\n }\n \n+/* Creates a shallow copy of mbuf */\n+struct rte_mbuf *\n+rte_pktmbuf_clone(struct rte_mbuf *md, struct rte_mempool *mp)\n+{\n+\tstruct rte_mbuf *mc, *mi, **prev;\n+\tuint32_t pktlen;\n+\tuint16_t nseg;\n+\n+\tmc = rte_pktmbuf_alloc(mp);\n+\tif (unlikely(mc == NULL))\n+\t\treturn NULL;\n+\n+\tmi = mc;\n+\tprev = &mi->next;\n+\tpktlen = md->pkt_len;\n+\tnseg = 0;\n+\n+\tdo {\n+\t\tnseg++;\n+\t\trte_pktmbuf_attach(mi, md);\n+\t\t*prev = mi;\n+\t\tprev = &mi->next;\n+\t} while ((md = md->next) != NULL &&\n+\t    (mi = rte_pktmbuf_alloc(mp)) != NULL);\n+\n+\t*prev = NULL;\n+\tmc->nb_segs = nseg;\n+\tmc->pkt_len = pktlen;\n+\n+\t/* Allocation of new indirect segment failed */\n+\tif (unlikely(mi == NULL)) {\n+\t\trte_pktmbuf_free(mc);\n+\t\treturn NULL;\n+\t}\n+\n+\t__rte_mbuf_sanity_check(mc, 1);\n+\treturn mc;\n+}\n+\n /* convert multi-segment mbuf to single mbuf */\n int\n __rte_pktmbuf_linearize(struct rte_mbuf *mbuf)\ndiff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h\nindex bffda1c81fbd..6133f12172ae 100644\n--- a/lib/librte_mbuf/rte_mbuf.h\n+++ b/lib/librte_mbuf/rte_mbuf.h\n@@ -1924,42 +1924,8 @@ static inline void rte_pktmbuf_free(struct rte_mbuf *m)\n  *   - The pointer to the new \"clone\" mbuf on success.\n  *   - NULL if allocation fails.\n  */\n-static inline struct rte_mbuf *rte_pktmbuf_clone(struct rte_mbuf *md,\n-\t\tstruct rte_mempool *mp)\n-{\n-\tstruct rte_mbuf *mc, *mi, **prev;\n-\tuint32_t pktlen;\n-\tuint16_t nseg;\n-\n-\tif (unlikely ((mc = rte_pktmbuf_alloc(mp)) == NULL))\n-\t\treturn NULL;\n-\n-\tmi = mc;\n-\tprev = &mi->next;\n-\tpktlen = md->pkt_len;\n-\tnseg = 0;\n-\n-\tdo {\n-\t\tnseg++;\n-\t\trte_pktmbuf_attach(mi, md);\n-\t\t*prev = mi;\n-\t\tprev = &mi->next;\n-\t} while ((md = md->next) != NULL &&\n-\t    (mi = rte_pktmbuf_alloc(mp)) != NULL);\n-\n-\t*prev = NULL;\n-\tmc->nb_segs = nseg;\n-\tmc->pkt_len = pktlen;\n-\n-\t/* Allocation of new indirect segment failed */\n-\tif (unlikely (mi == NULL)) {\n-\t\trte_pktmbuf_free(mc);\n-\t\treturn NULL;\n-\t}\n-\n-\t__rte_mbuf_sanity_check(mc, 1);\n-\treturn mc;\n-}\n+struct rte_mbuf *\n+rte_pktmbuf_clone(struct rte_mbuf *md, struct rte_mempool *mp);\n \n /**\n  * Adds given value to the refcnt of all packet mbuf segments.\ndiff --git a/lib/librte_mbuf/rte_mbuf_version.map b/lib/librte_mbuf/rte_mbuf_version.map\nindex 4d0bc9772769..ff5c18a5559b 100644\n--- a/lib/librte_mbuf/rte_mbuf_version.map\n+++ b/lib/librte_mbuf/rte_mbuf_version.map\n@@ -50,6 +50,7 @@ DPDK_19.11 {\n \tglobal:\n \n \t__rte_pktmbuf_linearize;\n+\trte_pktmbuf_clone;\n } DPDK_18.08;\n \n EXPERIMENTAL {\n",
    "prefixes": [
        "v5",
        "3/5"
    ]
}