Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/60578/?format=api
{ "id": 60578, "url": "http://patches.dpdk.org/api/patches/60578/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191006031408.8633-13-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191006031408.8633-13-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191006031408.8633-13-qi.z.zhang@intel.com", "date": "2019-10-06T03:14:08", "name": "[v2,12/12] net/base/ice: improve misc code style", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "919dcac2c26a9c7cd211685471844f9a763445f2", "submitter": { "id": 504, "url": "http://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": { "id": 31221, "url": "http://patches.dpdk.org/api/users/31221/?format=api", "username": "yexl", "first_name": "xiaolong", "last_name": "ye", "email": "xiaolong.ye@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191006031408.8633-13-qi.z.zhang@intel.com/mbox/", "series": [ { "id": 6704, "url": "http://patches.dpdk.org/api/series/6704/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6704", "date": "2019-10-06T03:13:56", "name": "[v2,01/12] net/ice/base: fix for adding PPPoE switch rule", "version": 2, "mbox": "http://patches.dpdk.org/series/6704/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/60578/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/60578/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0F9EB1D40D;\n\tSun, 6 Oct 2019 05:11:44 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 057D11D17F\n\tfor <dev@dpdk.org>; Sun, 6 Oct 2019 05:11:37 +0200 (CEST)", "from orsmga007.jf.intel.com ([10.7.209.58])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t05 Oct 2019 20:11:37 -0700", "from dpdk51.sh.intel.com ([10.67.110.245])\n\tby orsmga007.jf.intel.com with ESMTP; 05 Oct 2019 20:11:35 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.67,261,1566889200\"; d=\"scan'208\";a=\"183095265\"", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "wenzhuo.lu@intel.com,\n\tqiming.yang@intel.com", "Cc": "dev@dpdk.org, xiaolong.ye@intel.com, Qi Zhang <qi.z.zhang@intel.com>,\n\tTony Nguyen <anthony.l.nguyen@intel.com>,\n\tPaul M Stillwell Jr <paul.m.stillwell.jr@intel.com>", "Date": "Sun, 6 Oct 2019 11:14:08 +0800", "Message-Id": "<20191006031408.8633-13-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.13.6", "In-Reply-To": "<20191006031408.8633-1-qi.z.zhang@intel.com>", "References": "<20190902035551.16852-1-qi.z.zhang@intel.com>\n\t<20191006031408.8633-1-qi.z.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 12/12] net/base/ice: improve misc code style", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Combine a couple of function definitions that can fit on one line.\nRCT a variable declaration.\n\nSigned-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>\nSigned-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n drivers/net/ice/base/ice_flex_pipe.c | 6 ++----\n drivers/net/ice/base/ice_flex_pipe.h | 3 +--\n drivers/net/ice/base/ice_nvm.c | 2 +-\n 3 files changed, 4 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/ice/base/ice_flex_pipe.c b/drivers/net/ice/base/ice_flex_pipe.c\nindex c2af1dfe8..dd098f529 100644\n--- a/drivers/net/ice/base/ice_flex_pipe.c\n+++ b/drivers/net/ice/base/ice_flex_pipe.c\n@@ -2131,8 +2131,7 @@ ice_ptg_find_ptype(struct ice_hw *hw, enum ice_block blk, u16 ptype, u8 *ptg)\n * This function allocates a given packet type group ID specified by the ptg\n * parameter.\n */\n-static\n-void ice_ptg_alloc_val(struct ice_hw *hw, enum ice_block blk, u8 ptg)\n+static void ice_ptg_alloc_val(struct ice_hw *hw, enum ice_block blk, u8 ptg)\n {\n \thw->blk[blk].xlt1.ptg_tbl[ptg].in_use = true;\n }\n@@ -3286,8 +3285,7 @@ static const u32 ice_blk_sids[ICE_BLK_COUNT][ICE_SID_OFF_COUNT] = {\n * @hw: pointer to the hardware structure\n * @blk: the HW block to initialize\n */\n-static\n-void ice_init_sw_xlt1_db(struct ice_hw *hw, enum ice_block blk)\n+static void ice_init_sw_xlt1_db(struct ice_hw *hw, enum ice_block blk)\n {\n \tu16 pt;\n \ndiff --git a/drivers/net/ice/base/ice_flex_pipe.h b/drivers/net/ice/base/ice_flex_pipe.h\nindex b24a09b4d..ee606af15 100644\n--- a/drivers/net/ice/base/ice_flex_pipe.h\n+++ b/drivers/net/ice/base/ice_flex_pipe.h\n@@ -65,8 +65,7 @@ enum ice_status\n ice_add_prof_id_flow(struct ice_hw *hw, enum ice_block blk, u16 vsi, u64 hdl);\n enum ice_status\n ice_rem_prof_id_flow(struct ice_hw *hw, enum ice_block blk, u16 vsi, u64 hdl);\n-enum ice_status\n-ice_init_pkg(struct ice_hw *hw, u8 *buff, u32 len);\n+enum ice_status ice_init_pkg(struct ice_hw *hw, u8 *buff, u32 len);\n enum ice_status\n ice_copy_and_init_pkg(struct ice_hw *hw, const u8 *buf, u32 len);\n enum ice_status ice_init_hw_tbls(struct ice_hw *hw);\ndiff --git a/drivers/net/ice/base/ice_nvm.c b/drivers/net/ice/base/ice_nvm.c\nindex e00942528..1dbfc2dcc 100644\n--- a/drivers/net/ice/base/ice_nvm.c\n+++ b/drivers/net/ice/base/ice_nvm.c\n@@ -260,8 +260,8 @@ enum ice_status ice_read_sr_word(struct ice_hw *hw, u16 offset, u16 *data)\n */\n enum ice_status ice_init_nvm(struct ice_hw *hw)\n {\n-\tstruct ice_nvm_info *nvm = &hw->nvm;\n \tu16 oem_hi, oem_lo, boot_cfg_tlv, boot_cfg_tlv_len;\n+\tstruct ice_nvm_info *nvm = &hw->nvm;\n \tu16 eetrack_lo, eetrack_hi;\n \tenum ice_status status;\n \tu32 fla, gens_stat;\n", "prefixes": [ "v2", "12/12" ] }