Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/60571/?format=api
http://patches.dpdk.org/api/patches/60571/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191006031408.8633-7-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191006031408.8633-7-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191006031408.8633-7-qi.z.zhang@intel.com", "date": "2019-10-06T03:14:02", "name": "[v2,06/12] net/ice/base: remove dead error condition", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7843c035e601d9c7b940c70f0f334b4192b49a57", "submitter": { "id": 504, "url": "http://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": { "id": 31221, "url": "http://patches.dpdk.org/api/users/31221/?format=api", "username": "yexl", "first_name": "xiaolong", "last_name": "ye", "email": "xiaolong.ye@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191006031408.8633-7-qi.z.zhang@intel.com/mbox/", "series": [ { "id": 6704, "url": "http://patches.dpdk.org/api/series/6704/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6704", "date": "2019-10-06T03:13:56", "name": "[v2,01/12] net/ice/base: fix for adding PPPoE switch rule", "version": 2, "mbox": "http://patches.dpdk.org/series/6704/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/60571/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/60571/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id BDA561D16A;\n\tSun, 6 Oct 2019 05:11:31 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id D501B1D147\n\tfor <dev@dpdk.org>; Sun, 6 Oct 2019 05:11:26 +0200 (CEST)", "from orsmga007.jf.intel.com ([10.7.209.58])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t05 Oct 2019 20:11:26 -0700", "from dpdk51.sh.intel.com ([10.67.110.245])\n\tby orsmga007.jf.intel.com with ESMTP; 05 Oct 2019 20:11:24 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.67,261,1566889200\"; d=\"scan'208\";a=\"183095230\"", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "wenzhuo.lu@intel.com,\n\tqiming.yang@intel.com", "Cc": "dev@dpdk.org, xiaolong.ye@intel.com, Qi Zhang <qi.z.zhang@intel.com>,\n\tJeb Cramer <jeb.j.cramer@intel.com>,\n\tPaul M Stillwell Jr <paul.m.stillwell.jr@intel.com>", "Date": "Sun, 6 Oct 2019 11:14:02 +0800", "Message-Id": "<20191006031408.8633-7-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.13.6", "In-Reply-To": "<20191006031408.8633-1-qi.z.zhang@intel.com>", "References": "<20190902035551.16852-1-qi.z.zhang@intel.com>\n\t<20191006031408.8633-1-qi.z.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 06/12] net/ice/base: remove dead error\n\tcondition", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The pointer cmd is set to an address of a structure, which can never be\nNULL. Remove the check-for-NULL lines since it's dead code anyway.\n\nSigned-off-by: Jeb Cramer <jeb.j.cramer@intel.com>\nSigned-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\nAcked-by: Qiming Yang <qiming.yang@intel.com>\n---\n drivers/net/ice/base/ice_common.c | 3 ---\n 1 file changed, 3 deletions(-)", "diff": "diff --git a/drivers/net/ice/base/ice_common.c b/drivers/net/ice/base/ice_common.c\nindex 48ba160f7..4ba3ab202 100644\n--- a/drivers/net/ice/base/ice_common.c\n+++ b/drivers/net/ice/base/ice_common.c\n@@ -176,9 +176,6 @@ ice_aq_get_link_topo_handle(struct ice_port_info *pi, u8 node_type,\n \n \tcmd = &desc.params.get_link_topo;\n \n-\tif (!cmd)\n-\t\treturn ICE_ERR_PARAM;\n-\n \tice_fill_dflt_direct_cmd_desc(&desc, ice_aqc_opc_get_link_topo);\n \n \tcmd->addr.node_type_ctx = (ICE_AQC_LINK_TOPO_NODE_CTX_PORT <<\n", "prefixes": [ "v2", "06/12" ] }{ "id": 60571, "url": "