Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/60498/?format=api
{ "id": 60498, "url": "http://patches.dpdk.org/api/patches/60498/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191003224419.23968-1-dharmik.thakkar@arm.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191003224419.23968-1-dharmik.thakkar@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191003224419.23968-1-dharmik.thakkar@arm.com", "date": "2019-10-03T22:44:19", "name": "net/ixgbe: avoid multpile definitions of 'bool'", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4084753d57a494c1861eb8b2706ba7a81d15c14e", "submitter": { "id": 1108, "url": "http://patches.dpdk.org/api/people/1108/?format=api", "name": "Dharmik Thakkar", "email": "dharmik.thakkar@arm.com" }, "delegate": { "id": 31221, "url": "http://patches.dpdk.org/api/users/31221/?format=api", "username": "yexl", "first_name": "xiaolong", "last_name": "ye", "email": "xiaolong.ye@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191003224419.23968-1-dharmik.thakkar@arm.com/mbox/", "series": [ { "id": 6684, "url": "http://patches.dpdk.org/api/series/6684/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6684", "date": "2019-10-03T22:44:19", "name": "net/ixgbe: avoid multpile definitions of 'bool'", "version": 1, "mbox": "http://patches.dpdk.org/series/6684/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/60498/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/60498/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 14A851C191;\n\tFri, 4 Oct 2019 00:44:50 +0200 (CEST)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n\tby dpdk.org (Postfix) with ESMTP id 19F001C190\n\tfor <dev@dpdk.org>; Fri, 4 Oct 2019 00:44:49 +0200 (CEST)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n\tby usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5460615A1;\n\tThu, 3 Oct 2019 15:44:48 -0700 (PDT)", "from dp6132.austin.arm.com (dp6132.austin.arm.com [10.118.12.38])\n\tby usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id\n\t4D83C3F534; Thu, 3 Oct 2019 15:44:48 -0700 (PDT)" ], "From": "Dharmik Thakkar <dharmik.thakkar@arm.com>", "To": "Wenzhuo Lu <wenzhuo.lu@intel.com>,\n\tKonstantin Ananyev <konstantin.ananyev@intel.com>", "Cc": "dev@dpdk.org, stephen@networkplumber.org, honnappa.nagarahalli@arm.com, \n\tDharmik Thakkar <dharmik.thakkar@arm.com>", "Date": "Thu, 3 Oct 2019 22:44:19 +0000", "Message-Id": "<20191003224419.23968-1-dharmik.thakkar@arm.com>", "X-Mailer": "git-send-email 2.17.1", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] net/ixgbe: avoid multpile definitions of 'bool'", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Compilation issue arises due to multiple definitions of 'bool'\nin 'ixgbe_ethdev.h'.\n\nError:\n'/dpdk/drivers/net/ixgbe/ixgbe_ethdev.c: In function\n‘ixgbe_dev_setup_link_alarm_handler’:\n/dpdk/drivers/net/ixgbe/ixgbe_ethdev.c:4075:43:\nerror: passing argument 3 of ‘ixgbe_get_link_capabilities’ from\nincompatible pointer type [-Werror=incompatible-pointer-types]\n ixgbe_get_link_capabilities(hw, &speed, &autoneg);\n ^\nIn file included from /dpdk/drivers/net/ixgbe/ixgbe_ethdev.c:41:0:\n/dpdk/drivers/net/ixgbe/base/ixgbe_api.h:63:5: note: expected\n‘bool * {aka int *}’ but argument is of type ‘_Bool *’'\n\nSigned-off-by: Dharmik Thakkar <dharmik.thakkar@arm.com>\nReviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\n---\n drivers/net/ixgbe/base/ixgbe_osdep.h | 4 +---\n drivers/net/ixgbe/ixgbe_ethdev.c | 7 ++++---\n 2 files changed, 5 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/ixgbe/base/ixgbe_osdep.h b/drivers/net/ixgbe/base/ixgbe_osdep.h\nindex ea8dc1cbe570..844d1701f595 100644\n--- a/drivers/net/ixgbe/base/ixgbe_osdep.h\n+++ b/drivers/net/ixgbe/base/ixgbe_osdep.h\n@@ -9,6 +9,7 @@\n #include <stdint.h>\n #include <stdio.h>\n #include <stdarg.h>\n+#include <stdbool.h>\n #include <rte_common.h>\n #include <rte_debug.h>\n #include <rte_cycles.h>\n@@ -82,9 +83,6 @@ typedef int16_t\t\ts16;\n typedef uint32_t\tu32;\n typedef int32_t\t\ts32;\n typedef uint64_t\tu64;\n-#ifndef __cplusplus\n-typedef int\t\tbool;\n-#endif\n \n #define mb()\trte_mb()\n #define wmb()\trte_wmb()\ndiff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex 7eb3d0567b58..2c5d2e5f9295 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -2589,7 +2589,8 @@ ixgbe_dev_start(struct rte_eth_dev *dev)\n \tstruct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);\n \tstruct rte_intr_handle *intr_handle = &pci_dev->intr_handle;\n \tuint32_t intr_vector = 0;\n-\tint err, link_up = 0, negotiate = 0;\n+\tint err;\n+\tbool link_up = 0, negotiate = 0;\n \tuint32_t speed = 0;\n \tuint32_t allowed_speeds = 0;\n \tint mask = 0;\n@@ -3958,7 +3959,7 @@ ixgbevf_dev_info_get(struct rte_eth_dev *dev,\n \n static int\n ixgbevf_check_link(struct ixgbe_hw *hw, ixgbe_link_speed *speed,\n-\t\t int *link_up, int wait_to_complete)\n+\t\t bool *link_up, int wait_to_complete)\n {\n \tstruct ixgbe_adapter *adapter = container_of(hw,\n \t\t\t\t\t\t struct ixgbe_adapter, hw);\n@@ -4089,7 +4090,7 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev,\n \tixgbe_link_speed link_speed = IXGBE_LINK_SPEED_UNKNOWN;\n \tstruct ixgbe_interrupt *intr =\n \t\tIXGBE_DEV_PRIVATE_TO_INTR(dev->data->dev_private);\n-\tint link_up;\n+\tbool link_up;\n \tint diag;\n \tint wait = 1;\n \n", "prefixes": [] }