Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/60478/?format=api
{ "id": 60478, "url": "http://patches.dpdk.org/api/patches/60478/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191002232601.22715-16-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191002232601.22715-16-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191002232601.22715-16-ajit.khaparde@broadcom.com", "date": "2019-10-02T23:25:56", "name": "[v2,15/20] net/bnxt: handle cleanup if flow creation fails", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "9c5fcfc08ddccbf0aa0ffb87e50781d39079cd79", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191002232601.22715-16-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 6678, "url": "http://patches.dpdk.org/api/series/6678/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6678", "date": "2019-10-02T23:25:44", "name": "bnxt patchset to improve rte flow support", "version": 2, "mbox": "http://patches.dpdk.org/series/6678/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/60478/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/60478/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 45BF61BFF5;\n\tThu, 3 Oct 2019 01:26:47 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (unknown [192.19.229.170])\n\tby dpdk.org (Postfix) with ESMTP id 445582C02\n\tfor <dev@dpdk.org>; Thu, 3 Oct 2019 01:26:11 +0200 (CEST)", "from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net\n\t[10.75.242.48])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 6D92F30C2CC;\n\tWed, 2 Oct 2019 16:24:57 -0700 (PDT)", "from localhost.localdomain (unknown [10.230.30.225])\n\tby mail-irv-17.broadcom.com (Postfix) with ESMTP id DBE3A14008D;\n\tWed, 2 Oct 2019 16:26:09 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 6D92F30C2CC", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1570058697;\n\tbh=/CffxNuaM3IGpTT5GwKgzDmshKv6wT4+21hQCI6BEBo=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=GIonFUHwB9LRF9Jva8eD4S4xgiiBM54QKUtdVWBU5175XWRPkpgN9D8S4gtpwzz2+\n\tCAyrDwzZ+XI/ZKRXedfsquVtvASVqZ5cRCfXQgZ7LwjBHkQibBcjArcjoKRfQbg5Xa\n\tSHmjzGBR0V9CCcSMyB76EXDwiDxdi8ARBh/rcuy8=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, Rahul Gupta <rahul.gupta@broadcom.com>,\n\tVenkat Duvvuru <venkatkumar.duvvuru@broadcom.com>,\n\tKalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com>", "Date": "Wed, 2 Oct 2019 16:25:56 -0700", "Message-Id": "<20191002232601.22715-16-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.20.1 (Apple Git-117)", "In-Reply-To": "<20191002232601.22715-1-ajit.khaparde@broadcom.com>", "References": "<20191002232601.22715-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 15/20] net/bnxt: handle cleanup if flow\n\tcreation fails", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "If flow creation fails because of an HWRM command failure or\nor some other reason, reset the vnic and rxq info set earlier.\n\nReviewed-by: Rahul Gupta <rahul.gupta@broadcom.com>\nReviewed-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>\nReviewed-by: Kalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com>\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_flow.c | 66 +++++++++++++++++++++++++++++++++---\n 1 file changed, 61 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c\nindex 7fdd50d706..938d24be61 100644\n--- a/drivers/net/bnxt/bnxt_flow.c\n+++ b/drivers/net/bnxt/bnxt_flow.c\n@@ -177,6 +177,14 @@ bnxt_validate_and_parse_flow_type(struct bnxt *bp,\n \t\t\treturn -rte_errno;\n \t\t}\n \n+\t\tif (!item->spec || !item->mask) {\n+\t\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM,\n+\t\t\t\t\t item,\n+\t\t\t\t\t \"spec/mask is NULL\");\n+\t\t\treturn -rte_errno;\n+\t\t}\n+\n \t\tswitch (item->type) {\n \t\tcase RTE_FLOW_ITEM_TYPE_ANY:\n \t\t\tinner =\n@@ -971,11 +979,11 @@ bnxt_validate_and_parse_flow(struct rte_eth_dev *dev,\n \t\tbnxt_flow_non_void_action(actions);\n \tstruct bnxt *bp = dev->data->dev_private;\n \tstruct rte_eth_conf *dev_conf = &bp->eth_dev->data->dev_conf;\n+\tstruct bnxt_vnic_info *vnic = NULL, *vnic0 = NULL;\n \tconst struct rte_flow_action_queue *act_q;\n \tconst struct rte_flow_action_vf *act_vf;\n \tstruct bnxt_filter_info *filter1 = NULL;\n \tconst struct rte_flow_action_rss *rss;\n-\tstruct bnxt_vnic_info *vnic, *vnic0;\n \tstruct bnxt_rx_queue *rxq = NULL;\n \tint dflt_vnic, vnic_id;\n \tunsigned int rss_idx;\n@@ -1077,8 +1085,15 @@ bnxt_validate_and_parse_flow(struct rte_eth_dev *dev,\n \t\tPMD_DRV_LOG(DEBUG, \"VNIC found\\n\");\n \n \t\trc = bnxt_vnic_prep(bp, vnic);\n-\t\tif (rc)\n+\t\tif (rc) {\n+\t\t\trte_flow_error_set(error,\n+\t\t\t\t\t EINVAL,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\t\t\t act,\n+\t\t\t\t\t \"VNIC prep fail\");\n+\t\t\trc = -rte_errno;\n \t\t\tgoto ret;\n+\t\t}\n \n \t\tPMD_DRV_LOG(DEBUG,\n \t\t\t \"vnic[%d] = %p vnic->fw_grp_ids = %p\\n\",\n@@ -1091,7 +1106,12 @@ bnxt_validate_and_parse_flow(struct rte_eth_dev *dev,\n \t\tfilter->dst_id = vnic->fw_vnic_id;\n \t\tfilter1 = bnxt_get_l2_filter(bp, filter, vnic);\n \t\tif (filter1 == NULL) {\n-\t\t\trc = -ENOSPC;\n+\t\t\trte_flow_error_set(error,\n+\t\t\t\t\t ENOSPC,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\t\t\t act,\n+\t\t\t\t\t \"Filter not available\");\n+\t\t\trc = -rte_errno;\n \t\t\tgoto ret;\n \t\t}\n \n@@ -1119,7 +1139,12 @@ bnxt_validate_and_parse_flow(struct rte_eth_dev *dev,\n \t\tvnic0 = &bp->vnic_info[0];\n \t\tfilter1 = bnxt_get_l2_filter(bp, filter, vnic0);\n \t\tif (filter1 == NULL) {\n-\t\t\trc = -ENOSPC;\n+\t\t\trte_flow_error_set(error,\n+\t\t\t\t\t ENOSPC,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\t\t\t act,\n+\t\t\t\t\t \"New filter not available\");\n+\t\t\trc = -rte_errno;\n \t\t\tgoto ret;\n \t\t}\n \n@@ -1182,6 +1207,11 @@ bnxt_validate_and_parse_flow(struct rte_eth_dev *dev,\n \t\tvnic0 = &bp->vnic_info[0];\n \t\tfilter1 = bnxt_get_l2_filter(bp, filter, vnic0);\n \t\tif (filter1 == NULL) {\n+\t\t\trte_flow_error_set(error,\n+\t\t\t\t\t ENOSPC,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\t\t\t act,\n+\t\t\t\t\t \"New filter not available\");\n \t\t\trc = -ENOSPC;\n \t\t\tgoto ret;\n \t\t}\n@@ -1278,8 +1308,15 @@ bnxt_validate_and_parse_flow(struct rte_eth_dev *dev,\n \t\tvnic->func_default = 0;\t//This is not a default VNIC.\n \n \t\trc = bnxt_vnic_prep(bp, vnic);\n-\t\tif (rc)\n+\t\tif (rc) {\n+\t\t\trte_flow_error_set(error,\n+\t\t\t\t\t EINVAL,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\t\t\t act,\n+\t\t\t\t\t \"VNIC prep fail\");\n+\t\t\trc = -rte_errno;\n \t\t\tgoto ret;\n+\t\t}\n \n \t\tPMD_DRV_LOG(DEBUG,\n \t\t\t \"vnic[%d] = %p vnic->fw_grp_ids = %p\\n\",\n@@ -1334,6 +1371,11 @@ bnxt_validate_and_parse_flow(struct rte_eth_dev *dev,\n \t\tfilter->dst_id = vnic->fw_vnic_id;\n \t\tfilter1 = bnxt_get_l2_filter(bp, filter, vnic);\n \t\tif (filter1 == NULL) {\n+\t\t\trte_flow_error_set(error,\n+\t\t\t\t\t ENOSPC,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\t\t\t act,\n+\t\t\t\t\t \"New filter not available\");\n \t\t\trc = -ENOSPC;\n \t\t\tgoto ret;\n \t\t}\n@@ -1367,7 +1409,18 @@ bnxt_validate_and_parse_flow(struct rte_eth_dev *dev,\n \t\trc = -rte_errno;\n \t\tgoto ret;\n \t}\n+\n+\treturn rc;\n ret:\n+\n+\t//TODO: Cleanup according to ACTION TYPE.\n+\tif (rte_errno) {\n+\t\tif (vnic && STAILQ_EMPTY(&vnic->filter))\n+\t\t\tvnic->rx_queue_cnt = 0;\n+\n+\t\tif (rxq && !vnic->rx_queue_cnt)\n+\t\t\trxq->vnic = &bp->vnic_info[0];\n+\t}\n \treturn rc;\n }\n \n@@ -1414,6 +1467,8 @@ bnxt_flow_validate(struct rte_eth_dev *dev,\n \n \tret = bnxt_validate_and_parse_flow(dev, pattern, actions, attr,\n \t\t\t\t\t error, filter);\n+\tif (ret)\n+\t\tgoto exit;\n \n \tvnic = find_matching_vnic(bp, filter);\n \tif (vnic) {\n@@ -1434,6 +1489,7 @@ bnxt_flow_validate(struct rte_eth_dev *dev,\n \telse\n \t\tbnxt_hwrm_clear_l2_filter(bp, filter);\n \n+exit:\n \t/* No need to hold on to this filter if we are just validating flow */\n \tfilter->fw_l2_filter_id = UINT64_MAX;\n \tbnxt_free_filter(bp, filter);\n", "prefixes": [ "v2", "15/20" ] }