Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/60470/?format=api
http://patches.dpdk.org/api/patches/60470/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191002232601.22715-11-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191002232601.22715-11-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191002232601.22715-11-ajit.khaparde@broadcom.com", "date": "2019-10-02T23:25:51", "name": "[v2,10/20] net/bnxt: allow only unicast MAC address filter creation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "9a9604b883b8ad52fff2a946a3b937396d02d538", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191002232601.22715-11-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 6678, "url": "http://patches.dpdk.org/api/series/6678/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6678", "date": "2019-10-02T23:25:44", "name": "bnxt patchset to improve rte flow support", "version": 2, "mbox": "http://patches.dpdk.org/series/6678/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/60470/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/60470/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4513B1BFBE;\n\tThu, 3 Oct 2019 01:26:26 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (unknown [192.19.229.170])\n\tby dpdk.org (Postfix) with ESMTP id 64B9D1BF8D\n\tfor <dev@dpdk.org>; Thu, 3 Oct 2019 01:26:10 +0200 (CEST)", "from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net\n\t[10.75.242.48])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 7B4AC30C297;\n\tWed, 2 Oct 2019 16:24:56 -0700 (PDT)", "from localhost.localdomain (unknown [10.230.30.225])\n\tby mail-irv-17.broadcom.com (Postfix) with ESMTP id 8499B140069;\n\tWed, 2 Oct 2019 16:26:08 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 7B4AC30C297", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1570058696;\n\tbh=Rdc9alXsklOutLdsn8Jih5r7Ki61lJiln31FRszC3yg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=RpWKT8g/TpOff4rBAMExBE9kOpnN9c84ov8LDB78KolBWuAc0k75jbr5IfKBUr1+H\n\trAYwpxntnyIr39v8ykWXzhPQR11Xibu98fx+xfTqVV93ikZAzT/VkHEqu++o5Ee0V1\n\tVG3c1JSq2dIKP/1dDWCqmd2f4Z3zOqMrwxSspWbU=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, Rahul Gupta <rahul.gupta@broadcom.com>,\n\tSantoshkumar Karanappa Rastapur <santosh.rastapur@broadcom.com>", "Date": "Wed, 2 Oct 2019 16:25:51 -0700", "Message-Id": "<20191002232601.22715-11-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.20.1 (Apple Git-117)", "In-Reply-To": "<20191002232601.22715-1-ajit.khaparde@broadcom.com>", "References": "<20191002232601.22715-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 10/20] net/bnxt: allow only unicast MAC\n\taddress filter creation", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Check if the application is trying to create filters using\nbroadcast and multicast MAC address and reject it.\n\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\nReviewed-by: Rahul Gupta <rahul.gupta@broadcom.com>\nReviewed-by: Santoshkumar Karanappa Rastapur <santosh.rastapur@broadcom.com>\n---\n drivers/net/bnxt/bnxt_flow.c | 16 ++++++++++++++++\n 1 file changed, 16 insertions(+)", "diff": "diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c\nindex aedbd6d13b..cdfbb6c22f 100644\n--- a/drivers/net/bnxt/bnxt_flow.c\n+++ b/drivers/net/bnxt/bnxt_flow.c\n@@ -219,6 +219,14 @@ bnxt_validate_and_parse_flow_type(struct bnxt *bp,\n \t\t\t}\n \n \t\t\tif (rte_is_broadcast_ether_addr(ð_mask->dst)) {\n+\t\t\t\tif (!rte_is_unicast_ether_addr(ð_spec->dst)) {\n+\t\t\t\t\trte_flow_error_set(error,\n+\t\t\t\t\t\t\t EINVAL,\n+\t\t\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM,\n+\t\t\t\t\t\t\t item,\n+\t\t\t\t\t\t\t \"DMAC is invalid\");\n+\t\t\t\t\treturn -rte_errno;\n+\t\t\t\t}\n \t\t\t\trte_memcpy(filter->dst_macaddr,\n \t\t\t\t\t ð_spec->dst, RTE_ETHER_ADDR_LEN);\n \t\t\t\ten |= use_ntuple ?\n@@ -233,6 +241,14 @@ bnxt_validate_and_parse_flow_type(struct bnxt *bp,\n \t\t\t}\n \n \t\t\tif (rte_is_broadcast_ether_addr(ð_mask->src)) {\n+\t\t\t\tif (!rte_is_unicast_ether_addr(ð_spec->src)) {\n+\t\t\t\t\trte_flow_error_set(error,\n+\t\t\t\t\t\t\t EINVAL,\n+\t\t\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM,\n+\t\t\t\t\t\t\t item,\n+\t\t\t\t\t\t\t \"SMAC is invalid\");\n+\t\t\t\t\treturn -rte_errno;\n+\t\t\t\t}\n \t\t\t\trte_memcpy(filter->src_macaddr,\n \t\t\t\t\t ð_spec->src, RTE_ETHER_ADDR_LEN);\n \t\t\t\ten |= use_ntuple ?\n", "prefixes": [ "v2", "10/20" ] }{ "id": 60470, "url": "