Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/60469/?format=api
{ "id": 60469, "url": "http://patches.dpdk.org/api/patches/60469/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191002232601.22715-10-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191002232601.22715-10-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191002232601.22715-10-ajit.khaparde@broadcom.com", "date": "2019-10-02T23:25:50", "name": "[v2,09/20] net/bnxt: fix an issue in setting default MAC address", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "72a11c7c3c03868781277ab09373572f8d32731e", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191002232601.22715-10-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 6678, "url": "http://patches.dpdk.org/api/series/6678/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6678", "date": "2019-10-02T23:25:44", "name": "bnxt patchset to improve rte flow support", "version": 2, "mbox": "http://patches.dpdk.org/series/6678/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/60469/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/60469/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E39871BFBA;\n\tThu, 3 Oct 2019 01:26:24 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (unknown [192.19.229.170])\n\tby dpdk.org (Postfix) with ESMTP id 6F8551BF8E\n\tfor <dev@dpdk.org>; Thu, 3 Oct 2019 01:26:10 +0200 (CEST)", "from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net\n\t[10.75.242.48])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id C692630C28C;\n\tWed, 2 Oct 2019 16:24:55 -0700 (PDT)", "from localhost.localdomain (unknown [10.230.30.225])\n\tby mail-irv-17.broadcom.com (Postfix) with ESMTP id 4142514008B;\n\tWed, 2 Oct 2019 16:26:08 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com C692630C28C", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1570058695;\n\tbh=pKWI8tMnBMa3QLVnCxij9tS066nPdbQrxpKuf4Q3A8s=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=vjFuncR2ScVHjz5ppA/EFuituraIQkisoyewJwCxM3SeLIP4cJteoq49hR+ez4OTq\n\twZBsXrcm7kNhezmy7wkHueKHb/iZ1iP5zhLwDJQSN5q8Vhk2viV9HPq0Fh08JvvvnO\n\t4BKH1PMMdgEa5LbAf5RlljFyZjM5HVb+Bsxs07Mo=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, Kalesh AP <kalesh-anakkur.purayil@broadcom.com>, \n\tSomnath Kotur <somnath.kotur@broadcom.com>", "Date": "Wed, 2 Oct 2019 16:25:50 -0700", "Message-Id": "<20191002232601.22715-10-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.20.1 (Apple Git-117)", "In-Reply-To": "<20191002232601.22715-1-ajit.khaparde@broadcom.com>", "References": "<20191002232601.22715-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 09/20] net/bnxt: fix an issue in setting\n\tdefault MAC address", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n\nDriver was incorrectly programming the MAC with the already\nconfigured one instead of the newly requested MAC by user.\n\nAlso, fix to restore the old mac address back to the default\nvnic filter if the mac update operation fails.\n\nFixes: 68f589f2c728e (\"net/bnxt: fix setting primary MAC address\")\n\nSigned-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\nReviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>\n---\n drivers/net/bnxt/bnxt_ethdev.c | 7 +++++--\n 1 file changed, 5 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 7cd3213558..2c9eaaa2ef 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -1904,7 +1904,7 @@ bnxt_set_default_mac_addr_op(struct rte_eth_dev *dev,\n \t\tif (filter->mac_index != 0)\n \t\t\tcontinue;\n \n-\t\tmemcpy(filter->l2_addr, bp->mac_addr, RTE_ETHER_ADDR_LEN);\n+\t\tmemcpy(filter->l2_addr, addr, RTE_ETHER_ADDR_LEN);\n \t\tmemset(filter->l2_addr_mask, 0xff, RTE_ETHER_ADDR_LEN);\n \t\tfilter->flags |= HWRM_CFA_L2_FILTER_ALLOC_INPUT_FLAGS_PATH_RX |\n \t\t\tHWRM_CFA_L2_FILTER_ALLOC_INPUT_FLAGS_OUTERMOST;\n@@ -1913,8 +1913,11 @@ bnxt_set_default_mac_addr_op(struct rte_eth_dev *dev,\n \t\t\tHWRM_CFA_L2_FILTER_ALLOC_INPUT_ENABLES_L2_ADDR_MASK;\n \n \t\trc = bnxt_hwrm_set_l2_filter(bp, vnic->fw_vnic_id, filter);\n-\t\tif (rc)\n+\t\tif (rc) {\n+\t\t\tmemcpy(filter->l2_addr, bp->mac_addr,\n+\t\t\t RTE_ETHER_ADDR_LEN);\n \t\t\treturn rc;\n+\t\t}\n \n \t\tmemcpy(bp->mac_addr, addr, RTE_ETHER_ADDR_LEN);\n \t\tPMD_DRV_LOG(DEBUG, \"Set MAC addr\\n\");\n", "prefixes": [ "v2", "09/20" ] }