Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/60437/?format=api
{ "id": 60437, "url": "http://patches.dpdk.org/api/patches/60437/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191002171745.4504-15-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191002171745.4504-15-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191002171745.4504-15-ajit.khaparde@broadcom.com", "date": "2019-10-02T17:17:43", "name": "[v3,14/16] net/bnxt: fix a segfault in secondary process", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d1e4f31d6ac718cfd82d6cb1cec6c97f7afac2b8", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191002171745.4504-15-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 6669, "url": "http://patches.dpdk.org/api/series/6669/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6669", "date": "2019-10-02T17:17:29", "name": "bnxt patchset", "version": 3, "mbox": "http://patches.dpdk.org/series/6669/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/60437/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/60437/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3CBBA1BF6E;\n\tWed, 2 Oct 2019 19:18:30 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (unknown [192.19.229.170])\n\tby dpdk.org (Postfix) with ESMTP id 361831BF13;\n\tWed, 2 Oct 2019 19:17:55 +0200 (CEST)", "from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net\n\t[10.75.242.48])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id CED1630D351;\n\tWed, 2 Oct 2019 10:16:37 -0700 (PDT)", "from C02VPB22HTD6.wifi.broadcom.net (c02vpb22htd6.wifi.broadcom.net\n\t[10.69.74.102])\n\tby mail-irv-17.broadcom.com (Postfix) with ESMTP id 5910C140069;\n\tWed, 2 Oct 2019 10:17:49 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com CED1630D351", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1570036597;\n\tbh=zhL5RYF4l6uqLJtFGyhU6/mfJ/ClUx0qYM8lGN6Mm7Y=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=fvAy4FqDfXONavjGbJ3vAauOtApg1E4GsAfk86tg3SRabJG/88N/k0uRPeNqRY05h\n\thAAhM3K0lzLHGallLNMoGSAYi8ky/8PpMcMI/sYJfvBg2MaqkfVj5scPev242BTYjW\n\t2uUTaPs8jyeE+v/tl+XklP1FRLU/dUgnfksMRiSo=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, Stephen Hemminger <stephen@networkplumber.org>, \n\tstable@dpdk.org", "Date": "Wed, 2 Oct 2019 10:17:43 -0700", "Message-Id": "<20191002171745.4504-15-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.20.1 (Apple Git-117)", "In-Reply-To": "<20191002171745.4504-1-ajit.khaparde@broadcom.com>", "References": "<20191002055423.99659-1-ajit.khaparde@broadcom.com>\n\t<20191002171745.4504-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 14/16] net/bnxt: fix a segfault in secondary\n\tprocess", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Stephen Hemminger <stephen@networkplumber.org>\n\nThe secondary process should not modify device state when\ninit is called. The pci device information pointed to by\ndev_private pointer is not correct in secondary process.\n\nFixes: b7778e8a1c00 (\"net/bnxt: refactor to properly allocate resources for PF/VF\")\nCc: stable@dpdk.org\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nAcked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_ethdev.c | 16 +++++++++-------\n 1 file changed, 9 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 0159be3462..5985963bf7 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -521,6 +521,7 @@ static int bnxt_init_nic(struct bnxt *bp)\n static int bnxt_dev_info_get_op(struct rte_eth_dev *eth_dev,\n \t\t\t\tstruct rte_eth_dev_info *dev_info)\n {\n+\tstruct rte_pci_device *pdev = RTE_DEV_TO_PCI(eth_dev->device);\n \tstruct bnxt *bp = eth_dev->data->dev_private;\n \tuint16_t max_vnics, i, j, vpool, vrxq;\n \tunsigned int max_rx_rings;\n@@ -536,7 +537,8 @@ static int bnxt_dev_info_get_op(struct rte_eth_dev *eth_dev,\n \n \t/* PF/VF specifics */\n \tif (BNXT_PF(bp))\n-\t\tdev_info->max_vfs = bp->pdev->max_vfs;\n+\t\tdev_info->max_vfs = pdev->max_vfs;\n+\n \tmax_rx_rings = RTE_MIN(bp->max_rx_rings, bp->max_stat_ctx);\n \t/* For the sake of symmetry, max_rx_queues = max_tx_queues */\n \tdev_info->max_rx_queues = max_rx_rings;\n@@ -4488,12 +4490,6 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev)\n \tif (version_printed++ == 0)\n \t\tPMD_DRV_LOG(INFO, \"%s\\n\", bnxt_version);\n \n-\trte_eth_copy_pci_info(eth_dev, pci_dev);\n-\n-\tbp = eth_dev->data->dev_private;\n-\n-\tbp->dev_stopped = 1;\n-\n \teth_dev->dev_ops = &bnxt_dev_ops;\n \teth_dev->rx_pkt_burst = &bnxt_recv_pkts;\n \teth_dev->tx_pkt_burst = &bnxt_xmit_pkts;\n@@ -4505,6 +4501,12 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev)\n \tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n \t\treturn 0;\n \n+\trte_eth_copy_pci_info(eth_dev, pci_dev);\n+\n+\tbp = eth_dev->data->dev_private;\n+\n+\tbp->dev_stopped = 1;\n+\n \tif (bnxt_vf_pciid(pci_dev->id.device_id))\n \t\tbp->flags |= BNXT_FLAG_VF;\n \n", "prefixes": [ "v3", "14/16" ] }