Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/60434/?format=api
{ "id": 60434, "url": "http://patches.dpdk.org/api/patches/60434/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191002171745.4504-13-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191002171745.4504-13-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191002171745.4504-13-ajit.khaparde@broadcom.com", "date": "2019-10-02T17:17:41", "name": "[v3,12/16] net/bnxt: fix accessing variable before null check", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "14f5525aad76095200444ae06ec1a20c09925f66", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191002171745.4504-13-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 6669, "url": "http://patches.dpdk.org/api/series/6669/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6669", "date": "2019-10-02T17:17:29", "name": "bnxt patchset", "version": 3, "mbox": "http://patches.dpdk.org/series/6669/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/60434/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/60434/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E64411BF92;\n\tWed, 2 Oct 2019 19:18:19 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (unknown [192.19.229.170])\n\tby dpdk.org (Postfix) with ESMTP id 8D8D41BF2D;\n\tWed, 2 Oct 2019 19:17:54 +0200 (CEST)", "from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net\n\t[10.75.242.48])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 667B330D34A;\n\tWed, 2 Oct 2019 10:16:37 -0700 (PDT)", "from C02VPB22HTD6.wifi.broadcom.net (c02vpb22htd6.wifi.broadcom.net\n\t[10.69.74.102])\n\tby mail-irv-17.broadcom.com (Postfix) with ESMTP id 1CC20140091;\n\tWed, 2 Oct 2019 10:17:49 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 667B330D34A", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1570036597;\n\tbh=2vpB3r+t6/bDkz8UXC2zSQYa7PqgX74lrTumH+Ax0oM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=DMg4nXRHe+CdmO7NCcG1nClHt0sZ5+zU8tQrgVCLx+1Etm6zF4ZfiZPehS6svAEMP\n\tf72UC1CpP3mBPnWyt8NEiargPRhlUNjMqSdQxW/ZcHtfL+53WeBXKLh4W13tRsfw8b\n\tuDhf0NaMPTxtbeqQ5E0nd+rmLaVi9RFeiQ1jF20w=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, Kalesh AP <kalesh-anakkur.purayil@broadcom.com>, \n\tstable@dpdk.org,\n\tSantoshkumar Karanappa Rastapur <santosh.rastapur@broadcom.com>", "Date": "Wed, 2 Oct 2019 10:17:41 -0700", "Message-Id": "<20191002171745.4504-13-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.20.1 (Apple Git-117)", "In-Reply-To": "<20191002171745.4504-1-ajit.khaparde@broadcom.com>", "References": "<20191002055423.99659-1-ajit.khaparde@broadcom.com>\n\t<20191002171745.4504-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 12/16] net/bnxt: fix accessing variable before\n\tnull check", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n\nCheck input argument \"rxq\" in bnxt_rx_queue_release_mbufs(), to be sure\nvariable is not NULL before accessing it.\n\nFixes: 9b63c6fd70e3 (\"net/bnxt: support Rx/Tx queue start/stop\")\nCc: stable@dpdk.org\nSigned-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Santoshkumar Karanappa Rastapur <santosh.rastapur@broadcom.com>\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_rxq.c | 53 +++++++++++++++++++------------------\n 1 file changed, 27 insertions(+), 26 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c\nindex 4b506f8653..dac8ccb167 100644\n--- a/drivers/net/bnxt/bnxt_rxq.c\n+++ b/drivers/net/bnxt/bnxt_rxq.c\n@@ -207,39 +207,40 @@ void bnxt_rx_queue_release_mbufs(struct bnxt_rx_queue *rxq)\n \tstruct bnxt_tpa_info *tpa_info;\n \tuint16_t i;\n \n+\tif (!rxq)\n+\t\treturn;\n+\n \trte_spinlock_lock(&rxq->lock);\n \n-\tif (rxq) {\n-\t\tsw_ring = rxq->rx_ring->rx_buf_ring;\n-\t\tif (sw_ring) {\n-\t\t\tfor (i = 0;\n-\t\t\t i < rxq->rx_ring->rx_ring_struct->ring_size; i++) {\n-\t\t\t\tif (sw_ring[i].mbuf) {\n-\t\t\t\t\trte_pktmbuf_free_seg(sw_ring[i].mbuf);\n-\t\t\t\t\tsw_ring[i].mbuf = NULL;\n-\t\t\t\t}\n+\tsw_ring = rxq->rx_ring->rx_buf_ring;\n+\tif (sw_ring) {\n+\t\tfor (i = 0;\n+\t\t i < rxq->rx_ring->rx_ring_struct->ring_size; i++) {\n+\t\t\tif (sw_ring[i].mbuf) {\n+\t\t\t\trte_pktmbuf_free_seg(sw_ring[i].mbuf);\n+\t\t\t\tsw_ring[i].mbuf = NULL;\n \t\t\t}\n \t\t}\n-\t\t/* Free up mbufs in Agg ring */\n-\t\tsw_ring = rxq->rx_ring->ag_buf_ring;\n-\t\tif (sw_ring) {\n-\t\t\tfor (i = 0;\n-\t\t\t i < rxq->rx_ring->ag_ring_struct->ring_size; i++) {\n-\t\t\t\tif (sw_ring[i].mbuf) {\n-\t\t\t\t\trte_pktmbuf_free_seg(sw_ring[i].mbuf);\n-\t\t\t\t\tsw_ring[i].mbuf = NULL;\n-\t\t\t\t}\n+\t}\n+\t/* Free up mbufs in Agg ring */\n+\tsw_ring = rxq->rx_ring->ag_buf_ring;\n+\tif (sw_ring) {\n+\t\tfor (i = 0;\n+\t\t i < rxq->rx_ring->ag_ring_struct->ring_size; i++) {\n+\t\t\tif (sw_ring[i].mbuf) {\n+\t\t\t\trte_pktmbuf_free_seg(sw_ring[i].mbuf);\n+\t\t\t\tsw_ring[i].mbuf = NULL;\n \t\t\t}\n \t\t}\n+\t}\n \n-\t\t/* Free up mbufs in TPA */\n-\t\ttpa_info = rxq->rx_ring->tpa_info;\n-\t\tif (tpa_info) {\n-\t\t\tfor (i = 0; i < BNXT_TPA_MAX; i++) {\n-\t\t\t\tif (tpa_info[i].mbuf) {\n-\t\t\t\t\trte_pktmbuf_free_seg(tpa_info[i].mbuf);\n-\t\t\t\t\ttpa_info[i].mbuf = NULL;\n-\t\t\t\t}\n+\t/* Free up mbufs in TPA */\n+\ttpa_info = rxq->rx_ring->tpa_info;\n+\tif (tpa_info) {\n+\t\tfor (i = 0; i < BNXT_TPA_MAX; i++) {\n+\t\t\tif (tpa_info[i].mbuf) {\n+\t\t\t\trte_pktmbuf_free_seg(tpa_info[i].mbuf);\n+\t\t\t\ttpa_info[i].mbuf = NULL;\n \t\t\t}\n \t\t}\n \t}\n", "prefixes": [ "v3", "12/16" ] }