Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/60433/?format=api
{ "id": 60433, "url": "http://patches.dpdk.org/api/patches/60433/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191002171745.4504-9-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191002171745.4504-9-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191002171745.4504-9-ajit.khaparde@broadcom.com", "date": "2019-10-02T17:17:37", "name": "[v3,08/16] net/bnxt: fix use of deferred start of transmit queues", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "75e9e010f66e49274af95d627f830d2f2432d5ff", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191002171745.4504-9-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 6669, "url": "http://patches.dpdk.org/api/series/6669/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6669", "date": "2019-10-02T17:17:29", "name": "bnxt patchset", "version": 3, "mbox": "http://patches.dpdk.org/series/6669/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/60433/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/60433/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5869E1BF8E;\n\tWed, 2 Oct 2019 19:18:18 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (unknown [192.19.229.170])\n\tby dpdk.org (Postfix) with ESMTP id 79B221BF29\n\tfor <dev@dpdk.org>; Wed, 2 Oct 2019 19:17:54 +0200 (CEST)", "from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net\n\t[10.75.242.48])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id B25E330D36F;\n\tWed, 2 Oct 2019 10:16:36 -0700 (PDT)", "from C02VPB22HTD6.wifi.broadcom.net (c02vpb22htd6.wifi.broadcom.net\n\t[10.69.74.102])\n\tby mail-irv-17.broadcom.com (Postfix) with ESMTP id 8EF1E14008B;\n\tWed, 2 Oct 2019 10:17:48 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com B25E330D36F", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1570036596;\n\tbh=kEclmymkzIuPieqNGvTixgNLM/Rfd9+YiOmrgryoMH4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ESIoXpp4eo1C7HKCiUNIPJBO/4kr38HsmdG7Nh2JJpxctaRoHMcEk2rwEAEAuHjSB\n\tybLX5vN9BDKl3pqPZat8y7EkhBo1PZdNKF9CCO71w/4GjUvVmGS3ARhH84UAqYPYsy\n\tjnLe0sKYEJfbLnikjIUl7E+/fBdQJ5AwUlLReuVQ=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, Kalesh AP <kalesh-anakkur.purayil@broadcom.com>, \n\tLance Richardson <lance.richardson@broadcom.com>", "Date": "Wed, 2 Oct 2019 10:17:37 -0700", "Message-Id": "<20191002171745.4504-9-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.20.1 (Apple Git-117)", "In-Reply-To": "<20191002171745.4504-1-ajit.khaparde@broadcom.com>", "References": "<20191002055423.99659-1-ajit.khaparde@broadcom.com>\n\t<20191002171745.4504-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 08/16] net/bnxt: fix use of deferred start of\n\ttransmit queues", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n\nDriver should not change \"deferred_start\" state of the tx queues.\nIt should get the state in queue_setup_op() and use that value.\n\nSince the deferred start state was being used in the packet transmit\nfunctions to determine whether the queue has been stopped already,\nintroduced a per-txq flag to track queue stopped/started state.\n\nFixes: 9b63c6fd70e3 (\"net/bnxt: support Rx/Tx queue start/stop\")\n\nSigned-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Lance Richardson <lance.richardson@broadcom.com>\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_rxtx_vec_sse.c | 2 +-\n drivers/net/bnxt/bnxt_txq.c | 5 +++++\n drivers/net/bnxt/bnxt_txq.h | 1 +\n drivers/net/bnxt/bnxt_txr.c | 6 +++---\n 4 files changed, 10 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_rxtx_vec_sse.c b/drivers/net/bnxt/bnxt_rxtx_vec_sse.c\nindex 5ae812f3b9..029053e305 100644\n--- a/drivers/net/bnxt/bnxt_rxtx_vec_sse.c\n+++ b/drivers/net/bnxt/bnxt_rxtx_vec_sse.c\n@@ -482,7 +482,7 @@ bnxt_xmit_pkts_vec(void *tx_queue, struct rte_mbuf **tx_pkts,\n \tstruct bnxt_tx_queue *txq = tx_queue;\n \n \t/* Tx queue was stopped; wait for it to be restarted */\n-\tif (unlikely(txq->tx_deferred_start)) {\n+\tif (unlikely(!txq->tx_started)) {\n \t\tPMD_DRV_LOG(DEBUG, \"Tx q stopped;return\\n\");\n \t\treturn 0;\n \t}\ndiff --git a/drivers/net/bnxt/bnxt_txq.c b/drivers/net/bnxt/bnxt_txq.c\nindex 0901324793..ea20d737fe 100644\n--- a/drivers/net/bnxt/bnxt_txq.c\n+++ b/drivers/net/bnxt/bnxt_txq.c\n@@ -131,6 +131,7 @@ int bnxt_tx_queue_setup_op(struct rte_eth_dev *eth_dev,\n \ttxq->bp = bp;\n \ttxq->nb_tx_desc = nb_desc;\n \ttxq->tx_free_thresh = tx_conf->tx_free_thresh;\n+\ttxq->tx_deferred_start = tx_conf->tx_deferred_start;\n \n \trc = bnxt_init_tx_ring_struct(txq, socket_id);\n \tif (rc)\n@@ -157,6 +158,10 @@ int bnxt_tx_queue_setup_op(struct rte_eth_dev *eth_dev,\n \n \teth_dev->data->tx_queues[queue_idx] = txq;\n \n+\tif (txq->tx_deferred_start)\n+\t\ttxq->tx_started = false;\n+\telse\n+\t\ttxq->tx_started = true;\n out:\n \treturn rc;\n }\ndiff --git a/drivers/net/bnxt/bnxt_txq.h b/drivers/net/bnxt/bnxt_txq.h\nindex 9190e3f731..7a442516d2 100644\n--- a/drivers/net/bnxt/bnxt_txq.h\n+++ b/drivers/net/bnxt/bnxt_txq.h\n@@ -24,6 +24,7 @@ struct bnxt_tx_queue {\n \tuint8_t\t\t\twthresh; /* Write-back threshold reg */\n \tuint32_t\t\tctx_curr; /* Hardware context states */\n \tuint8_t\t\t\ttx_deferred_start; /* not in global dev start */\n+\tuint8_t\t\t\ttx_started; /* TX queue is started */\n \n \tstruct bnxt\t\t*bp;\n \tint\t\t\tindex;\ndiff --git a/drivers/net/bnxt/bnxt_txr.c b/drivers/net/bnxt/bnxt_txr.c\nindex 172b480b2e..99d2009055 100644\n--- a/drivers/net/bnxt/bnxt_txr.c\n+++ b/drivers/net/bnxt/bnxt_txr.c\n@@ -469,7 +469,7 @@ uint16_t bnxt_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \tbnxt_handle_tx_cp(txq);\n \n \t/* Tx queue was stopped; wait for it to be restarted */\n-\tif (txq->tx_deferred_start) {\n+\tif (unlikely(!txq->tx_started)) {\n \t\tPMD_DRV_LOG(DEBUG, \"Tx q stopped;return\\n\");\n \t\treturn 0;\n \t}\n@@ -518,7 +518,7 @@ int bnxt_tx_queue_start(struct rte_eth_dev *dev, uint16_t tx_queue_id)\n \t\treturn rc;\n \n \tdev->data->tx_queue_state[tx_queue_id] = RTE_ETH_QUEUE_STATE_STARTED;\n-\ttxq->tx_deferred_start = false;\n+\ttxq->tx_started = true;\n \tPMD_DRV_LOG(DEBUG, \"Tx queue started\\n\");\n \n \treturn 0;\n@@ -538,7 +538,7 @@ int bnxt_tx_queue_stop(struct rte_eth_dev *dev, uint16_t tx_queue_id)\n \tbnxt_handle_tx_cp(txq);\n \n \tdev->data->tx_queue_state[tx_queue_id] = RTE_ETH_QUEUE_STATE_STOPPED;\n-\ttxq->tx_deferred_start = true;\n+\ttxq->tx_started = false;\n \tPMD_DRV_LOG(DEBUG, \"Tx queue stopped\\n\");\n \n \treturn 0;\n", "prefixes": [ "v3", "08/16" ] }