Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/6040/?format=api
http://patches.dpdk.org/api/patches/6040/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1435912347-19499-13-git-send-email-helin.zhang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1435912347-19499-13-git-send-email-helin.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1435912347-19499-13-git-send-email-helin.zhang@intel.com", "date": "2015-07-03T08:32:20", "name": "[dpdk-dev,v9,12/19] app/test: Remove useless code", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1c3a6da6d4c7efb2d2f05a4b3bcfb2f4ed94c0a2", "submitter": { "id": 14, "url": "http://patches.dpdk.org/api/people/14/?format=api", "name": "Zhang, Helin", "email": "helin.zhang@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1435912347-19499-13-git-send-email-helin.zhang@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/6040/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/6040/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 830FD5A43;\n\tFri, 3 Jul 2015 10:33:19 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id 46650C326\n\tfor <dev@dpdk.org>; Fri, 3 Jul 2015 10:33:17 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga103.jf.intel.com with ESMTP; 03 Jul 2015 01:33:12 -0700", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby orsmga001.jf.intel.com with ESMTP; 03 Jul 2015 01:33:09 -0700", "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id t638X7nQ029917;\n\tFri, 3 Jul 2015 16:33:07 +0800", "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid t638X3xw019618; Fri, 3 Jul 2015 16:33:05 +0800", "(from hzhan75@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id t638X2rj019614; \n\tFri, 3 Jul 2015 16:33:02 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.15,398,1432623600\"; d=\"scan'208\";a=\"722280289\"", "From": "Helin Zhang <helin.zhang@intel.com>", "To": "dev@dpdk.org", "Date": "Fri, 3 Jul 2015 16:32:20 +0800", "Message-Id": "<1435912347-19499-13-git-send-email-helin.zhang@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1435912347-19499-1-git-send-email-helin.zhang@intel.com>", "References": "<1435024235-19483-1-git-send-email-helin.zhang@intel.com>\n\t<1435912347-19499-1-git-send-email-helin.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH v9 12/19] app/test: Remove useless code", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Severl useless code lines are added accidently, which blocks packet\ntype unification. They should be deleted at all.\nTo avoid breaking ABI compatibility, all the changes would be\nenabled by RTE_NEXT_ABI, which is disabled by default.\n\nSigned-off-by: Helin Zhang <helin.zhang@intel.com>\n---\n app/test/packet_burst_generator.c | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)\n\nv4 changes:\n* Removed several useless code lines which block packet type unification.\n\nv5 changes:\n* Re-worded the commit logs.\n\nv6 changes:\n* Disabled the code changes for unified packet type by default, to\n avoid breaking ABI compatibility.\n\nv7 changes:\n* Renamed RTE_UNIFIED_PKT_TYPE to RTE_NEXT_ABI.", "diff": "diff --git a/app/test/packet_burst_generator.c b/app/test/packet_burst_generator.c\nindex 28d9e25..d9d808b 100644\n--- a/app/test/packet_burst_generator.c\n+++ b/app/test/packet_burst_generator.c\n@@ -273,19 +273,21 @@ nomore_mbuf:\n \t\tif (ipv4) {\n \t\t\tpkt->vlan_tci = ETHER_TYPE_IPv4;\n \t\t\tpkt->l3_len = sizeof(struct ipv4_hdr);\n-\n+#ifndef RTE_NEXT_ABI\n \t\t\tif (vlan_enabled)\n \t\t\t\tpkt->ol_flags = PKT_RX_IPV4_HDR | PKT_RX_VLAN_PKT;\n \t\t\telse\n \t\t\t\tpkt->ol_flags = PKT_RX_IPV4_HDR;\n+#endif\n \t\t} else {\n \t\t\tpkt->vlan_tci = ETHER_TYPE_IPv6;\n \t\t\tpkt->l3_len = sizeof(struct ipv6_hdr);\n-\n+#ifndef RTE_NEXT_ABI\n \t\t\tif (vlan_enabled)\n \t\t\t\tpkt->ol_flags = PKT_RX_IPV6_HDR | PKT_RX_VLAN_PKT;\n \t\t\telse\n \t\t\t\tpkt->ol_flags = PKT_RX_IPV6_HDR;\n+#endif\n \t\t}\n \n \t\tpkts_burst[nb_pkt] = pkt;\n", "prefixes": [ "dpdk-dev", "v9", "12/19" ] }{ "id": 6040, "url": "