Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/60388/?format=api
{ "id": 60388, "url": "http://patches.dpdk.org/api/patches/60388/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191002012335.85324-15-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191002012335.85324-15-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191002012335.85324-15-ajit.khaparde@broadcom.com", "date": "2019-10-02T01:23:34", "name": "[v3,14/15] net/bnxt: use BIT macro instead of bit fields", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "f82429b100dc46ab45867df0abaf439cb96aef25", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191002012335.85324-15-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 6660, "url": "http://patches.dpdk.org/api/series/6660/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6660", "date": "2019-10-02T01:23:24", "name": "bnxt patchset to support device error recovery", "version": 3, "mbox": "http://patches.dpdk.org/series/6660/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/60388/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/60388/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id BF7411BF27;\n\tWed, 2 Oct 2019 03:24:20 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (unknown [192.19.229.170])\n\tby dpdk.org (Postfix) with ESMTP id 4D8511BE86\n\tfor <dev@dpdk.org>; Wed, 2 Oct 2019 03:23:48 +0200 (CEST)", "from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net\n\t[10.75.242.48])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id E5F4D30CC58;\n\tTue, 1 Oct 2019 18:22:32 -0700 (PDT)", "from localhost.localdomain (unknown [10.230.30.225])\n\tby mail-irv-17.broadcom.com (Postfix) with ESMTP id C40F114008C;\n\tTue, 1 Oct 2019 18:23:42 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com E5F4D30CC58", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1569979352;\n\tbh=tVW5aBZvBrQD3qOTXMtDk621/Ko4SZfSCDlN3nax364=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=eHZaH0EiowWs/92dVZ5omF9qsN/zaTIbx1wuYHwfmeGXE/GyD6P6R3EM0Qx8iyYQB\n\tWTWX6azXZqLxVj620xUf5nVarKOfVd9SoHBG4Dv9ruitwL6IOEYfZc9Ofbsn/v70H3\n\toiSoI7mdY8I48GlmpRvUWx6vr26kmnJqfPRqv2/s=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, Kalesh AP <kalesh-anakkur.purayil@broadcom.com>, \n\tSomnath Kotur <somnath.kotur@broadcom.com>", "Date": "Tue, 1 Oct 2019 18:23:34 -0700", "Message-Id": "<20191002012335.85324-15-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.20.1 (Apple Git-117)", "In-Reply-To": "<20191002012335.85324-1-ajit.khaparde@broadcom.com>", "References": "<7c08999f-13f3-5fb6-39a2-557a0884bfde@intel.com>\n\t<20191002012335.85324-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 14/15] net/bnxt: use BIT macro instead of bit\n\tfields", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n\nuse BIT macro instead of bit fields.\n\nSigned-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt.h | 79 ++++++++++++++++++------------------\n drivers/net/bnxt/bnxt_util.h | 4 ++\n 2 files changed, 44 insertions(+), 39 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h\nindex f47874882b..310b730e68 100644\n--- a/drivers/net/bnxt/bnxt.h\n+++ b/drivers/net/bnxt/bnxt.h\n@@ -19,6 +19,7 @@\n #include <rte_time.h>\n \n #include \"bnxt_cpr.h\"\n+#include \"bnxt_util.h\"\n \n #define BNXT_MAX_MTU\t\t9574\n #define VLAN_TAG_SIZE\t\t4\n@@ -198,16 +199,16 @@ struct bnxt_ptp_cfg {\n \tstruct bnxt\t\t*bp;\n #define BNXT_MAX_TX_TS\t1\n \tuint16_t\t\t\trxctl;\n-#define BNXT_PTP_MSG_SYNC\t\t\t(1 << 0)\n-#define BNXT_PTP_MSG_DELAY_REQ\t\t\t(1 << 1)\n-#define BNXT_PTP_MSG_PDELAY_REQ\t\t\t(1 << 2)\n-#define BNXT_PTP_MSG_PDELAY_RESP\t\t(1 << 3)\n-#define BNXT_PTP_MSG_FOLLOW_UP\t\t\t(1 << 8)\n-#define BNXT_PTP_MSG_DELAY_RESP\t\t\t(1 << 9)\n-#define BNXT_PTP_MSG_PDELAY_RESP_FOLLOW_UP\t(1 << 10)\n-#define BNXT_PTP_MSG_ANNOUNCE\t\t\t(1 << 11)\n-#define BNXT_PTP_MSG_SIGNALING\t\t\t(1 << 12)\n-#define BNXT_PTP_MSG_MANAGEMENT\t\t\t(1 << 13)\n+#define BNXT_PTP_MSG_SYNC\t\t\tBIT(0)\n+#define BNXT_PTP_MSG_DELAY_REQ\t\t\tBIT(1)\n+#define BNXT_PTP_MSG_PDELAY_REQ\t\t\tBIT(2)\n+#define BNXT_PTP_MSG_PDELAY_RESP\t\tBIT(3)\n+#define BNXT_PTP_MSG_FOLLOW_UP\t\t\tBIT(8)\n+#define BNXT_PTP_MSG_DELAY_RESP\t\t\tBIT(9)\n+#define BNXT_PTP_MSG_PDELAY_RESP_FOLLOW_UP\tBIT(10)\n+#define BNXT_PTP_MSG_ANNOUNCE\t\t\tBIT(11)\n+#define BNXT_PTP_MSG_SIGNALING\t\t\tBIT(12)\n+#define BNXT_PTP_MSG_MANAGEMENT\t\t\tBIT(13)\n #define BNXT_PTP_MSG_EVENTS\t\t(BNXT_PTP_MSG_SYNC |\t\t\\\n \t\t\t\t\t BNXT_PTP_MSG_DELAY_REQ |\t\\\n \t\t\t\t\t BNXT_PTP_MSG_PDELAY_REQ |\t\\\n@@ -363,10 +364,10 @@ struct bnxt_error_recovery_info {\n \tuint32_t\treset_reg[BNXT_NUM_RESET_REG];\n \tuint32_t\treset_reg_val[BNXT_NUM_RESET_REG];\n \tuint8_t\t\tdelay_after_reset[BNXT_NUM_RESET_REG];\n-#define BNXT_FLAG_ERROR_RECOVERY_HOST\t(1 << 0)\n-#define BNXT_FLAG_ERROR_RECOVERY_CO_CPU\t(1 << 1)\n-#define BNXT_FLAG_MASTER_FUNC\t\t(1 << 2)\n-#define BNXT_FLAG_RECOVERY_ENABLED\t(1 << 3)\n+#define BNXT_FLAG_ERROR_RECOVERY_HOST\tBIT(0)\n+#define BNXT_FLAG_ERROR_RECOVERY_CO_CPU\tBIT(1)\n+#define BNXT_FLAG_MASTER_FUNC\t\tBIT(2)\n+#define BNXT_FLAG_RECOVERY_ENABLED\tBIT(3)\n \tuint32_t\tflags;\n \n \tuint32_t last_heart_beat;\n@@ -402,31 +403,31 @@ struct bnxt {\n \tvoid\t\t\t\t*doorbell_base;\n \n \tuint32_t\t\tflags;\n-#define BNXT_FLAG_REGISTERED\t(1 << 0)\n-#define BNXT_FLAG_VF\t\t(1 << 1)\n-#define BNXT_FLAG_PORT_STATS\t(1 << 2)\n-#define BNXT_FLAG_JUMBO\t\t(1 << 3)\n-#define BNXT_FLAG_SHORT_CMD\t(1 << 4)\n-#define BNXT_FLAG_UPDATE_HASH\t(1 << 5)\n-#define BNXT_FLAG_PTP_SUPPORTED\t(1 << 6)\n-#define BNXT_FLAG_MULTI_HOST (1 << 7)\n-#define BNXT_FLAG_EXT_RX_PORT_STATS\t(1 << 8)\n-#define BNXT_FLAG_EXT_TX_PORT_STATS\t(1 << 9)\n-#define BNXT_FLAG_KONG_MB_EN\t(1 << 10)\n-#define BNXT_FLAG_TRUSTED_VF_EN\t(1 << 11)\n-#define BNXT_FLAG_DFLT_VNIC_SET\t(1 << 12)\n-#define BNXT_FLAG_THOR_CHIP\t(1 << 13)\n-#define BNXT_FLAG_STINGRAY\t(1 << 14)\n-#define BNXT_FLAG_FW_RESET\t(1 << 15)\n-#define BNXT_FLAG_FATAL_ERROR\t(1 << 16)\n-#define BNXT_FLAG_FW_CAP_IF_CHANGE\t(1 << 17)\n-#define BNXT_FLAG_IF_CHANGE_HOT_FW_RESET_DONE\t(1 << 18)\n-#define BNXT_FLAG_FW_CAP_ERROR_RECOVERY\t\t(1 << 19)\n-#define BNXT_FLAG_FW_HEALTH_CHECK_SCHEDULED\t(1 << 20)\n-#define BNXT_FLAG_FW_CAP_ERR_RECOVER_RELOAD\t(1 << 21)\n-#define BNXT_FLAG_EXT_STATS_SUPPORTED\t(1 << 29)\n-#define BNXT_FLAG_NEW_RM\t(1 << 30)\n-#define BNXT_FLAG_INIT_DONE\t(1U << 31)\n+#define BNXT_FLAG_REGISTERED\t\tBIT(0)\n+#define BNXT_FLAG_VF\t\t\tBIT(1)\n+#define BNXT_FLAG_PORT_STATS\t\tBIT(2)\n+#define BNXT_FLAG_JUMBO\t\t\tBIT(3)\n+#define BNXT_FLAG_SHORT_CMD\t\tBIT(4)\n+#define BNXT_FLAG_UPDATE_HASH\t\tBIT(5)\n+#define BNXT_FLAG_PTP_SUPPORTED\t\tBIT(6)\n+#define BNXT_FLAG_MULTI_HOST \tBIT(7)\n+#define BNXT_FLAG_EXT_RX_PORT_STATS\tBIT(8)\n+#define BNXT_FLAG_EXT_TX_PORT_STATS\tBIT(9)\n+#define BNXT_FLAG_KONG_MB_EN\t\tBIT(10)\n+#define BNXT_FLAG_TRUSTED_VF_EN\t\tBIT(11)\n+#define BNXT_FLAG_DFLT_VNIC_SET\t\tBIT(12)\n+#define BNXT_FLAG_THOR_CHIP\t\tBIT(13)\n+#define BNXT_FLAG_STINGRAY\t\tBIT(14)\n+#define BNXT_FLAG_FW_RESET\t\tBIT(15)\n+#define BNXT_FLAG_FATAL_ERROR\t\tBIT(16)\n+#define BNXT_FLAG_FW_CAP_IF_CHANGE\t\tBIT(17)\n+#define BNXT_FLAG_IF_CHANGE_HOT_FW_RESET_DONE\tBIT(18)\n+#define BNXT_FLAG_FW_CAP_ERROR_RECOVERY\t\tBIT(19)\n+#define BNXT_FLAG_FW_HEALTH_CHECK_SCHEDULED\tBIT(20)\n+#define BNXT_FLAG_FW_CAP_ERR_RECOVER_RELOAD\tBIT(21)\n+#define BNXT_FLAG_EXT_STATS_SUPPORTED\t\tBIT(22)\n+#define BNXT_FLAG_NEW_RM\t\t\tBIT(23)\n+#define BNXT_FLAG_INIT_DONE\t\t\tBIT(24)\n #define BNXT_PF(bp)\t\t(!((bp)->flags & BNXT_FLAG_VF))\n #define BNXT_VF(bp)\t\t((bp)->flags & BNXT_FLAG_VF)\n #define BNXT_NPAR(bp)\t\t((bp)->port_partition_type)\ndiff --git a/drivers/net/bnxt/bnxt_util.h b/drivers/net/bnxt/bnxt_util.h\nindex 9f1868a78f..a15b3a1a95 100644\n--- a/drivers/net/bnxt/bnxt_util.h\n+++ b/drivers/net/bnxt/bnxt_util.h\n@@ -6,6 +6,10 @@\n #ifndef _BNXT_UTIL_H_\n #define _BNXT_UTIL_H_\n \n+#ifndef BIT\n+#define BIT(n)\t(1UL << (n))\n+#endif /* BIT */\n+\n int bnxt_check_zero_bytes(const uint8_t *bytes, int len);\n void bnxt_eth_hw_addr_random(uint8_t *mac_addr);\n \n", "prefixes": [ "v3", "14/15" ] }