Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/60382/?format=api
{ "id": 60382, "url": "http://patches.dpdk.org/api/patches/60382/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191002012335.85324-9-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191002012335.85324-9-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191002012335.85324-9-ajit.khaparde@broadcom.com", "date": "2019-10-02T01:23:28", "name": "[v3,08/15] net/bnxt: advertise error recovery capability and handle async event", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "51d938828776c021122dffae62110474fa671f1e", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191002012335.85324-9-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 6660, "url": "http://patches.dpdk.org/api/series/6660/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6660", "date": "2019-10-02T01:23:24", "name": "bnxt patchset to support device error recovery", "version": 3, "mbox": "http://patches.dpdk.org/series/6660/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/60382/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/60382/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4D1501BEEE;\n\tWed, 2 Oct 2019 03:24:04 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (unknown [192.19.229.170])\n\tby dpdk.org (Postfix) with ESMTP id F27B91B948\n\tfor <dev@dpdk.org>; Wed, 2 Oct 2019 03:23:47 +0200 (CEST)", "from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net\n\t[10.75.242.48])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 9E5CD30CC42;\n\tTue, 1 Oct 2019 18:22:31 -0700 (PDT)", "from localhost.localdomain (unknown [10.230.30.225])\n\tby mail-irv-17.broadcom.com (Postfix) with ESMTP id 2CB3914008B;\n\tTue, 1 Oct 2019 18:23:41 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 9E5CD30CC42", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1569979351;\n\tbh=Y58QE3IEWJ0ST0TUvm5vjZkcMHMT3bXKj5Ivd1g3o9A=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=B2T8jYse+RIok9HVMplWrjhy+u8cHfa3nbLoZY0vOxChkHadKIgwSn6EzC3hlTqXX\n\tfzzRaBGAtWPUaYu8UFnlxFZhNkn3xO9181bplKJW2Jmwc29Hg7BWak4un1KWwwl6wA\n\t1xjzDnbyNWpT9rdGQZLMUcyKde5KXdsQFnUY7Khw=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, Kalesh AP <kalesh-anakkur.purayil@broadcom.com>, \n\tSomnath Kotur <somnath.kotur@broadcom.com>", "Date": "Tue, 1 Oct 2019 18:23:28 -0700", "Message-Id": "<20191002012335.85324-9-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.20.1 (Apple Git-117)", "In-Reply-To": "<20191002012335.85324-1-ajit.khaparde@broadcom.com>", "References": "<7c08999f-13f3-5fb6-39a2-557a0884bfde@intel.com>\n\t<20191002012335.85324-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 08/15] net/bnxt: advertise error recovery\n\tcapability and handle async event", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n\n1. Advertise HWRM_FUNC_DRV_RGTR_INPUT_FLAGS_ERROR_RECOVERY_SUPPORT flag\n in the FUNC_DRV_RGTR command.\n2. request for the async event ASYNC_EVENT_CMPL_EVENT_ID_ERROR_RECOVERY\n in the FUNC_DRV_RGTR command.\n3. handle the async event EVENT_ID_ERROR_RECOVERY from FW.\n\nError recovery support will be used by firmware only if all the driver\ninstances support error recovery process.\n\nSigned-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt.h | 2 ++\n drivers/net/bnxt/bnxt_cpr.c | 45 ++++++++++++++++++++++++++++++++++++\n drivers/net/bnxt/bnxt_cpr.h | 12 ++++++++++\n drivers/net/bnxt/bnxt_hwrm.c | 5 ++++\n drivers/net/bnxt/bnxt_hwrm.h | 2 ++\n 5 files changed, 66 insertions(+)", "diff": "diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h\nindex ac2bf158dd..ea556d0792 100644\n--- a/drivers/net/bnxt/bnxt.h\n+++ b/drivers/net/bnxt/bnxt.h\n@@ -365,6 +365,8 @@ struct bnxt_error_recovery_info {\n \tuint8_t\t\tdelay_after_reset[BNXT_NUM_RESET_REG];\n #define BNXT_FLAG_ERROR_RECOVERY_HOST\t(1 << 0)\n #define BNXT_FLAG_ERROR_RECOVERY_CO_CPU\t(1 << 1)\n+#define BNXT_FLAG_MASTER_FUNC\t\t(1 << 2)\n+#define BNXT_FLAG_RECOVERY_ENABLED\t(1 << 3)\n \tuint32_t\tflags;\n };\n \ndiff --git a/drivers/net/bnxt/bnxt_cpr.c b/drivers/net/bnxt/bnxt_cpr.c\nindex 3afb9902b0..1b046bbfac 100644\n--- a/drivers/net/bnxt/bnxt_cpr.c\n+++ b/drivers/net/bnxt/bnxt_cpr.c\n@@ -21,6 +21,7 @@ void bnxt_handle_async_event(struct bnxt *bp,\n \tstruct hwrm_async_event_cmpl *async_cmp =\n \t\t\t\t(struct hwrm_async_event_cmpl *)cmp;\n \tuint16_t event_id = rte_le_to_cpu_16(async_cmp->event_id);\n+\tstruct bnxt_error_recovery_info *info;\n \tuint32_t event_data;\n \n \t/* TODO: HWRM async events are not defined yet */\n@@ -65,6 +66,31 @@ void bnxt_handle_async_event(struct bnxt *bp,\n \t\trte_eal_alarm_set(US_PER_MS, bnxt_dev_reset_and_resume,\n \t\t\t\t (void *)bp);\n \t\tbreak;\n+\tcase HWRM_ASYNC_EVENT_CMPL_EVENT_ID_ERROR_RECOVERY:\n+\t\tinfo = bp->recovery_info;\n+\n+\t\tif (!info)\n+\t\t\treturn;\n+\n+\t\tPMD_DRV_LOG(INFO, \"Error recovery async event received\\n\");\n+\n+\t\tevent_data = rte_le_to_cpu_32(async_cmp->event_data1) &\n+\t\t\t\tEVENT_DATA1_FLAGS_MASK;\n+\n+\t\tif (event_data & EVENT_DATA1_FLAGS_MASTER_FUNC)\n+\t\t\tinfo->flags |= BNXT_FLAG_MASTER_FUNC;\n+\t\telse\n+\t\t\tinfo->flags &= ~BNXT_FLAG_MASTER_FUNC;\n+\n+\t\tif (event_data & EVENT_DATA1_FLAGS_RECOVERY_ENABLED)\n+\t\t\tinfo->flags |= BNXT_FLAG_RECOVERY_ENABLED;\n+\t\telse\n+\t\t\tinfo->flags &= ~BNXT_FLAG_RECOVERY_ENABLED;\n+\n+\t\tPMD_DRV_LOG(INFO, \"recovery enabled(%d), master function(%d)\\n\",\n+\t\t\t bnxt_is_recovery_enabled(bp),\n+\t\t\t bnxt_is_master_func(bp));\n+\t\tbreak;\n \tdefault:\n \t\tPMD_DRV_LOG(INFO, \"handle_async_event id = 0x%x\\n\", event_id);\n \t\tbreak;\n@@ -189,3 +215,22 @@ int bnxt_event_hwrm_resp_handler(struct bnxt *bp, struct cmpl_base *cmp)\n \n \treturn evt;\n }\n+\n+bool bnxt_is_master_func(struct bnxt *bp)\n+{\n+\tif (bp->recovery_info->flags & BNXT_FLAG_MASTER_FUNC)\n+\t\treturn true;\n+\n+\treturn false;\n+}\n+\n+bool bnxt_is_recovery_enabled(struct bnxt *bp)\n+{\n+\tstruct bnxt_error_recovery_info *info;\n+\n+\tinfo = bp->recovery_info;\n+\tif (info && (info->flags & BNXT_FLAG_RECOVERY_ENABLED))\n+\t\treturn true;\n+\n+\treturn false;\n+}\ndiff --git a/drivers/net/bnxt/bnxt_cpr.h b/drivers/net/bnxt/bnxt_cpr.h\nindex b61bafa0e8..f118bda36e 100644\n--- a/drivers/net/bnxt/bnxt_cpr.h\n+++ b/drivers/net/bnxt/bnxt_cpr.h\n@@ -113,4 +113,16 @@ void bnxt_dev_reset_and_resume(void *arg);\n #define EVENT_DATA1_REASON_CODE_MASK \\\n \tHWRM_ASYNC_EVENT_CMPL_RESET_NOTIFY_EVENT_DATA1_REASON_CODE_MASK\n \n+#define EVENT_DATA1_FLAGS_MASK \\\n+\tHWRM_ASYNC_EVENT_CMPL_ERROR_RECOVERY_EVENT_DATA1_FLAGS_MASK\n+\n+#define EVENT_DATA1_FLAGS_MASTER_FUNC \\\n+\tHWRM_ASYNC_EVENT_CMPL_ERROR_RECOVERY_EVENT_DATA1_FLAGS_MASTER_FUNC\n+\n+#define EVENT_DATA1_FLAGS_RECOVERY_ENABLED \\\n+\tHWRM_ASYNC_EVENT_CMPL_ERROR_RECOVERY_EVENT_DATA1_FLAGS_RECOVERY_ENABLED\n+\n+bool bnxt_is_recovery_enabled(struct bnxt *bp);\n+bool bnxt_is_master_func(struct bnxt *bp);\n+\n #endif\ndiff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c\nindex 34672dfb00..c7d6f9fdc4 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.c\n+++ b/drivers/net/bnxt/bnxt_hwrm.c\n@@ -689,6 +689,8 @@ int bnxt_hwrm_func_driver_register(struct bnxt *bp)\n \t\treturn 0;\n \n \tflags = HWRM_FUNC_DRV_RGTR_INPUT_FLAGS_HOT_RESET_SUPPORT;\n+\tif (bp->flags & BNXT_FLAG_FW_CAP_ERROR_RECOVERY)\n+\t\tflags |= HWRM_FUNC_DRV_RGTR_INPUT_FLAGS_ERROR_RECOVERY_SUPPORT;\n \n \t/* PFs and trusted VFs should indicate the support of the\n \t * Master capability on non Stingray platform\n@@ -726,6 +728,9 @@ int bnxt_hwrm_func_driver_register(struct bnxt *bp)\n \t\t\t\t ASYNC_CMPL_EVENT_ID_PORT_CONN_NOT_ALLOWED |\n \t\t\t\t ASYNC_CMPL_EVENT_ID_LINK_SPEED_CFG_CHANGE |\n \t\t\t\t ASYNC_CMPL_EVENT_ID_RESET_NOTIFY);\n+\tif (bp->flags & BNXT_FLAG_FW_CAP_ERROR_RECOVERY)\n+\t\treq.async_event_fwd[0] |=\n+\t\t\trte_cpu_to_le_32(ASYNC_CMPL_EVENT_ID_ERROR_RECOVERY);\n \treq.async_event_fwd[1] |=\n \t\trte_cpu_to_le_32(ASYNC_CMPL_EVENT_ID_PF_DRVR_UNLOAD |\n \t\t\t\t ASYNC_CMPL_EVENT_ID_VF_CFG_CHANGE);\ndiff --git a/drivers/net/bnxt/bnxt_hwrm.h b/drivers/net/bnxt/bnxt_hwrm.h\nindex c332c129dd..44e3355075 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.h\n+++ b/drivers/net/bnxt/bnxt_hwrm.h\n@@ -23,6 +23,8 @@ struct bnxt_cp_ring_info;\n \t(1 << HWRM_ASYNC_EVENT_CMPL_EVENT_ID_LINK_SPEED_CFG_CHANGE)\n #define ASYNC_CMPL_EVENT_ID_RESET_NOTIFY \\\n \t(1 << HWRM_ASYNC_EVENT_CMPL_EVENT_ID_RESET_NOTIFY)\n+#define ASYNC_CMPL_EVENT_ID_ERROR_RECOVERY \\\n+\t(1 << HWRM_ASYNC_EVENT_CMPL_EVENT_ID_ERROR_RECOVERY)\n #define ASYNC_CMPL_EVENT_ID_PF_DRVR_UNLOAD\t\\\n \t(1 << (HWRM_ASYNC_EVENT_CMPL_EVENT_ID_PF_DRVR_UNLOAD - 32))\n #define ASYNC_CMPL_EVENT_ID_VF_CFG_CHANGE\t\\\n", "prefixes": [ "v3", "08/15" ] }