Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 60235,
    "url": "http://patches.dpdk.org/api/patches/60235/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190930152721.8029-4-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190930152721.8029-4-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190930152721.8029-4-stephen@networkplumber.org",
    "date": "2019-09-30T15:27:18",
    "name": "[v2,3/6] mbuf: deinline rte_pktmbuf_clone",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "f8376727e0659561341faabd952487294653a518",
    "submitter": {
        "id": 27,
        "url": "http://patches.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190930152721.8029-4-stephen@networkplumber.org/mbox/",
    "series": [
        {
            "id": 6624,
            "url": "http://patches.dpdk.org/api/series/6624/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6624",
            "date": "2019-09-30T15:27:15",
            "name": "mbuf copy related enhancements",
            "version": 2,
            "mbox": "http://patches.dpdk.org/series/6624/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/60235/comments/",
    "check": "warning",
    "checks": "http://patches.dpdk.org/api/patches/60235/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A599D1BED7;\n\tMon, 30 Sep 2019 17:27:39 +0200 (CEST)",
            "from mail-pl1-f194.google.com (mail-pl1-f194.google.com\n\t[209.85.214.194]) by dpdk.org (Postfix) with ESMTP id 69B571BEA6\n\tfor <dev@dpdk.org>; Mon, 30 Sep 2019 17:27:33 +0200 (CEST)",
            "by mail-pl1-f194.google.com with SMTP id d22so4057606pls.0\n\tfor <dev@dpdk.org>; Mon, 30 Sep 2019 08:27:33 -0700 (PDT)",
            "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tw14sm30521021pge.56.2019.09.30.08.27.30\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 30 Sep 2019 08:27:31 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=otLljKJLik2d6Cq1uFOqCw0v1a/DuGc5nPCEEs/IOzM=;\n\tb=MFA25/EMs8nx36Ph0c3yUeycgRFQMNpWJ0uTLRpWhnl5/9ZXtafOwlg8FCX0j+UUGD\n\tDkV5FhDH3RCJABbNUJKPiBDN0yZ0qA58fXz2zpTlDKfYGnzmA8tbk49vXf08or9riVdC\n\tX+bwFvbdyFUJXVUy9BwU4VMecOOLaOlYUcD4+fwy1z2JQ9JlX8OlChN+1mAY5/WxZS3E\n\tI9usDD4kSHpf1YnuKMf91mhtNghaps+BG55o7zza3TS3xgPBea/tbfz+aXnZp0rozWoM\n\tj99ebbZ80k5G9fU6RFT3GSeq/qRYhi0OjnqjDeS516o7paTSlk9yv6F6mWY11Kv8FgtX\n\tdU/w==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=otLljKJLik2d6Cq1uFOqCw0v1a/DuGc5nPCEEs/IOzM=;\n\tb=WOYHG5M4RxoAuf2TWKd3+yHdJj/8d+OBjVbA6KMJDp7DxFr/f9Lrzw3y/IOgsF6O4e\n\tJX5aygz+PI+Vpmh2tCiTOLDUd/4NVqoW5OD6Hy3sVMB4vuGRMLDvVa/u91CcPlkOy0pX\n\t0Bhj9+93cljQ7QnS6olI0lOyyTRL64+KxIGmkhdOhKsDIvomRZHbtf4JFr78nTiJWlT1\n\tH7daa9jIkUdLZQN0gl0GEoaNsiFZ62zXL0tX5f/S06UFtlus/X6beOUzXE2zotPVWoU5\n\tUxhuwheDe1OvJ/wqmL7TVykDUjuZzWc+odJB8zlyCDPEsb8BOsQIKjjhsF2y1u44PLWh\n\tj5NQ==",
        "X-Gm-Message-State": "APjAAAUp0sEJYe5t4/xDhwW7qSfomSBl7DsKIUxW9ZP4i1HnaFve1pcG\n\t2VEzm9qK6/Nh65V+TvEx5g8tGESuwCo=",
        "X-Google-Smtp-Source": "APXvYqwe4FF3C2P3IQNh5fDFHfIgGtpvinhmY95E8QeqRH0/SXzWnLCRTtNtHMgRtJmIXnenzqZ+jA==",
        "X-Received": "by 2002:a17:902:6b07:: with SMTP id\n\to7mr11858899plk.44.1569857252278; \n\tMon, 30 Sep 2019 08:27:32 -0700 (PDT)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "dev@dpdk.org",
        "Cc": "Stephen Hemminger <stephen@networkplumber.org>",
        "Date": "Mon, 30 Sep 2019 08:27:18 -0700",
        "Message-Id": "<20190930152721.8029-4-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.20.1",
        "In-Reply-To": "<20190930152721.8029-1-stephen@networkplumber.org>",
        "References": "<20190928003758.18489-1-stephen@networkplumber.org>\n\t<20190930152721.8029-1-stephen@networkplumber.org>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH v2 3/6] mbuf: deinline rte_pktmbuf_clone",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Cloning mbufs requires allocations and iteration\nand therefore should not be an inline.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/librte_mbuf/rte_mbuf.c           | 39 ++++++++++++++++++++++++++++\n lib/librte_mbuf/rte_mbuf.h           | 38 ++-------------------------\n lib/librte_mbuf/rte_mbuf_version.map |  1 +\n 3 files changed, 42 insertions(+), 36 deletions(-)",
    "diff": "diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c\nindex 922bce6f0f93..12d0258a120d 100644\n--- a/lib/librte_mbuf/rte_mbuf.c\n+++ b/lib/librte_mbuf/rte_mbuf.c\n@@ -245,6 +245,45 @@ int rte_mbuf_check(const struct rte_mbuf *m, int is_header,\n \treturn 0;\n }\n \n+/* Creates a shallow copy of mbuf */\n+struct rte_mbuf *\n+rte_pktmbuf_clone(struct rte_mbuf *md, struct rte_mempool *mp)\n+{\n+\tstruct rte_mbuf *mc, *mi, **prev;\n+\tuint32_t pktlen;\n+\tuint16_t nseg;\n+\n+\tmc = rte_pktmbuf_alloc(mp);\n+\tif (unlikely(mc == NULL))\n+\t\treturn NULL;\n+\n+\tmi = mc;\n+\tprev = &mi->next;\n+\tpktlen = md->pkt_len;\n+\tnseg = 0;\n+\n+\tdo {\n+\t\tnseg++;\n+\t\trte_pktmbuf_attach(mi, md);\n+\t\t*prev = mi;\n+\t\tprev = &mi->next;\n+\t} while ((md = md->next) != NULL &&\n+\t    (mi = rte_pktmbuf_alloc(mp)) != NULL);\n+\n+\t*prev = NULL;\n+\tmc->nb_segs = nseg;\n+\tmc->pkt_len = pktlen;\n+\n+\t/* Allocation of new indirect segment failed */\n+\tif (unlikely(mi == NULL)) {\n+\t\trte_pktmbuf_free(mc);\n+\t\treturn NULL;\n+\t}\n+\n+\t__rte_mbuf_sanity_check(mc, 1);\n+\treturn mc;\n+}\n+\n /* convert multi-segment mbuf to single mbuf */\n int\n rte_pktmbuf_linearize(struct rte_mbuf *mbuf)\ndiff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h\nindex d25356b58cba..a6e78e4ea7a6 100644\n--- a/lib/librte_mbuf/rte_mbuf.h\n+++ b/lib/librte_mbuf/rte_mbuf.h\n@@ -1924,42 +1924,8 @@ static inline void rte_pktmbuf_free(struct rte_mbuf *m)\n  *   - The pointer to the new \"clone\" mbuf on success.\n  *   - NULL if allocation fails.\n  */\n-static inline struct rte_mbuf *rte_pktmbuf_clone(struct rte_mbuf *md,\n-\t\tstruct rte_mempool *mp)\n-{\n-\tstruct rte_mbuf *mc, *mi, **prev;\n-\tuint32_t pktlen;\n-\tuint16_t nseg;\n-\n-\tif (unlikely ((mc = rte_pktmbuf_alloc(mp)) == NULL))\n-\t\treturn NULL;\n-\n-\tmi = mc;\n-\tprev = &mi->next;\n-\tpktlen = md->pkt_len;\n-\tnseg = 0;\n-\n-\tdo {\n-\t\tnseg++;\n-\t\trte_pktmbuf_attach(mi, md);\n-\t\t*prev = mi;\n-\t\tprev = &mi->next;\n-\t} while ((md = md->next) != NULL &&\n-\t    (mi = rte_pktmbuf_alloc(mp)) != NULL);\n-\n-\t*prev = NULL;\n-\tmc->nb_segs = nseg;\n-\tmc->pkt_len = pktlen;\n-\n-\t/* Allocation of new indirect segment failed */\n-\tif (unlikely (mi == NULL)) {\n-\t\trte_pktmbuf_free(mc);\n-\t\treturn NULL;\n-\t}\n-\n-\t__rte_mbuf_sanity_check(mc, 1);\n-\treturn mc;\n-}\n+struct rte_mbuf *\n+rte_pktmbuf_clone(struct rte_mbuf *md, struct rte_mempool *mp);\n \n /**\n  * Adds given value to the refcnt of all packet mbuf segments.\ndiff --git a/lib/librte_mbuf/rte_mbuf_version.map b/lib/librte_mbuf/rte_mbuf_version.map\nindex 528681ba263a..aeec3f90f3fe 100644\n--- a/lib/librte_mbuf/rte_mbuf_version.map\n+++ b/lib/librte_mbuf/rte_mbuf_version.map\n@@ -49,6 +49,7 @@ DPDK_18.08 {\n DPDK_19.11 {\n \tglobal:\n \n+\trte_pktmbuf_clone;\n \trte_pktmbuf_linearize;\n } DPDK_18.08;\n \n",
    "prefixes": [
        "v2",
        "3/6"
    ]
}