Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 60082,
    "url": "http://patches.dpdk.org/api/patches/60082/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190928003758.18489-4-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190928003758.18489-4-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190928003758.18489-4-stephen@networkplumber.org",
    "date": "2019-09-28T00:37:56",
    "name": "[3/5] mbuf: deinline rte_pktmbuf_clone",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "bfc9312754a984ee3c0fae63cc4dbecd08e0d415",
    "submitter": {
        "id": 27,
        "url": "http://patches.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190928003758.18489-4-stephen@networkplumber.org/mbox/",
    "series": [
        {
            "id": 6597,
            "url": "http://patches.dpdk.org/api/series/6597/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6597",
            "date": "2019-09-28T00:37:53",
            "name": "mbuf related patches",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/6597/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/60082/comments/",
    "check": "warning",
    "checks": "http://patches.dpdk.org/api/patches/60082/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7CF291BE92;\n\tSat, 28 Sep 2019 02:38:12 +0200 (CEST)",
            "from mail-pf1-f195.google.com (mail-pf1-f195.google.com\n\t[209.85.210.195]) by dpdk.org (Postfix) with ESMTP id 299961B948\n\tfor <dev@dpdk.org>; Sat, 28 Sep 2019 02:38:05 +0200 (CEST)",
            "by mail-pf1-f195.google.com with SMTP id y5so2440956pfo.4\n\tfor <dev@dpdk.org>; Fri, 27 Sep 2019 17:38:05 -0700 (PDT)",
            "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tt13sm3494942pfh.12.2019.09.27.17.38.03\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 27 Sep 2019 17:38:03 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=90mHwihb7xMUiaegFDWqrOBXKk/uRYtwHzVS8GpuEk8=;\n\tb=Ym4JrbANbpoSR17acvpPNZQYy83yAzDSJzUtNM+LSBo/Xf0zxeFI1UvEYL6zu0hN/o\n\tXYj6l13myqzbu0z+O5nBjYmsZtS+cUmAmOGAQhaeKxc0rnODpOz9RuzgoixosFPq9wkC\n\tTwwVS7g0sf3jVmdosy5Fdzj9o7HnCGKGFlbY/wmAB2Q8YrvwHOlDkZ4yLugLWKPm1vnM\n\tp0PovZxeau7UP2BclaL9clpswDnbWuw5MSNUTG1SdCqWSvthuqvJFmTCDjG3NcBjK18j\n\tkg2ZnHOFfdpbq5d6D/WdO98JA0wzJhPmuoSfUB7FVETewquT8CGJpqbn/BelOG0/oxCq\n\tIVPQ==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=90mHwihb7xMUiaegFDWqrOBXKk/uRYtwHzVS8GpuEk8=;\n\tb=U1/PUfGUIDMrBhrGnJPAb4FfR7SJ9a/0g3sIJFkMf9CU7zQXjYjY2ImJk9fFDIFun5\n\tv+w+PCVHVQj6e8ujDo/yiGA0ZlagaOVNVahu4xFeDfSOnfDv/xljKCWtulpuAMyEzhhN\n\tQr//6jYiu0MBm+lSUfWmWtToULtzpkAVRRyPKwwW1LFsSmmwjp5jU++F/ju8QGBfgJ+0\n\ti/U+KH6atPaIEKAebh0hbUpX83K/8PneLDriZHAT/zw7msTBmmrwv11BH97QiqAvIE/V\n\tDgKbzpW8VVuS3pdQocQHvDaDGrqz1SCYZKk7lLpg8zA8NoG5PLhevCW4Tksrekr7Tcc6\n\tofqg==",
        "X-Gm-Message-State": "APjAAAWPRwVjKMu649r9wh9/Pz9jOoraVSHnLUIk1sUVYXGH5wf4rJC8\n\tlDjQ7Yb76LzJ+3Sziq9ZX2UbKKS+WTs=",
        "X-Google-Smtp-Source": "APXvYqxH+wcVavVK5o1zp/NYIgvH2w5hRDmdhag+MypkJ6Ignzyn/JoaGMIXB28yJHIv6novN3WvDw==",
        "X-Received": "by 2002:a63:ab05:: with SMTP id\n\tp5mr12264336pgf.414.1569631084781; \n\tFri, 27 Sep 2019 17:38:04 -0700 (PDT)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "dev@dpdk.org",
        "Cc": "Stephen Hemminger <stephen@networkplumber.org>",
        "Date": "Fri, 27 Sep 2019 17:37:56 -0700",
        "Message-Id": "<20190928003758.18489-4-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.20.1",
        "In-Reply-To": "<20190928003758.18489-1-stephen@networkplumber.org>",
        "References": "<20190928003758.18489-1-stephen@networkplumber.org>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH 3/5] mbuf: deinline rte_pktmbuf_clone",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Cloning mbufs requires allocations and iteration\nand therefore should not be an inline.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/librte_mbuf/rte_mbuf.c           | 39 ++++++++++++++++++++++++++++\n lib/librte_mbuf/rte_mbuf.h           | 38 ++-------------------------\n lib/librte_mbuf/rte_mbuf_version.map |  1 +\n 3 files changed, 42 insertions(+), 36 deletions(-)",
    "diff": "diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c\nindex 922bce6f0f93..12d0258a120d 100644\n--- a/lib/librte_mbuf/rte_mbuf.c\n+++ b/lib/librte_mbuf/rte_mbuf.c\n@@ -245,6 +245,45 @@ int rte_mbuf_check(const struct rte_mbuf *m, int is_header,\n \treturn 0;\n }\n \n+/* Creates a shallow copy of mbuf */\n+struct rte_mbuf *\n+rte_pktmbuf_clone(struct rte_mbuf *md, struct rte_mempool *mp)\n+{\n+\tstruct rte_mbuf *mc, *mi, **prev;\n+\tuint32_t pktlen;\n+\tuint16_t nseg;\n+\n+\tmc = rte_pktmbuf_alloc(mp);\n+\tif (unlikely(mc == NULL))\n+\t\treturn NULL;\n+\n+\tmi = mc;\n+\tprev = &mi->next;\n+\tpktlen = md->pkt_len;\n+\tnseg = 0;\n+\n+\tdo {\n+\t\tnseg++;\n+\t\trte_pktmbuf_attach(mi, md);\n+\t\t*prev = mi;\n+\t\tprev = &mi->next;\n+\t} while ((md = md->next) != NULL &&\n+\t    (mi = rte_pktmbuf_alloc(mp)) != NULL);\n+\n+\t*prev = NULL;\n+\tmc->nb_segs = nseg;\n+\tmc->pkt_len = pktlen;\n+\n+\t/* Allocation of new indirect segment failed */\n+\tif (unlikely(mi == NULL)) {\n+\t\trte_pktmbuf_free(mc);\n+\t\treturn NULL;\n+\t}\n+\n+\t__rte_mbuf_sanity_check(mc, 1);\n+\treturn mc;\n+}\n+\n /* convert multi-segment mbuf to single mbuf */\n int\n rte_pktmbuf_linearize(struct rte_mbuf *mbuf)\ndiff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h\nindex d25356b58cba..a6e78e4ea7a6 100644\n--- a/lib/librte_mbuf/rte_mbuf.h\n+++ b/lib/librte_mbuf/rte_mbuf.h\n@@ -1924,42 +1924,8 @@ static inline void rte_pktmbuf_free(struct rte_mbuf *m)\n  *   - The pointer to the new \"clone\" mbuf on success.\n  *   - NULL if allocation fails.\n  */\n-static inline struct rte_mbuf *rte_pktmbuf_clone(struct rte_mbuf *md,\n-\t\tstruct rte_mempool *mp)\n-{\n-\tstruct rte_mbuf *mc, *mi, **prev;\n-\tuint32_t pktlen;\n-\tuint16_t nseg;\n-\n-\tif (unlikely ((mc = rte_pktmbuf_alloc(mp)) == NULL))\n-\t\treturn NULL;\n-\n-\tmi = mc;\n-\tprev = &mi->next;\n-\tpktlen = md->pkt_len;\n-\tnseg = 0;\n-\n-\tdo {\n-\t\tnseg++;\n-\t\trte_pktmbuf_attach(mi, md);\n-\t\t*prev = mi;\n-\t\tprev = &mi->next;\n-\t} while ((md = md->next) != NULL &&\n-\t    (mi = rte_pktmbuf_alloc(mp)) != NULL);\n-\n-\t*prev = NULL;\n-\tmc->nb_segs = nseg;\n-\tmc->pkt_len = pktlen;\n-\n-\t/* Allocation of new indirect segment failed */\n-\tif (unlikely (mi == NULL)) {\n-\t\trte_pktmbuf_free(mc);\n-\t\treturn NULL;\n-\t}\n-\n-\t__rte_mbuf_sanity_check(mc, 1);\n-\treturn mc;\n-}\n+struct rte_mbuf *\n+rte_pktmbuf_clone(struct rte_mbuf *md, struct rte_mempool *mp);\n \n /**\n  * Adds given value to the refcnt of all packet mbuf segments.\ndiff --git a/lib/librte_mbuf/rte_mbuf_version.map b/lib/librte_mbuf/rte_mbuf_version.map\nindex 7af410a4f687..9cc43e24bfa4 100644\n--- a/lib/librte_mbuf/rte_mbuf_version.map\n+++ b/lib/librte_mbuf/rte_mbuf_version.map\n@@ -49,6 +49,7 @@ DPDK_18.08 {\n DPDK_18.11 {\n \tglobal:\n \n+\trte_pktmbuf_clone;\n \trte_pktmbuf_linearize;\n } DPDK_18.08;\n \n",
    "prefixes": [
        "3/5"
    ]
}