Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/59822/?format=api
{ "id": 59822, "url": "http://patches.dpdk.org/api/patches/59822/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190926085232.47667-2-jasvinder.singh@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190926085232.47667-2-jasvinder.singh@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190926085232.47667-2-jasvinder.singh@intel.com", "date": "2019-09-26T08:52:18", "name": "[v3,01/15] sched: add pipe config params to subport struct", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a2ad7c690f06e4bb7428e6f9b0ff2a01d0e6ad01", "submitter": { "id": 285, "url": "http://patches.dpdk.org/api/people/285/?format=api", "name": "Jasvinder Singh", "email": "jasvinder.singh@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190926085232.47667-2-jasvinder.singh@intel.com/mbox/", "series": [ { "id": 6540, "url": "http://patches.dpdk.org/api/series/6540/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6540", "date": "2019-09-26T08:52:17", "name": "sched: subport level configuration of pipe nodes", "version": 3, "mbox": "http://patches.dpdk.org/series/6540/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/59822/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/59822/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B41091BF1D;\n\tThu, 26 Sep 2019 10:52:48 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id 5E1C31BED5\n\tfor <dev@dpdk.org>; Thu, 26 Sep 2019 10:52:43 +0200 (CEST)", "from fmsmga007.fm.intel.com ([10.253.24.52])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t26 Sep 2019 01:52:42 -0700", "from silpixa00381635.ir.intel.com (HELO\n\tsilpixa00381635.ger.corp.intel.com) ([10.237.223.4])\n\tby fmsmga007.fm.intel.com with ESMTP; 26 Sep 2019 01:52:41 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.64,551,1559545200\"; d=\"scan'208\";a=\"189945540\"", "From": "Jasvinder Singh <jasvinder.singh@intel.com>", "To": "dev@dpdk.org", "Cc": "cristian.dumitrescu@intel.com,\n\tLukasz Krakowiak <lukaszx.krakowiak@intel.com>", "Date": "Thu, 26 Sep 2019 09:52:18 +0100", "Message-Id": "<20190926085232.47667-2-jasvinder.singh@intel.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190926085232.47667-1-jasvinder.singh@intel.com>", "References": "<20190909100530.86020-1-jasvinder.singh@intel.com>\n\t<20190926085232.47667-1-jasvinder.singh@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 01/15] sched: add pipe config params to\n\tsubport struct", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add pipe configuration parameters to subport level structure to\nallow different subports of the same port to have different\nconfiguration in terms of number of pipes, pipe queue sizes, etc.\n\nSigned-off-by: Jasvinder Singh <jasvinder.singh@intel.com>\nSigned-off-by: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>\n---\n lib/librte_sched/Makefile | 2 +-\n lib/librte_sched/meson.build | 2 +-\n lib/librte_sched/rte_sched.h | 92 ++++++++++++++++++++++++------------\n 3 files changed, 65 insertions(+), 31 deletions(-)", "diff": "diff --git a/lib/librte_sched/Makefile b/lib/librte_sched/Makefile\nindex 3d7f410e1..6e4a72d89 100644\n--- a/lib/librte_sched/Makefile\n+++ b/lib/librte_sched/Makefile\n@@ -18,7 +18,7 @@ LDLIBS += -lrte_timer\n \n EXPORT_MAP := rte_sched_version.map\n \n-LIBABIVER := 3\n+LIBABIVER := 4\n \n #\n # all source are stored in SRCS-y\ndiff --git a/lib/librte_sched/meson.build b/lib/librte_sched/meson.build\nindex 59d43c6d8..9f40a2368 100644\n--- a/lib/librte_sched/meson.build\n+++ b/lib/librte_sched/meson.build\n@@ -1,7 +1,7 @@\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright(c) 2017 Intel Corporation\n \n-version = 3\n+version = 4\n sources = files('rte_sched.c', 'rte_red.c', 'rte_approx.c')\n headers = files('rte_sched.h', 'rte_sched_common.h',\n \t\t'rte_red.h', 'rte_approx.h')\ndiff --git a/lib/librte_sched/rte_sched.h b/lib/librte_sched/rte_sched.h\nindex eac6db274..fbb0e23fa 100644\n--- a/lib/librte_sched/rte_sched.h\n+++ b/lib/librte_sched/rte_sched.h\n@@ -111,7 +111,7 @@ extern \"C\" {\n #endif\n \n /*\n- * Subport configuration parameters. The period and credits_per_period\n+ * Pipe configuration parameters. The period and credits_per_period\n * parameters are measured in bytes, with one byte meaning the time\n * duration associated with the transmission of one byte on the\n * physical medium of the output port, with pipe or pipe traffic class\n@@ -119,7 +119,7 @@ extern \"C\" {\n * credits_per_period divided by period. One credit represents one\n * byte.\n */\n-struct rte_sched_subport_params {\n+struct rte_sched_pipe_params {\n \t/** Token bucket rate (measured in bytes per second) */\n \tuint32_t tb_rate;\n \n@@ -129,32 +129,18 @@ struct rte_sched_subport_params {\n \t/** Traffic class rates (measured in bytes per second) */\n \tuint32_t tc_rate[RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE];\n \n-\t/** Enforcement period for rates (measured in milliseconds) */\n+\t/** Enforcement period (measured in milliseconds) */\n \tuint32_t tc_period;\n-};\n-\n-/** Subport statistics */\n-struct rte_sched_subport_stats {\n-\t/** Number of packets successfully written */\n-\tuint32_t n_pkts_tc[RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE];\n-\n-\t/** Number of packets dropped */\n-\tuint32_t n_pkts_tc_dropped[RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE];\n \n-\t/** Number of bytes successfully written for each traffic class */\n-\tuint32_t n_bytes_tc[RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE];\n-\n-\t/** Number of bytes dropped for each traffic class */\n-\tuint32_t n_bytes_tc_dropped[RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE];\n+\t/** Best-effort traffic class oversubscription weight */\n+\tuint8_t tc_ov_weight;\n \n-#ifdef RTE_SCHED_RED\n-\t/** Number of packets dropped by red */\n-\tuint32_t n_pkts_red_dropped[RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE];\n-#endif\n+\t/** WRR weights of best-effort traffic class queues */\n+\tuint8_t wrr_weights[RTE_SCHED_BE_QUEUES_PER_PIPE];\n };\n \n /*\n- * Pipe configuration parameters. The period and credits_per_period\n+ * Subport configuration parameters. The period and credits_per_period\n * parameters are measured in bytes, with one byte meaning the time\n * duration associated with the transmission of one byte on the\n * physical medium of the output port, with pipe or pipe traffic class\n@@ -162,7 +148,7 @@ struct rte_sched_subport_stats {\n * credits_per_period divided by period. One credit represents one\n * byte.\n */\n-struct rte_sched_pipe_params {\n+struct rte_sched_subport_params {\n \t/** Token bucket rate (measured in bytes per second) */\n \tuint32_t tb_rate;\n \n@@ -172,14 +158,58 @@ struct rte_sched_pipe_params {\n \t/** Traffic class rates (measured in bytes per second) */\n \tuint32_t tc_rate[RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE];\n \n-\t/** Enforcement period (measured in milliseconds) */\n+\t/** Enforcement period for rates (measured in milliseconds) */\n \tuint32_t tc_period;\n \n-\t/** Best-effort traffic class oversubscription weight */\n-\tuint8_t tc_ov_weight;\n+\t/** Number of subport pipes.\n+\t * The subport can enable/allocate fewer pipes than the maximum\n+\t * number set through struct port_params::n_max_pipes_per_subport,\n+\t * as needed, to avoid memory allocation for the queues of the\n+\t * pipes that are not really needed.\n+\t */\n+\tuint32_t n_pipes_per_subport_enabled;\n \n-\t/** WRR weights of best-effort traffic class queues */\n-\tuint8_t wrr_weights[RTE_SCHED_BE_QUEUES_PER_PIPE];\n+\t/** Packet queue size for each traffic class.\n+\t * All the pipes within the same subport share the similar\n+\t * configuration for the queues.\n+\t */\n+\tuint16_t qsize[RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE];\n+\n+\t/** Pipe profile table.\n+\t * Every pipe is configured using one of the profiles from this table.\n+\t */\n+\tstruct rte_sched_pipe_params *pipe_profiles;\n+\n+\t/** Profiles in the pipe profile table */\n+\tuint32_t n_pipe_profiles;\n+\n+\t/** Max allowed profiles in the pipe profile table */\n+\tuint32_t n_max_pipe_profiles;\n+\n+#ifdef RTE_SCHED_RED\n+\t/** RED parameters */\n+\tstruct rte_red_params red_params[RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE][RTE_COLORS];\n+#endif\n+};\n+\n+/** Subport statistics */\n+struct rte_sched_subport_stats {\n+\t/** Number of packets successfully written */\n+\tuint32_t n_pkts_tc[RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE];\n+\n+\t/** Number of packets dropped */\n+\tuint32_t n_pkts_tc_dropped[RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE];\n+\n+\t/** Number of bytes successfully written for each traffic class */\n+\tuint32_t n_bytes_tc[RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE];\n+\n+\t/** Number of bytes dropped for each traffic class */\n+\tuint32_t n_bytes_tc_dropped[RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE];\n+\n+#ifdef RTE_SCHED_RED\n+\t/** Number of packets dropped by red */\n+\tuint32_t n_pkts_red_dropped[RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE];\n+#endif\n };\n \n /** Queue statistics */\n@@ -224,7 +254,11 @@ struct rte_sched_port_params {\n \t/** Number of subports */\n \tuint32_t n_subports_per_port;\n \n-\t/** Number of subport_pipes */\n+\t/** Maximum number of subport pipes.\n+\t * This parameter is used to reserve a fixed number of bits\n+\t * in struct rte_mbuf::sched.queue_id for the pipe_id for all\n+\t * the subports of the same port.\n+\t */\n \tuint32_t n_pipes_per_subport;\n \n \t/** Packet queue size for each traffic class.\n", "prefixes": [ "v3", "01/15" ] }