Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 598,
    "url": "http://patches.dpdk.org/api/patches/598/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1411735574-3703-1-git-send-email-thomas.monjalon@6wind.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1411735574-3703-1-git-send-email-thomas.monjalon@6wind.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1411735574-3703-1-git-send-email-thomas.monjalon@6wind.com",
    "date": "2014-09-26T12:46:14",
    "name": "[dpdk-dev] ixgbe: allow unsupported SFP",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "db8e609543ac5ba51e22a594ecb79b7a5ebf9f33",
    "submitter": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/people/1/?format=api",
        "name": "Thomas Monjalon",
        "email": "thomas.monjalon@6wind.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1411735574-3703-1-git-send-email-thomas.monjalon@6wind.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/598/comments/",
    "check": "pending",
    "checks": "http://patches.dpdk.org/api/patches/598/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 458FF7DEB;\n\tFri, 26 Sep 2014 14:40:10 +0200 (CEST)",
            "from mail-wg0-f52.google.com (mail-wg0-f52.google.com\n\t[74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 3C0BB678C\n\tfor <dev@dpdk.org>; Fri, 26 Sep 2014 14:40:08 +0200 (CEST)",
            "by mail-wg0-f52.google.com with SMTP id n12so7746440wgh.11\n\tfor <dev@dpdk.org>; Fri, 26 Sep 2014 05:46:30 -0700 (PDT)",
            "from localhost.localdomain (136-92-190-109.dsl.ovh.fr.\n\t[109.190.92.136]) by mx.google.com with ESMTPSA id\n\tic7sm2090078wid.11.2014.09.26.05.46.29 for <dev@dpdk.org>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tFri, 26 Sep 2014 05:46:29 -0700 (PDT)"
        ],
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:subject:date:message-id;\n\tbh=lJJwb1xnv7JpltXOoWkrDqYo1GWG6VmSWMWCuVyX2ec=;\n\tb=W5JhZV/JiSbry0GV105Z2CSUr9E/GFPL3ql3C4ytH5dUjcFc8rZ7+HF0+QjfEMEA8j\n\tc8+X1FFPcvP3u4un9W3ivPbIAFiicLRtYecOt9tLHfpV8HPGIHWQ4G0ZkPh3ulYDkaxh\n\teiGSFc5v75phO1br9FpaNU7Q+OekZNk0i1uBrFVblDNGS+7M3wjARQn3aE8olNNHSF0x\n\t93v0RhVsiu9+IoKbymT3uSoqU8t04ztxSHo8fu2e+ZXuEZzsPnKKhzGdIx5xSIq+q+E5\n\tH+dc/HZ2PD7hqKG2Hazcz4rJXQSnYAAy1yVq8/6Ry2PPCueyd8zlC9svbN5rdCKL6K4Q\n\tX1dA==",
        "X-Gm-Message-State": "ALoCoQlQGa5xA94+f8hdZlR6SfdIqU3Yjz9dYvUnd7Gyo8xozhdXDh3hdaOz77b6yGRQU+0WG//d",
        "X-Received": "by 10.194.24.169 with SMTP id v9mr3937654wjf.114.1411735590411; \n\tFri, 26 Sep 2014 05:46:30 -0700 (PDT)",
        "From": "Thomas Monjalon <thomas.monjalon@6wind.com>",
        "To": "dev@dpdk.org",
        "Date": "Fri, 26 Sep 2014 14:46:14 +0200",
        "Message-Id": "<1411735574-3703-1-git-send-email-thomas.monjalon@6wind.com>",
        "X-Mailer": "git-send-email 2.0.4",
        "Subject": "[dpdk-dev] [PATCH] ixgbe: allow unsupported SFP",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "No need to restrict usage of non Intel SFP.\nIf (hw->phy.type == ixgbe_phy_sfp_intel) is false,\na warning will be logged.\nIt was disabled for ixgbe and enabled but unused for i40e.\n\nSigned-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>\n---\n config/common_bsdapp                | 2 --\n config/common_linuxapp              | 2 --\n lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 2 --\n 3 files changed, 6 deletions(-)",
    "diff": "diff --git a/config/common_bsdapp b/config/common_bsdapp\nindex 645949f..eebd05b 100644\n--- a/config/common_bsdapp\n+++ b/config/common_bsdapp\n@@ -167,7 +167,6 @@ CONFIG_RTE_LIBRTE_IXGBE_DEBUG_TX_FREE=n\n CONFIG_RTE_LIBRTE_IXGBE_DEBUG_DRIVER=n\n CONFIG_RTE_LIBRTE_IXGBE_PF_DISABLE_STRIP_CRC=n\n CONFIG_RTE_LIBRTE_IXGBE_RX_ALLOW_BULK_ALLOC=y\n-CONFIG_RTE_LIBRTE_IXGBE_ALLOW_UNSUPPORTED_SFP=n\n CONFIG_RTE_IXGBE_INC_VECTOR=n\n CONFIG_RTE_IXGBE_RX_OLFLAGS_DISABLE=n\n \n@@ -182,7 +181,6 @@ CONFIG_RTE_LIBRTE_I40E_DEBUG_TX_FREE=n\n CONFIG_RTE_LIBRTE_I40E_DEBUG_DRIVER=n\n CONFIG_RTE_LIBRTE_I40E_PF_DISABLE_STRIP_CRC=y\n CONFIG_RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC=n\n-CONFIG_RTE_LIBRTE_I40E_ALLOW_UNSUPPORTED_SFP=y\n CONFIG_RTE_LIBRTE_I40E_16BYTE_RX_DESC=n\n CONFIG_RTE_LIBRTE_I40E_QUEUE_NUM_PER_VF=4\n # interval up to 8160 us, aligned to 2 (or default value)\ndiff --git a/config/common_linuxapp b/config/common_linuxapp\nindex 5bee910..4713eb4 100644\n--- a/config/common_linuxapp\n+++ b/config/common_linuxapp\n@@ -190,7 +190,6 @@ CONFIG_RTE_LIBRTE_IXGBE_DEBUG_TX_FREE=n\n CONFIG_RTE_LIBRTE_IXGBE_DEBUG_DRIVER=n\n CONFIG_RTE_LIBRTE_IXGBE_PF_DISABLE_STRIP_CRC=n\n CONFIG_RTE_LIBRTE_IXGBE_RX_ALLOW_BULK_ALLOC=y\n-CONFIG_RTE_LIBRTE_IXGBE_ALLOW_UNSUPPORTED_SFP=n\n CONFIG_RTE_IXGBE_INC_VECTOR=y\n CONFIG_RTE_IXGBE_RX_OLFLAGS_ENABLE=y\n \n@@ -205,7 +204,6 @@ CONFIG_RTE_LIBRTE_I40E_DEBUG_TX_FREE=n\n CONFIG_RTE_LIBRTE_I40E_DEBUG_DRIVER=n\n CONFIG_RTE_LIBRTE_I40E_PF_DISABLE_STRIP_CRC=n\n CONFIG_RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC=y\n-CONFIG_RTE_LIBRTE_I40E_ALLOW_UNSUPPORTED_SFP=n\n CONFIG_RTE_LIBRTE_I40E_16BYTE_RX_DESC=n\n CONFIG_RTE_LIBRTE_I40E_QUEUE_NUM_PER_VF=4\n # interval up to 8160 us, aligned to 2 (or default value)\ndiff --git a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c\nindex f4b590b..a147d46 100644\n--- a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c\n+++ b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c\n@@ -727,9 +727,7 @@ eth_ixgbe_dev_init(__attribute__((unused)) struct eth_driver *eth_drv,\n \thw->device_id = pci_dev->id.device_id;\n \thw->vendor_id = pci_dev->id.vendor_id;\n \thw->hw_addr = (void *)pci_dev->mem_resource[0].addr;\n-#ifdef RTE_LIBRTE_IXGBE_ALLOW_UNSUPPORTED_SFP\n \thw->allow_unsupported_sfp = 1;\n-#endif\n \n \t/* Initialize the shared code (base driver) */\n #ifdef RTE_NIC_BYPASS\n",
    "prefixes": [
        "dpdk-dev"
    ]
}