Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/59761/?format=api
{ "id": 59761, "url": "http://patches.dpdk.org/api/patches/59761/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190925145531.52705-2-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190925145531.52705-2-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190925145531.52705-2-bruce.richardson@intel.com", "date": "2019-09-25T14:55:29", "name": "[1/3] build: align variable names between drivers and libs", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "243e1d86b32b1cfef2a8194ad1fc67200b9d4853", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190925145531.52705-2-bruce.richardson@intel.com/mbox/", "series": [ { "id": 6530, "url": "http://patches.dpdk.org/api/series/6530/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6530", "date": "2019-09-25T14:55:28", "name": "RFC: Support disabling DPDK drivers in meson builds", "version": 1, "mbox": "http://patches.dpdk.org/series/6530/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/59761/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/59761/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A2F481BF4F;\n\tWed, 25 Sep 2019 16:55:41 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id 20B131BF33;\n\tWed, 25 Sep 2019 16:55:38 +0200 (CEST)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t25 Sep 2019 07:55:38 -0700", "from silpixa00399126.ir.intel.com (HELO\n\tsilpixa00399126.ger.corp.intel.com) ([10.237.223.2])\n\tby fmsmga006.fm.intel.com with ESMTP; 25 Sep 2019 07:55:37 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.64,548,1559545200\"; d=\"scan'208\";a=\"390235751\"", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "bluca@debian.org, thomas@monjalon.net, mb@smartsharesystems.com,\n\ttechboard@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>", "Date": "Wed, 25 Sep 2019 15:55:29 +0100", "Message-Id": "<20190925145531.52705-2-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190925145531.52705-1-bruce.richardson@intel.com>", "References": "<20190925145531.52705-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 1/3] build: align variable names between drivers\n\tand libs", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The variable names in the library and drivers meson.build files are slighty\ndifferent with \"static_deps\" in one and \"static_objs\" in the other. Rename\nto use \"static_deps\" in both for consistency.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n drivers/meson.build | 22 +++++++++++-----------\n 1 file changed, 11 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/meson.build b/drivers/meson.build\nindex 2ed2e9541..b54601697 100644\n--- a/drivers/meson.build\n+++ b/drivers/meson.build\n@@ -79,18 +79,18 @@ foreach class:dpdk_driver_classes\n \t\t\tendif\n \n \t\t\t# get dependency objs from strings\n-\t\t\tshared_objs = []\n-\t\t\tstatic_objs = []\n+\t\t\tshared_deps = []\n+\t\t\tstatic_deps = []\n \t\t\tforeach d:deps\n \t\t\t\tif not is_variable('shared_rte_' + d)\n \t\t\t\t\terror('Missing dependency ' + d +\n \t\t\t\t\t\t' for driver ' + lib_name)\n \t\t\t\tendif\n-\t\t\t\tshared_objs += [get_variable('shared_rte_' + d)]\n-\t\t\t\tstatic_objs += [get_variable('static_rte_' + d)]\n+\t\t\t\tshared_deps += [get_variable('shared_rte_' + d)]\n+\t\t\t\tstatic_deps += [get_variable('static_rte_' + d)]\n \t\t\tendforeach\n-\t\t\tshared_objs += ext_deps\n-\t\t\tstatic_objs += ext_deps\n+\t\t\tshared_deps += ext_deps\n+\t\t\tstatic_deps += ext_deps\n \t\t\tdpdk_extra_ldflags += pkgconfig_extra_libs\n \n \t\t\t# generate pmdinfo sources by building a temporary\n@@ -101,7 +101,7 @@ foreach class:dpdk_driver_classes\n \t\t\ttmp_lib = static_library('tmp_' + lib_name,\n \t\t\t\t\tsources,\n \t\t\t\t\tinclude_directories: includes,\n-\t\t\t\t\tdependencies: static_objs,\n+\t\t\t\t\tdependencies: static_deps,\n \t\t\t\t\tc_args: cflags)\n \t\t\tobjs += tmp_lib.extract_all_objects()\n \t\t\tsources = custom_target(out_filename,\n@@ -123,7 +123,7 @@ foreach class:dpdk_driver_classes\n \t\t\t\tsources,\n \t\t\t\tobjects: objs,\n \t\t\t\tinclude_directories: includes,\n-\t\t\t\tdependencies: static_objs,\n+\t\t\t\tdependencies: static_deps,\n \t\t\t\tc_args: cflags,\n \t\t\t\tinstall: true)\n \n@@ -135,7 +135,7 @@ foreach class:dpdk_driver_classes\n \t\t\t\tsources,\n \t\t\t\tobjects: objs,\n \t\t\t\tinclude_directories: includes,\n-\t\t\t\tdependencies: shared_objs,\n+\t\t\t\tdependencies: shared_deps,\n \t\t\t\tc_args: cflags,\n \t\t\t\tlink_args: '-Wl,--version-script=' + version_map,\n \t\t\t\tlink_depends: version_map,\n@@ -148,10 +148,10 @@ foreach class:dpdk_driver_classes\n \t\t\t# testpmd or other built-in apps can find it if necessary\n \t\t\tshared_dep = declare_dependency(link_with: shared_lib,\n \t\t\t\t\tinclude_directories: includes,\n-\t\t\t\t\tdependencies: shared_objs)\n+\t\t\t\t\tdependencies: shared_deps)\n \t\t\tstatic_dep = declare_dependency(link_with: static_lib,\n \t\t\t\t\tinclude_directories: includes,\n-\t\t\t\t\tdependencies: static_objs)\n+\t\t\t\t\tdependencies: static_deps)\n \n \t\t\tdpdk_drivers += static_lib\n \n", "prefixes": [ "1/3" ] }