Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/59482/?format=api
{ "id": 59482, "url": "http://patches.dpdk.org/api/patches/59482/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190920031333.16859-1-shougangx.wang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190920031333.16859-1-shougangx.wang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190920031333.16859-1-shougangx.wang@intel.com", "date": "2019-09-20T03:13:33", "name": "[v2] app/testpmd: fix Segment fault when start fwd", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "748381b2e8af5138270718da38f12eca8206a347", "submitter": { "id": 1418, "url": "http://patches.dpdk.org/api/people/1418/?format=api", "name": "Shougang Wang", "email": "shougangx.wang@intel.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190920031333.16859-1-shougangx.wang@intel.com/mbox/", "series": [ { "id": 6467, "url": "http://patches.dpdk.org/api/series/6467/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6467", "date": "2019-09-20T03:13:33", "name": "[v2] app/testpmd: fix Segment fault when start fwd", "version": 2, "mbox": "http://patches.dpdk.org/series/6467/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/59482/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/59482/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id EAA8A1F231;\n\tFri, 20 Sep 2019 05:58:45 +0200 (CEST)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby dpdk.org (Postfix) with ESMTP id 73FE91F1E6;\n\tFri, 20 Sep 2019 05:58:44 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t19 Sep 2019 20:58:42 -0700", "from intel.sh.intel.com ([10.239.255.149])\n\tby fmsmga002.fm.intel.com with ESMTP; 19 Sep 2019 20:58:40 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.64,527,1559545200\"; d=\"scan'208\";a=\"217528296\"", "From": "Wang ShougangX <shougangx.wang@intel.com>", "To": "dev@dpdk.org", "Cc": "wenzhuo.lu@intel.com, qiming.yang@intel.com, ferruh.yigit@intel.com,\n\tWang ShougangX <shougangx.wang@intel.com>, stable@dpdk.org", "Date": "Fri, 20 Sep 2019 03:13:33 +0000", "Message-Id": "<20190920031333.16859-1-shougangx.wang@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20190906012838.64088-1-shougangx.wang@intel.com>", "References": "<20190906012838.64088-1-shougangx.wang@intel.com>", "Subject": "[dpdk-dev] [PATCH v2] app/testpmd: fix Segment fault when start fwd", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch fixed the reset function to avoid crash when user don't\ncall port stop, port reset and port start functions as sequence.\n\nFixes: 97f1e19679 (\"app/testpmd: add port reset command\")\nCc: stable@dpdk.org\n\nSigned-off-by: Wang ShougangX <shougangx.wang@intel.com>\n---\n app/test-pmd/testpmd.c | 2 ++\n doc/guides/testpmd_app_ug/testpmd_funcs.rst | 9 +++++++++\n 2 files changed, 11 insertions(+)", "diff": "diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\nindex e8e2a39b6..9224aa1f7 100644\n--- a/app/test-pmd/testpmd.c\n+++ b/app/test-pmd/testpmd.c\n@@ -2344,6 +2344,8 @@ reset_port(portid_t pid)\n \tif (port_id_is_invalid(pid, ENABLED_WARN))\n \t\treturn;\n \n+\tstop_port(pid);\n+\n \tprintf(\"Resetting ports...\\n\");\n \n \tRTE_ETH_FOREACH_DEV(pi) {\ndiff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst\nindex 313e0707e..2c459810c 100644\n--- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst\n+++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst\n@@ -2041,6 +2041,15 @@ Close all ports or a specific port::\n \n testpmd> port close (port_id|all)\n \n+port reset\n+~~~~~~~~~~\n+\n+Reset all ports or a specific port::\n+\n+ testpmd> port reset (port_id|all)\n+\n+User should (re-)start the port after reset.\n+\n port config - queue ring size\n ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n \n", "prefixes": [ "v2" ] }