Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/59464/?format=api
{ "id": 59464, "url": "http://patches.dpdk.org/api/patches/59464/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190919131729.28681-3-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190919131729.28681-3-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190919131729.28681-3-stephen@networkplumber.org", "date": "2019-09-19T13:17:29", "name": "[v5,2/2] net/failsafe: implement xstats", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "d19e09b35e4c8d088cd67a89bcef9cb51b3694f5", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190919131729.28681-3-stephen@networkplumber.org/mbox/", "series": [ { "id": 6454, "url": "http://patches.dpdk.org/api/series/6454/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6454", "date": "2019-09-19T13:17:27", "name": "failsafe: add xstats", "version": 5, "mbox": "http://patches.dpdk.org/series/6454/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/59464/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/59464/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E067D1F015;\n\tThu, 19 Sep 2019 15:17:38 +0200 (CEST)", "from mail-wm1-f67.google.com (mail-wm1-f67.google.com\n\t[209.85.128.67]) by dpdk.org (Postfix) with ESMTP id E182F1F00F\n\tfor <dev@dpdk.org>; Thu, 19 Sep 2019 15:17:35 +0200 (CEST)", "by mail-wm1-f67.google.com with SMTP id x2so4500863wmj.2\n\tfor <dev@dpdk.org>; Thu, 19 Sep 2019 06:17:35 -0700 (PDT)", "from localhost.localdomain\n\t(lmontsouris-657-1-167-187.w82-127.abo.wanadoo.fr. [82.127.205.187])\n\tby smtp.gmail.com with ESMTPSA id\n\tb194sm9684643wmg.46.2019.09.19.06.17.33\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 19 Sep 2019 06:17:33 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=5e+KNvphZQf/O34q0pjNdu4cp7DnIhHMPoCcSIn/f18=;\n\tb=V8h8TYzD3uRbLupxfrMcv+oeuIap/dXU28pR5QzLpkyqoMf9lieNoRsEK3+BYGuIHb\n\tEPQTBtzI8xpdIo2qOf2uCuAXUU9FduUYmRvIN2f6eoIalIDvL2Cnmb5QaNCmy3Ghw9ym\n\tLf3LWSjSesjENcr/VcepJqdGQ1MDqg2RuDLjvu7j7lOkCUYFqvL3xqyID9Cl6LFMrry2\n\tIBFO+zrn4qovK7RKziV+YtWVdpnh4RWqL3qov0ji7E7s/YQ1k7lN3B33MFMfOhvuIxQo\n\tLTcGplU4k7GVkbuZSJu5Yq4B1tPvW/tp3bRsNMkzYGpYWNXArMRZKdDS9XqHjgHSVIIc\n\t7ojA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=5e+KNvphZQf/O34q0pjNdu4cp7DnIhHMPoCcSIn/f18=;\n\tb=qVrrR5ff/2a4InQ4AceJTRxgF4e+l+XS/4SlK5dC7GgE9hpNBY1eDhs4wVXukZo+yF\n\t3DauqRjTVypDCWoLlOAniXfOFQvbXF1ZIcvmqBXidUScwZKcTn4Evyk1fqy1ElM/tvdN\n\tsXBM7/2LWyHiw2Ab/iljXB5RfQwKqkNuaMUEHkg+mwreb9UA/dyf0il+tcK1/Bi9Yndd\n\tPEJTBE+PtOsadcY5p8CFnuZZktkQKydbYzxMJHpi9gVKKgLY53sJDkR/mRDD54z+MiLz\n\tJxXZYVune/iRXf2vNibrg3fhAwAJ8vsK9JbIqfX5dR8h9b9GLOO1PPBgLynJ0ie9N+PG\n\tBzhA==", "X-Gm-Message-State": "APjAAAULtHp5zB78W4uz0QuH07uRhqrd8B6qDBtW1fy0hKLdKu1vSYxi\n\tN2jNUpaKay0xaRTm6GArLRvFBWSvtS8wLQ==", "X-Google-Smtp-Source": "APXvYqysNgjKk4csEJ4pqGXl4hdC7VDFUiVYG0QywCr503hQ+JYb/pzqF1bHgnB/hGT9uSHj9GuV0w==", "X-Received": "by 2002:a1c:1d8d:: with SMTP id d135mr2967445wmd.7.1568899055179;\n\tThu, 19 Sep 2019 06:17:35 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Thu, 19 Sep 2019 15:17:29 +0200", "Message-Id": "<20190919131729.28681-3-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20190919131729.28681-1-stephen@networkplumber.org>", "References": "<20190811160607.16441-1-stephen@networkplumber.org>\n\t<20190919131729.28681-1-stephen@networkplumber.org>", "Subject": "[dpdk-dev] [PATCH v5 2/2] net/failsafe: implement xstats", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add support for extended statistics in failsafe driver.\nReports basic statistics for the failsafe driver, and detailed\nstatistics for each sub device.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nAcked-by: Gaetan Rivet <gaetan.rivet@6wind.com>\n---\n drivers/net/failsafe/failsafe_ops.c | 135 ++++++++++++++++++++++++++++\n 1 file changed, 135 insertions(+)", "diff": "diff --git a/drivers/net/failsafe/failsafe_ops.c b/drivers/net/failsafe/failsafe_ops.c\nindex 96e05d4dc4b1..711fdf302f4f 100644\n--- a/drivers/net/failsafe/failsafe_ops.c\n+++ b/drivers/net/failsafe/failsafe_ops.c\n@@ -789,6 +789,138 @@ fs_stats_reset(struct rte_eth_dev *dev)\n \tfs_unlock(dev, 0);\n }\n \n+/*\n+ * Count how many xstats in total\n+ * Include basic stats for failsafe device\n+ * plus xstats for each sub-device present.\n+ */\n+static int\n+fs_xstats_count(struct rte_eth_dev *dev)\n+{\n+\tstruct sub_device *sdev;\n+\tuint8_t i;\n+\tint count;\n+\n+\tcount = rte_eth_basic_stats_count(dev);\n+\n+\tfs_lock(dev, 0);\n+\tFOREACH_SUBDEV(sdev, i, dev) {\n+\t\tcount += rte_eth_xstats_get_names(PORT_ID(sdev), NULL, 0);\n+\t}\n+\tfs_unlock(dev, 0);\n+\n+\treturn count;\n+}\n+\n+static int\n+fs_xstats_get_names(struct rte_eth_dev *dev,\n+\t\t struct rte_eth_xstat_name *xstats_names,\n+\t\t unsigned int limit)\n+{\n+\tstruct sub_device *sdev;\n+\tunsigned int count;\n+\tchar tmp[RTE_ETH_XSTATS_NAME_SIZE];\n+\tuint8_t i;\n+\tint r;\n+\n+\t/* Caller only cares about count */\n+\tif (!xstats_names)\n+\t\treturn fs_xstats_count(dev);\n+\n+\tr = rte_eth_basic_stats_get_names(dev, xstats_names);\n+\tif (r < 0)\n+\t\treturn r;\n+\n+\tcount = r;\n+\n+\tfs_lock(dev, 0);\n+\tFOREACH_SUBDEV(sdev, i, dev) {\n+\t\tstruct rte_eth_xstat_name *sub_names = xstats_names + count;\n+\n+\t\tif (count >= limit)\n+\t\t\tbreak;\n+\n+\t\tr = rte_eth_xstats_get_names(PORT_ID(sdev), sub_names,\n+\t\t\t\t\t limit - count);\n+\t\tif (r < 0) {\n+\t\t\tfs_unlock(dev, 0);\n+\t\t\treturn r;\n+\t\t}\n+\n+\t\t/* add sub_ prefix to names */\n+\t\tfor (i = 0; i < r; i++) {\n+\t\t\tsnprintf(tmp, sizeof(tmp), \"sub%u_%s\",\n+\t\t\t\t i, sub_names[i].name);\n+\t\t\tmemcpy(sub_names[i].name, tmp,\n+\t\t\t RTE_ETH_XSTATS_NAME_SIZE);\n+\t\t}\n+\n+\t\tcount += r;\n+\t}\n+\tfs_unlock(dev, 0);\n+\n+\treturn count;\n+}\n+\n+static int\n+fs_xstats_get(struct rte_eth_dev *dev,\n+\t struct rte_eth_xstat *xstats,\n+\t unsigned int n)\n+{\n+\tunsigned int nstats, j, count, scount;\n+\tstruct sub_device *sdev;\n+\tuint8_t i;\n+\tint ret;\n+\n+\tnstats = fs_xstats_count(dev);\n+\tif (n < nstats || xstats == NULL)\n+\t\treturn nstats;\n+\n+\tret = rte_eth_basic_stats_get(dev->data->port_id, xstats);\n+\tif (ret < 0)\n+\t\treturn ret;\n+\n+\tcount = ret;\n+\tfor (j = 0; j < count; j++)\n+\t\txstats[j].id = j;\n+\n+\tfs_lock(dev, 0);\n+\tFOREACH_SUBDEV(sdev, i, dev) {\n+\t\tret = rte_eth_xstats_get(PORT_ID(sdev),\n+\t\t\t\t\t xstats + count,\n+\t\t\t\t\t n > count ? n - count : 0);\n+\t\tif (ret < 0) {\n+\t\t\tfs_unlock(dev, 0);\n+\t\t\treturn ret;\n+\t\t}\n+\t\tscount = ret;\n+\n+\t\t/* add offset to id's from sub-device */\n+\t\tfor (j = 0; j < scount; j++)\n+\t\t\txstats[count + j].id += count;\n+\n+\t\tcount += scount;\n+\t}\n+\tfs_unlock(dev, 0);\n+\n+\treturn count;\n+}\n+\n+static void\n+fs_xstats_reset(struct rte_eth_dev *dev)\n+{\n+\tstruct sub_device *sdev;\n+\tuint8_t i;\n+\n+\trte_eth_stats_reset(dev->data->port_id);\n+\n+\tfs_lock(dev, 0);\n+\tFOREACH_SUBDEV(sdev, i, dev) {\n+\t\trte_eth_xstats_reset(PORT_ID(sdev));\n+\t}\n+\tfs_unlock(dev, 0);\n+}\n+\n static void\n fs_dev_merge_desc_lim(struct rte_eth_desc_lim *to,\n \t\t const struct rte_eth_desc_lim *from)\n@@ -1233,6 +1365,9 @@ const struct eth_dev_ops failsafe_ops = {\n \t.link_update = fs_link_update,\n \t.stats_get = fs_stats_get,\n \t.stats_reset = fs_stats_reset,\n+\t.xstats_get = fs_xstats_get,\n+\t.xstats_get_names = fs_xstats_get_names,\n+\t.xstats_reset = fs_xstats_reset,\n \t.dev_infos_get = fs_dev_infos_get,\n \t.dev_supported_ptypes_get = fs_dev_supported_ptypes_get,\n \t.mtu_set = fs_mtu_set,\n", "prefixes": [ "v5", "2/2" ] }