Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/59255/?format=api
{ "id": 59255, "url": "http://patches.dpdk.org/api/patches/59255/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1568461055-16472-10-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1568461055-16472-10-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1568461055-16472-10-git-send-email-arybchenko@solarflare.com", "date": "2019-09-14T11:37:29", "name": "[v3,09/13] app/pdump: check code of promiscuous mode switch", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "da0c63bbccd04474d1920aed25d95995984599a4", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1568461055-16472-10-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 6407, "url": "http://patches.dpdk.org/api/series/6407/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6407", "date": "2019-09-14T11:37:20", "name": "ethdev: change promiscuous mode functions to return status", "version": 3, "mbox": "http://patches.dpdk.org/series/6407/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/59255/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/59255/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 41FE91EB42;\n\tSat, 14 Sep 2019 13:38:14 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 056881EAC5\n\tfor <dev@dpdk.org>; Sat, 14 Sep 2019 13:37:56 +0200 (CEST)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n\t2D632400056; Sat, 14 Sep 2019 11:37:55 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1395.4; Sat, 14 Sep 2019 04:37:48 -0700", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1395.4 via Frontend Transport; Sat, 14 Sep 2019 04:37:48 -0700", "from ukv-loginhost.uk.solarflarecom.com\n\t(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tx8EBblkp015447; Sat, 14 Sep 2019 12:37:47 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n\tby ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id\n\tB77871613D1; Sat, 14 Sep 2019 12:37:47 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "Reshma Pattan <reshma.pattan@intel.com>", "CC": "<dev@dpdk.org>, Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>", "Date": "Sat, 14 Sep 2019 12:37:29 +0100", "Message-ID": "<1568461055-16472-10-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1568461055-16472-1-git-send-email-arybchenko@solarflare.com>", "References": "<1567699852-31693-1-git-send-email-arybchenko@solarflare.com>\n\t<1568461055-16472-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.5.1010-24910.005", "X-TM-AS-Result": "No-0.745200-4.000000-10", "X-TMASE-MatchedRID": "bPLNq/JhYEHbS0m47m6fSn84FZpy/6JVAPiR4btCEeY7FE26mju9OzgK\n\t6rBjXxyiWiVYX64wRWibHAuQ1dUnuWJZXQNDzktS6OX7GFz9H1Aw6FEHkL/wj5soi2XrUn/Jn6K\n\tdMrRsL14qtq5d3cxkNcaOXUv6JuVjRo0A/iyQsO/HkuA2ciZSY2g1E88CrX1OOZ3Cwl+2FWmny7\n\t+o2Q8r6zF+JPVEeLSJ+Lr4qlUzpz3lbdfeImC8/VLp4hUUe2ehOKBkFAm8GOUPoO5ncI6OuehbQ\n\t2QpmASdWPKWiAlNtI5DDKa3G4nrLQ==", "X-TM-AS-User-Approved-Sender": "No", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10-0.745200-4.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.5.1010-24910.005", "X-MDID": "1568461075-56_8H8kAfu7n", "Subject": "[dpdk-dev] [PATCH v3 09/13] app/pdump: check code of promiscuous\n\tmode switch", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>\n\nrte_eth_promiscuous_enable()/rte_eth_promiscuous_disable() return\nvalue was changed from void to int, so this patch modify usage\nof these functions across app/pdump\naccording to new return type.\n\nSigned-off-by: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n app/pdump/main.c | 8 +++++++-\n 1 file changed, 7 insertions(+), 1 deletion(-)", "diff": "diff --git a/app/pdump/main.c b/app/pdump/main.c\nindex c1b901279..9d6be8ed1 100644\n--- a/app/pdump/main.c\n+++ b/app/pdump/main.c\n@@ -614,7 +614,13 @@ configure_vdev(uint16_t port_id)\n \t\t\taddr.addr_bytes[2], addr.addr_bytes[3],\n \t\t\taddr.addr_bytes[4], addr.addr_bytes[5]);\n \n-\trte_eth_promiscuous_enable(port_id);\n+\tret = rte_eth_promiscuous_enable(port_id);\n+\tif (ret != 0) {\n+\t\trte_exit(EXIT_FAILURE,\n+\t\t\t \"promiscuous mode enable failed: %s\\n\",\n+\t\t\t rte_strerror(-ret));\n+\t\treturn ret;\n+\t}\n \n \treturn 0;\n }\n", "prefixes": [ "v3", "09/13" ] }