Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/59073/?format=api
http://patches.dpdk.org/api/patches/59073/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1568103959-25572-17-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1568103959-25572-17-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1568103959-25572-17-git-send-email-arybchenko@solarflare.com", "date": "2019-09-10T08:25:56", "name": "[16/18] examples/distributor: check status of getting link info", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "35e0af1f7d7055df4f89c8257dd4ef0f8210e470", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1568103959-25572-17-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 6350, "url": "http://patches.dpdk.org/api/series/6350/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6350", "date": "2019-09-10T08:25:41", "name": "ethdev: change link status get functions return value to int", "version": 1, "mbox": "http://patches.dpdk.org/series/6350/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/59073/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/59073/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 51A331EE15;\n\tTue, 10 Sep 2019 10:26:55 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 8EF541ECD5\n\tfor <dev@dpdk.org>; Tue, 10 Sep 2019 10:26:23 +0200 (CEST)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us2.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n\t492291C005F; Tue, 10 Sep 2019 08:26:22 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1395.4; Tue, 10 Sep 2019 01:26:19 -0700", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1395.4 via Frontend Transport; Tue, 10 Sep 2019 01:26:19 -0700", "from ukv-loginhost.uk.solarflarecom.com\n\t(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tx8A8QIZx002339; Tue, 10 Sep 2019 09:26:18 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n\tby ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id\n\t1CF431613D1; Tue, 10 Sep 2019 09:26:18 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "David Hunt <david.hunt@intel.com>", "CC": "<dev@dpdk.org>, Igor Romanov <igor.romanov@oktetlabs.ru>", "Date": "Tue, 10 Sep 2019 09:25:56 +0100", "Message-ID": "<1568103959-25572-17-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1568103959-25572-1-git-send-email-arybchenko@solarflare.com>", "References": "<1568103959-25572-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.5.1010-24898.005", "X-TM-AS-Result": "No-1.138400-4.000000-10", "X-TMASE-MatchedRID": "lyqyZjZpZifDOgXZFRFV83CO70QAsBdCWw/S0HB7eoPhWjjGhpcHL0Ac\n\t6DyoS2rIZNUDHbPZ5K3jZDvcQ0T2FR8TzIzimOwPC24oEZ6SpSmb4wHqRpnaDg/qQbWYrUe+/IJ\n\tSWJW3WWr4rmPDDfu1DKLFX3skqzIGh6b54TmTRhk9gdVQQEC1Kcny9hUis3fSX8JKL/6hadMbkD\n\tc8OcWTVOQDw6tgd3AMZ9iVj/KhX/RSnoQc5vb5zuQdkM7ndBLCN+XOQZygrvY=", "X-TM-AS-User-Approved-Sender": "No", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--1.138400-4.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.5.1010-24898.005", "X-MDID": "1568103982-U3_ugnXw8Crv", "Subject": "[dpdk-dev] [PATCH 16/18] examples/distributor: check status of\n\tgetting link info", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Igor Romanov <igor.romanov@oktetlabs.ru>\n\nThe return value of rte_eth_link_get() and rte_eth_link_get_nowait()\nwas changed from void to int. Update the usage of the functions\naccording to the new return type.\n\nSigned-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n examples/distributor/main.c | 14 ++++++++++----\n 1 file changed, 10 insertions(+), 4 deletions(-)", "diff": "diff --git a/examples/distributor/main.c b/examples/distributor/main.c\nindex 125ee877f..49b4e611f 100644\n--- a/examples/distributor/main.c\n+++ b/examples/distributor/main.c\n@@ -173,12 +173,18 @@ port_init(uint16_t port, struct rte_mempool *mbuf_pool)\n \t\treturn retval;\n \n \tstruct rte_eth_link link;\n-\trte_eth_link_get_nowait(port, &link);\n-\twhile (!link.link_status) {\n+\tdo {\n+\t\tretval = rte_eth_link_get_nowait(port, &link);\n+\t\tif (retval < 0) {\n+\t\t\tprintf(\"Failed link get (port %u): %s\\n\",\n+\t\t\t\tport, rte_strerror(-retval));\n+\t\t\treturn retval;\n+\t\t} else if (link.link_status)\n+\t\t\tbreak;\n+\n \t\tprintf(\"Waiting for Link up on port %\"PRIu16\"\\n\", port);\n \t\tsleep(1);\n-\t\trte_eth_link_get_nowait(port, &link);\n-\t}\n+\t} while (!link.link_status);\n \n \tif (!link.link_status) {\n \t\tprintf(\"Link down on port %\"PRIu16\"\\n\", port);\n", "prefixes": [ "16/18" ] }{ "id": 59073, "url": "