Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/59065/?format=api
{ "id": 59065, "url": "http://patches.dpdk.org/api/patches/59065/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1568103959-25572-3-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1568103959-25572-3-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1568103959-25572-3-git-send-email-arybchenko@solarflare.com", "date": "2019-09-10T08:25:42", "name": "[02/18] ethdev: change link status get functions return value to int", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d3b9660c3267cbd3384396b0dbdf99f46048e992", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1568103959-25572-3-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 6350, "url": "http://patches.dpdk.org/api/series/6350/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6350", "date": "2019-09-10T08:25:41", "name": "ethdev: change link status get functions return value to int", "version": 1, "mbox": "http://patches.dpdk.org/series/6350/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/59065/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/59065/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D59D41EDCF;\n\tTue, 10 Sep 2019 10:26:39 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[148.163.129.52]) by dpdk.org (Postfix) with ESMTP id BD7A91ECC1\n\tfor <dev@dpdk.org>; Tue, 10 Sep 2019 10:26:21 +0200 (CEST)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us2.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n\tA440C1C006E; Tue, 10 Sep 2019 08:26:20 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1395.4; Tue, 10 Sep 2019 01:26:17 -0700", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1395.4 via Frontend Transport; Tue, 10 Sep 2019 01:26:17 -0700", "from ukv-loginhost.uk.solarflarecom.com\n\t(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tx8A8QENp002212; Tue, 10 Sep 2019 09:26:14 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n\tby ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id\n\t96AE41613D1; Tue, 10 Sep 2019 09:26:14 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "Neil Horman <nhorman@tuxdriver.com>, John McNamara\n\t<john.mcnamara@intel.com>, Marko Kovacevic <marko.kovacevic@intel.com>,\n\t\"Ori Kam\" <orika@mellanox.com>,\n\tBruce Richardson <bruce.richardson@intel.com>, \n\tPablo de Lara <pablo.de.lara.guarch@intel.com>, Radu Nicolau\n\t<radu.nicolau@intel.com>, Akhil Goyal <akhil.goyal@nxp.com>,\n\tTomasz Kantecki\n\t<tomasz.kantecki@intel.com>, Chas Williams <chas3@att.com>,\n\tThomas Monjalon\n\t<thomas@monjalon.net>, Ferruh Yigit <ferruh.yigit@intel.com>", "CC": "<dev@dpdk.org>, Igor Romanov <igor.romanov@oktetlabs.ru>", "Date": "Tue, 10 Sep 2019 09:25:42 +0100", "Message-ID": "<1568103959-25572-3-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1568103959-25572-1-git-send-email-arybchenko@solarflare.com>", "References": "<1568103959-25572-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.5.1010-24898.005", "X-TM-AS-Result": "No-1.793500-4.000000-10", "X-TMASE-MatchedRID": "VK5cIMsVziYwpyA3tQmxTTKVTrGMDe/D0mSc1YzbC53iYlKox3ryNARj\n\tZ4/TzBlyZcz/Uu/FtYO17bjsdF3gfJrjPXzSqsiQz5CYDcN91Jt6i696PjRPiB3RY4pGTCyHZqH\n\tqViVNkhl8bO6hWfRWzo9CL1e45ag4p6uK8TOJS3EHK0IhbYfex/moZ6x4ZgCUChtLrGEu0+NKNN\n\tgKeyWO9GwG2Hqyve3AcwG5CvPIBQ9G7jIPw/RhEMGNvKPnBgOa+ERbVRJAp9jDra5IbmQvVlIAu\n\t7hxUqwyhIhJxBzgKNZ/eb1mZFz9kfXTveotkyhyT7O/YHJhINDUk/02d006RVIxScKXZnK0/aUL\n\t5uSAEgQzOxQAU9FLMdwU8VHXGipCHxPMjOKY7A8LbigRnpKlKZvjAepGmdoOZMWrDgJq+ovJ/b3\n\towWBm5lVLJ4rTtpsXP8o613ScOC4oQIGMpk2nb43yL6HOPv9VLhtbn7Q1D7wnRDObsCo8QyWaLM\n\tnNn+OM5APDq2B3cAxn2JWP8qFf9FKehBzm9vnO5B2Qzud0EsI35c5BnKCu9g==", "X-TM-AS-User-Approved-Sender": "No", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--1.793500-4.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.5.1010-24898.005", "X-MDID": "1568103981-b-sHKwgMiubY", "Subject": "[dpdk-dev] [PATCH 02/18] ethdev: change link status get functions\n\treturn value to int", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Igor Romanov <igor.romanov@oktetlabs.ru>\n\nChange rte_eth_link_get() and rte_eth_link_get_nowait() return value\nfrom void to int and return negative errno values in case of error\nconditions.\n\nReturn value of link_update callback is ignored since the callback\nreturns not errors but whether link up status has changed or not.\n\nSigned-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n doc/guides/rel_notes/deprecation.rst | 1 -\n doc/guides/rel_notes/release_19_11.rst | 4 ++++\n doc/guides/sample_app_ug/link_status_intr.rst | 9 ++++++---\n drivers/net/bonding/rte_eth_bond_pmd.c | 2 +-\n lib/librte_ethdev/rte_ethdev.c | 16 ++++++++++------\n lib/librte_ethdev/rte_ethdev.h | 12 ++++++++++--\n 6 files changed, 31 insertions(+), 13 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst\nindex 165d13726..43b15ec2f 100644\n--- a/doc/guides/rel_notes/deprecation.rst\n+++ b/doc/guides/rel_notes/deprecation.rst\n@@ -88,7 +88,6 @@ Deprecation Notices\n negative errno values to indicate various error conditions (e.g.\n invalid port ID, unsupported operation, failed operation):\n \n- - ``rte_eth_link_get`` and ``rte_eth_link_get_nowait``\n - ``rte_eth_dev_stop``\n - ``rte_eth_dev_close``\n - ``rte_eth_macaddr_get``\ndiff --git a/doc/guides/rel_notes/release_19_11.rst b/doc/guides/rel_notes/release_19_11.rst\nindex d728592c8..3ff1296a2 100644\n--- a/doc/guides/rel_notes/release_19_11.rst\n+++ b/doc/guides/rel_notes/release_19_11.rst\n@@ -108,6 +108,10 @@ API Changes\n * ethdev: changed ``rte_eth_dev_xstats_reset`` return value from ``void`` to\n ``int`` to provide a way to report various error conditions.\n \n+* ethdev: changed ``rte_eth_link_get`` and ``rte_eth_link_get_nowait``\n+ return value from ``void`` to ``int`` to provide a way to report various\n+ error conditions.\n+\n \n ABI Changes\n -----------\ndiff --git a/doc/guides/sample_app_ug/link_status_intr.rst b/doc/guides/sample_app_ug/link_status_intr.rst\nindex cfb1bcd58..5283be8b7 100644\n--- a/doc/guides/sample_app_ug/link_status_intr.rst\n+++ b/doc/guides/sample_app_ug/link_status_intr.rst\n@@ -164,6 +164,7 @@ An example callback function that has been written as indicated below.\n lsi_event_callback(uint16_t port_id, enum rte_eth_event_type type, void *param)\n {\n struct rte_eth_link link;\n+ int ret;\n \n RTE_SET_USED(param);\n \n@@ -171,9 +172,11 @@ An example callback function that has been written as indicated below.\n \n printf(\"Event type: %s\\n\", type == RTE_ETH_EVENT_INTR_LSC ? \"LSC interrupt\" : \"unknown event\");\n \n- rte_eth_link_get_nowait(port_id, &link);\n-\n- if (link.link_status) {\n+ ret = rte_eth_link_get_nowait(port_id, &link);\n+ if (ret < 0) {\n+ printf(\"Failed to get port %d link status: %s\\n\\n\",\n+ port_id, rte_strerror(-ret));\n+ } else if (link.link_status) {\n printf(\"Port %d Link Up - speed %u Mbps - %s\\n\\n\", port_id, (unsigned)link.link_speed,\n (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? (\"full-duplex\") : (\"half-duplex\"));\n } else\ndiff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c\nindex fed71bd95..9316f93f7 100644\n--- a/drivers/net/bonding/rte_eth_bond_pmd.c\n+++ b/drivers/net/bonding/rte_eth_bond_pmd.c\n@@ -2358,7 +2358,7 @@ bond_ethdev_slave_link_status_change_monitor(void *cb_arg)\n static int\n bond_ethdev_link_update(struct rte_eth_dev *ethdev, int wait_to_complete)\n {\n-\tvoid (*link_update)(uint16_t port_id, struct rte_eth_link *eth_link);\n+\tint (*link_update)(uint16_t port_id, struct rte_eth_link *eth_link);\n \n \tstruct bond_dev_private *bond_ctx;\n \tstruct rte_eth_link slave_link;\ndiff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c\nindex 1bd1e32b0..b9fa5f562 100644\n--- a/lib/librte_ethdev/rte_ethdev.c\n+++ b/lib/librte_ethdev/rte_ethdev.c\n@@ -2015,40 +2015,44 @@ rte_eth_allmulticast_get(uint16_t port_id)\n \treturn dev->data->all_multicast;\n }\n \n-void\n+int\n rte_eth_link_get(uint16_t port_id, struct rte_eth_link *eth_link)\n {\n \tstruct rte_eth_dev *dev;\n \n-\tRTE_ETH_VALID_PORTID_OR_RET(port_id);\n+\tRTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);\n \tdev = &rte_eth_devices[port_id];\n \n \tif (dev->data->dev_conf.intr_conf.lsc &&\n \t dev->data->dev_started)\n \t\trte_eth_linkstatus_get(dev, eth_link);\n \telse {\n-\t\tRTE_FUNC_PTR_OR_RET(*dev->dev_ops->link_update);\n+\t\tRTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->link_update, -ENOTSUP);\n \t\t(*dev->dev_ops->link_update)(dev, 1);\n \t\t*eth_link = dev->data->dev_link;\n \t}\n+\n+\treturn 0;\n }\n \n-void\n+int\n rte_eth_link_get_nowait(uint16_t port_id, struct rte_eth_link *eth_link)\n {\n \tstruct rte_eth_dev *dev;\n \n-\tRTE_ETH_VALID_PORTID_OR_RET(port_id);\n+\tRTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);\n \tdev = &rte_eth_devices[port_id];\n \n \tif (dev->data->dev_conf.intr_conf.lsc &&\n \t dev->data->dev_started)\n \t\trte_eth_linkstatus_get(dev, eth_link);\n \telse {\n-\t\tRTE_FUNC_PTR_OR_RET(*dev->dev_ops->link_update);\n+\t\tRTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->link_update, -ENOTSUP);\n \t\t(*dev->dev_ops->link_update)(dev, 0);\n \t\t*eth_link = dev->data->dev_link;\n \t}\n+\n+\treturn 0;\n }\n \n int\ndiff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h\nindex 14420dbbe..aba5b4c86 100644\n--- a/lib/librte_ethdev/rte_ethdev.h\n+++ b/lib/librte_ethdev/rte_ethdev.h\n@@ -2103,8 +2103,12 @@ int rte_eth_allmulticast_get(uint16_t port_id);\n * @param link\n * A pointer to an *rte_eth_link* structure to be filled with\n * the status, the speed and the mode of the Ethernet device link.\n+ * @return\n+ * - (0) if successful.\n+ * - (-ENOTSUP) if the function is not supported in PMD driver.\n+ * - (-ENODEV) if *port_id* invalid.\n */\n-void rte_eth_link_get(uint16_t port_id, struct rte_eth_link *link);\n+int rte_eth_link_get(uint16_t port_id, struct rte_eth_link *link);\n \n /**\n * Retrieve the status (ON/OFF), the speed (in Mbps) and the mode (HALF-DUPLEX\n@@ -2116,8 +2120,12 @@ void rte_eth_link_get(uint16_t port_id, struct rte_eth_link *link);\n * @param link\n * A pointer to an *rte_eth_link* structure to be filled with\n * the status, the speed and the mode of the Ethernet device link.\n+ * @return\n+ * - (0) if successful.\n+ * - (-ENOTSUP) if the function is not supported in PMD driver.\n+ * - (-ENODEV) if *port_id* invalid.\n */\n-void rte_eth_link_get_nowait(uint16_t port_id, struct rte_eth_link *link);\n+int rte_eth_link_get_nowait(uint16_t port_id, struct rte_eth_link *link);\n \n /**\n * Retrieve the general I/O statistics of an Ethernet device.\n", "prefixes": [ "02/18" ] }