Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/58932/?format=api
http://patches.dpdk.org/api/patches/58932/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190907031629.34666-8-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190907031629.34666-8-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190907031629.34666-8-qi.z.zhang@intel.com", "date": "2019-09-07T03:16:14", "name": "[v3,07/22] net/ice/base: remove pointless NULL check of port info", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "fcf5559a3655404de444c9c2dcd9d81fb19f015e", "submitter": { "id": 504, "url": "http://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": { "id": 31221, "url": "http://patches.dpdk.org/api/users/31221/?format=api", "username": "yexl", "first_name": "xiaolong", "last_name": "ye", "email": "xiaolong.ye@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190907031629.34666-8-qi.z.zhang@intel.com/mbox/", "series": [ { "id": 6321, "url": "http://patches.dpdk.org/api/series/6321/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6321", "date": "2019-09-07T03:16:07", "name": "net/ice/base: share code update secend batch.", "version": 3, "mbox": "http://patches.dpdk.org/series/6321/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/58932/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/58932/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B2C791F4C1;\n\tSat, 7 Sep 2019 05:14:17 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id D6E961F46A\n\tfor <dev@dpdk.org>; Sat, 7 Sep 2019 05:14:00 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t06 Sep 2019 20:14:00 -0700", "from dpdk51.sh.intel.com ([10.67.110.245])\n\tby FMSMGA003.fm.intel.com with ESMTP; 06 Sep 2019 20:13:59 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.64,474,1559545200\"; d=\"scan'208\";a=\"191006837\"", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "wenzhuo.lu@intel.com,\n\tqiming.yang@intel.com", "Cc": "dev@dpdk.org, xiaolong.ye@intel.com, Qi Zhang <qi.z.zhang@intel.com>,\n\tJacob Keller <jacob.e.keller@intel.com>,\n\tPaul M Stillwell Jr <paul.m.stillwell.jr@intel.com>", "Date": "Sat, 7 Sep 2019 11:16:14 +0800", "Message-Id": "<20190907031629.34666-8-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.13.6", "In-Reply-To": "<20190907031629.34666-1-qi.z.zhang@intel.com>", "References": "<20190902035551.16852-1-qi.z.zhang@intel.com>\n\t<20190907031629.34666-1-qi.z.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH v3 07/22] net/ice/base: remove pointless NULL\n\tcheck of port info", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The code in ice_sched_cleanup_all checks whether the port info is NULL\nprior to calling ice_sched_clear_port.\n\nMore importantly, it also checks whether the port structure has been\ninitialized by checking its port_state field as well.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\nSigned-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n drivers/net/ice/base/ice_sched.c | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ice/base/ice_sched.c b/drivers/net/ice/base/ice_sched.c\nindex 6732e291a..553fc28ff 100644\n--- a/drivers/net/ice/base/ice_sched.c\n+++ b/drivers/net/ice/base/ice_sched.c\n@@ -840,8 +840,7 @@ void ice_sched_cleanup_all(struct ice_hw *hw)\n \t\thw->layer_info = NULL;\n \t}\n \n-\tif (hw->port_info)\n-\t\tice_sched_clear_port(hw->port_info);\n+\tice_sched_clear_port(hw->port_info);\n \n \thw->num_tx_sched_layers = 0;\n \thw->num_tx_sched_phys_layers = 0;\n", "prefixes": [ "v3", "07/22" ] }{ "id": 58932, "url": "