Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/58913/?format=api
{ "id": 58913, "url": "http://patches.dpdk.org/api/patches/58913/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/3832fb120b0d5c9712ca41036d6a9c40547106f0.1567799552.git.rahul.lakkireddy@chelsio.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<3832fb120b0d5c9712ca41036d6a9c40547106f0.1567799552.git.rahul.lakkireddy@chelsio.com>", "list_archive_url": "https://inbox.dpdk.org/dev/3832fb120b0d5c9712ca41036d6a9c40547106f0.1567799552.git.rahul.lakkireddy@chelsio.com", "date": "2019-09-06T21:52:33", "name": "[12/12] net/cxgbe: add rte_flow support for setting VLAN PCP", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "bf622e231bd9fca4884fe95a63481038a19ccd8e", "submitter": { "id": 241, "url": "http://patches.dpdk.org/api/people/241/?format=api", "name": "Rahul Lakkireddy", "email": "rahul.lakkireddy@chelsio.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/3832fb120b0d5c9712ca41036d6a9c40547106f0.1567799552.git.rahul.lakkireddy@chelsio.com/mbox/", "series": [ { "id": 6317, "url": "http://patches.dpdk.org/api/series/6317/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6317", "date": "2019-09-06T21:52:21", "name": "net/cxgbe: bug fixes and updates for CXGBE/CXGBEVF PMD", "version": 1, "mbox": "http://patches.dpdk.org/series/6317/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/58913/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/58913/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C24BE1F4F6;\n\tSat, 7 Sep 2019 00:00:20 +0200 (CEST)", "from stargate.chelsio.com (stargate.chelsio.com [12.32.117.8])\n\tby dpdk.org (Postfix) with ESMTP id 8D9181F4F6\n\tfor <dev@dpdk.org>; Sat, 7 Sep 2019 00:00:19 +0200 (CEST)", "from localhost (scalar.blr.asicdesigners.com [10.193.185.94])\n\tby stargate.chelsio.com (8.13.8/8.13.8) with ESMTP id x86M0DxW004226; \n\tFri, 6 Sep 2019 15:00:14 -0700" ], "From": "Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>", "To": "dev@dpdk.org", "Cc": "nirranjan@chelsio.com", "Date": "Sat, 7 Sep 2019 03:22:33 +0530", "Message-Id": "<3832fb120b0d5c9712ca41036d6a9c40547106f0.1567799552.git.rahul.lakkireddy@chelsio.com>", "X-Mailer": "git-send-email 2.5.3", "In-Reply-To": [ "<cover.1567799552.git.rahul.lakkireddy@chelsio.com>", "<cover.1567799552.git.rahul.lakkireddy@chelsio.com>" ], "References": [ "<cover.1567799552.git.rahul.lakkireddy@chelsio.com>", "<cover.1567799552.git.rahul.lakkireddy@chelsio.com>" ], "Subject": "[dpdk-dev] [PATCH 12/12] net/cxgbe: add rte_flow support for\n\tsetting VLAN PCP", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add support for setting VLAN PCP field via rte_flow API. Hardware\noverwrites the entire 16-bit VLAN TCI field. So, both VLAN VID and\nPCP actions must be specified.\n\nSigned-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>\n---\n drivers/net/cxgbe/cxgbe_flow.c | 27 +++++++++++++++++++++++++++\n 1 file changed, 27 insertions(+)", "diff": "diff --git a/drivers/net/cxgbe/cxgbe_flow.c b/drivers/net/cxgbe/cxgbe_flow.c\nindex 4b72e6422..9ee8353ae 100644\n--- a/drivers/net/cxgbe/cxgbe_flow.c\n+++ b/drivers/net/cxgbe/cxgbe_flow.c\n@@ -568,6 +568,7 @@ ch_rte_parse_atype_switch(const struct rte_flow_action *a,\n \t\t\t struct rte_flow_error *e)\n {\n \tconst struct rte_flow_action_of_set_vlan_vid *vlanid;\n+\tconst struct rte_flow_action_of_set_vlan_pcp *vlanpcp;\n \tconst struct rte_flow_action_of_push_vlan *pushvlan;\n \tconst struct rte_flow_action_set_ipv4 *ipv4;\n \tconst struct rte_flow_action_set_ipv6 *ipv6;\n@@ -591,6 +592,20 @@ ch_rte_parse_atype_switch(const struct rte_flow_action *a,\n \t\ttmp_vlan = fs->vlan & 0xe000;\n \t\tfs->vlan = (be16_to_cpu(vlanid->vlan_vid) & 0xfff) | tmp_vlan;\n \t\tbreak;\n+\tcase RTE_FLOW_ACTION_TYPE_OF_SET_VLAN_PCP:\n+\t\tvlanpcp = (const struct rte_flow_action_of_set_vlan_pcp *)\n+\t\t\t a->conf;\n+\t\t/* If explicitly asked to push a new VLAN header,\n+\t\t * then don't set rewrite mode. Otherwise, the\n+\t\t * incoming VLAN packets will get their VLAN fields\n+\t\t * rewritten, instead of adding an additional outer\n+\t\t * VLAN header.\n+\t\t */\n+\t\tif (fs->newvlan != VLAN_INSERT)\n+\t\t\tfs->newvlan = VLAN_REWRITE;\n+\t\ttmp_vlan = fs->vlan & 0xfff;\n+\t\tfs->vlan = (vlanpcp->vlan_pcp << 13) | tmp_vlan;\n+\t\tbreak;\n \tcase RTE_FLOW_ACTION_TYPE_OF_PUSH_VLAN:\n \t\tpushvlan = (const struct rte_flow_action_of_push_vlan *)\n \t\t\t a->conf;\n@@ -724,6 +739,7 @@ cxgbe_rtef_parse_actions(struct rte_flow *flow,\n {\n \tstruct ch_filter_specification *fs = &flow->fs;\n \tuint8_t nmode = 0, nat_ipv4 = 0, nat_ipv6 = 0;\n+\tuint8_t vlan_set_vid = 0, vlan_set_pcp = 0;\n \tconst struct rte_flow_action_queue *q;\n \tconst struct rte_flow_action *a;\n \tchar abit = 0;\n@@ -762,6 +778,11 @@ cxgbe_rtef_parse_actions(struct rte_flow *flow,\n \t\t\tfs->hitcnts = 1;\n \t\t\tbreak;\n \t\tcase RTE_FLOW_ACTION_TYPE_OF_SET_VLAN_VID:\n+\t\t\tvlan_set_vid++;\n+\t\t\tgoto action_switch;\n+\t\tcase RTE_FLOW_ACTION_TYPE_OF_SET_VLAN_PCP:\n+\t\t\tvlan_set_pcp++;\n+\t\t\tgoto action_switch;\n \t\tcase RTE_FLOW_ACTION_TYPE_OF_PUSH_VLAN:\n \t\tcase RTE_FLOW_ACTION_TYPE_OF_POP_VLAN:\n \t\tcase RTE_FLOW_ACTION_TYPE_PHY_PORT:\n@@ -804,6 +825,12 @@ cxgbe_rtef_parse_actions(struct rte_flow *flow,\n \t\t}\n \t}\n \n+\tif (fs->newvlan == VLAN_REWRITE && (!vlan_set_vid || !vlan_set_pcp))\n+\t\treturn rte_flow_error_set(e, EINVAL,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION, a,\n+\t\t\t\t\t \"Both OF_SET_VLAN_VID and \"\n+\t\t\t\t\t \"OF_SET_VLAN_PCP must be specified\");\n+\n \tif (ch_rte_parse_nat(nmode, fs))\n \t\treturn rte_flow_error_set(e, EINVAL,\n \t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION, a,\n", "prefixes": [ "12/12" ] }