Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/58906/?format=api
{ "id": 58906, "url": "http://patches.dpdk.org/api/patches/58906/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/f797f93570f60964b4fbf80617bd86b5b292a90c.1567799552.git.rahul.lakkireddy@chelsio.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<f797f93570f60964b4fbf80617bd86b5b292a90c.1567799552.git.rahul.lakkireddy@chelsio.com>", "list_archive_url": "https://inbox.dpdk.org/dev/f797f93570f60964b4fbf80617bd86b5b292a90c.1567799552.git.rahul.lakkireddy@chelsio.com", "date": "2019-09-06T21:52:26", "name": "[05/12] net/cxgbe: fix prefetch for non-coalesced Tx packets", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "b540519d4963df0debdd2747b7f5e550ad2625a1", "submitter": { "id": 241, "url": "http://patches.dpdk.org/api/people/241/?format=api", "name": "Rahul Lakkireddy", "email": "rahul.lakkireddy@chelsio.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/f797f93570f60964b4fbf80617bd86b5b292a90c.1567799552.git.rahul.lakkireddy@chelsio.com/mbox/", "series": [ { "id": 6317, "url": "http://patches.dpdk.org/api/series/6317/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6317", "date": "2019-09-06T21:52:21", "name": "net/cxgbe: bug fixes and updates for CXGBE/CXGBEVF PMD", "version": 1, "mbox": "http://patches.dpdk.org/series/6317/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/58906/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/58906/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9BB571F4B5;\n\tFri, 6 Sep 2019 23:59:54 +0200 (CEST)", "from stargate.chelsio.com (stargate.chelsio.com [12.32.117.8])\n\tby dpdk.org (Postfix) with ESMTP id 605EA1F4AF;\n\tFri, 6 Sep 2019 23:59:53 +0200 (CEST)", "from localhost (scalar.blr.asicdesigners.com [10.193.185.94])\n\tby stargate.chelsio.com (8.13.8/8.13.8) with ESMTP id x86LxmPi004202; \n\tFri, 6 Sep 2019 14:59:49 -0700" ], "From": "Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>", "To": "dev@dpdk.org", "Cc": "nirranjan@chelsio.com, stable@dpdk.org", "Date": "Sat, 7 Sep 2019 03:22:26 +0530", "Message-Id": "<f797f93570f60964b4fbf80617bd86b5b292a90c.1567799552.git.rahul.lakkireddy@chelsio.com>", "X-Mailer": "git-send-email 2.5.3", "In-Reply-To": [ "<cover.1567799552.git.rahul.lakkireddy@chelsio.com>", "<cover.1567799552.git.rahul.lakkireddy@chelsio.com>" ], "References": [ "<cover.1567799552.git.rahul.lakkireddy@chelsio.com>", "<cover.1567799552.git.rahul.lakkireddy@chelsio.com>" ], "Subject": "[dpdk-dev] [PATCH 05/12] net/cxgbe: fix prefetch for non-coalesced\n\tTx packets", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Move prefetch code out of Tx coalesce path to allow prefetching for\nnon-coalesced Tx packets, as well.\n\nCc: stable@dpdk.org\nFixes: bf89cbedd2d9 (\"cxgbe: optimize forwarding performance for 40G\")\n\nSigned-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>\n---\n drivers/net/cxgbe/cxgbe_ethdev.c | 9 +++++++--\n drivers/net/cxgbe/sge.c | 1 -\n 2 files changed, 7 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/cxgbe/cxgbe_ethdev.c b/drivers/net/cxgbe/cxgbe_ethdev.c\nindex efb458d47..fb174f8d4 100644\n--- a/drivers/net/cxgbe/cxgbe_ethdev.c\n+++ b/drivers/net/cxgbe/cxgbe_ethdev.c\n@@ -67,6 +67,7 @@ uint16_t cxgbe_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \tstruct sge_eth_txq *txq = (struct sge_eth_txq *)tx_queue;\n \tuint16_t pkts_sent, pkts_remain;\n \tuint16_t total_sent = 0;\n+\tuint16_t idx = 0;\n \tint ret = 0;\n \n \tCXGBE_DEBUG_TX(adapter, \"%s: txq = %p; tx_pkts = %p; nb_pkts = %d\\n\",\n@@ -75,12 +76,16 @@ uint16_t cxgbe_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \tt4_os_lock(&txq->txq_lock);\n \t/* free up desc from already completed tx */\n \treclaim_completed_tx(&txq->q);\n+\trte_prefetch0(rte_pktmbuf_mtod(tx_pkts[0], volatile void *));\n \twhile (total_sent < nb_pkts) {\n \t\tpkts_remain = nb_pkts - total_sent;\n \n \t\tfor (pkts_sent = 0; pkts_sent < pkts_remain; pkts_sent++) {\n-\t\t\tret = t4_eth_xmit(txq, tx_pkts[total_sent + pkts_sent],\n-\t\t\t\t\t nb_pkts);\n+\t\t\tidx = total_sent + pkts_sent;\n+\t\t\tif ((idx + 1) < nb_pkts)\n+\t\t\t\trte_prefetch0(rte_pktmbuf_mtod(tx_pkts[idx + 1],\n+\t\t\t\t\t\t\tvolatile void *));\n+\t\t\tret = t4_eth_xmit(txq, tx_pkts[idx], nb_pkts);\n \t\t\tif (ret < 0)\n \t\t\t\tbreak;\n \t\t}\ndiff --git a/drivers/net/cxgbe/sge.c b/drivers/net/cxgbe/sge.c\nindex 641be9657..bf3190211 100644\n--- a/drivers/net/cxgbe/sge.c\n+++ b/drivers/net/cxgbe/sge.c\n@@ -1154,7 +1154,6 @@ int t4_eth_xmit(struct sge_eth_txq *txq, struct rte_mbuf *mbuf,\n \t\t\t\ttxq->stats.mapping_err++;\n \t\t\t\tgoto out_free;\n \t\t\t}\n-\t\t\trte_prefetch0((volatile void *)addr);\n \t\t\treturn tx_do_packet_coalesce(txq, mbuf, cflits, adap,\n \t\t\t\t\t\t pi, addr, nb_pkts);\n \t\t} else {\n", "prefixes": [ "05/12" ] }