Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/58730/?format=api
{ "id": 58730, "url": "http://patches.dpdk.org/api/patches/58730/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190906065020.21206-2-hyonkim@cisco.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190906065020.21206-2-hyonkim@cisco.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190906065020.21206-2-hyonkim@cisco.com", "date": "2019-09-06T06:50:18", "name": "[1/3] net/enic: restrict several handlers to primary process", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "5818d17616b1960048a13ba49b6a0a47a2d022b7", "submitter": { "id": 948, "url": "http://patches.dpdk.org/api/people/948/?format=api", "name": "Hyong Youb Kim (hyonkim)", "email": "hyonkim@cisco.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190906065020.21206-2-hyonkim@cisco.com/mbox/", "series": [ { "id": 6277, "url": "http://patches.dpdk.org/api/series/6277/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6277", "date": "2019-09-06T06:50:17", "name": "net/enic: fix multi-process isseus", "version": 1, "mbox": "http://patches.dpdk.org/series/6277/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/58730/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/58730/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C0DEF1F13D;\n\tFri, 6 Sep 2019 08:53:40 +0200 (CEST)", "from alln-iport-7.cisco.com (alln-iport-7.cisco.com\n\t[173.37.142.94]) by dpdk.org (Postfix) with ESMTP id 7EDCB1F13C;\n\tFri, 6 Sep 2019 08:53:39 +0200 (CEST)", "from alln-core-6.cisco.com ([173.36.13.139])\n\tby alln-iport-7.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA;\n\t06 Sep 2019 06:53:38 +0000", "from cisco.com (savbu-usnic-a.cisco.com [10.193.184.48])\n\tby alln-core-6.cisco.com (8.15.2/8.15.2) with ESMTP id x866rcQ3006808;\n\tFri, 6 Sep 2019 06:53:38 GMT", "by cisco.com (Postfix, from userid 508933)\n\tid 18ADB20F2003; Thu, 5 Sep 2019 23:53:38 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n\td=cisco.com; i=@cisco.com; l=2669; q=dns/txt; s=iport;\n\tt=1567752819; x=1568962419;\n\th=from:to:cc:subject:date:message-id:in-reply-to:\n\treferences:mime-version:content-transfer-encoding;\n\tbh=bPvVVCrAYkqPYWPnHj6muNc3mxhTvLh4SUS1F5f8bhw=;\n\tb=EkvoWuclK9h7r5jicAHaTsqpEwTK8cMtUCpHTnjXqwSPswmNFkBRnVCI\n\tu8eEhXSvZeY/Btn2JsVKeGE7EZxlHffzBqFC8pahVmFNrtfseBrHRFauD\n\t3gnHW8Fun8/mLO3ITcFnA+X4N4RvLyQEor0LNbfDVL3xejoDrqmAZctpk o=;", "X-IronPort-AV": "E=Sophos;i=\"5.64,472,1559520000\"; d=\"scan'208\";a=\"320821705\"", "From": "Hyong Youb Kim <hyonkim@cisco.com>", "To": "Ferruh Yigit <ferruh.yigit@intel.com>", "Cc": "dev@dpdk.org, John Daley <johndale@cisco.com>,\n\tDirk-Holger Lenz <dirk.lenz@ng4t.com>,\n\tHyong Youb Kim <hyonkim@cisco.com>, stable@dpdk.org", "Date": "Thu, 5 Sep 2019 23:50:18 -0700", "Message-Id": "<20190906065020.21206-2-hyonkim@cisco.com>", "X-Mailer": "git-send-email 2.22.0", "In-Reply-To": "<20190906065020.21206-1-hyonkim@cisco.com>", "References": "<20190906065020.21206-1-hyonkim@cisco.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Outbound-SMTP-Client": "10.193.184.48, savbu-usnic-a.cisco.com", "X-Outbound-Node": "alln-core-6.cisco.com", "Subject": "[dpdk-dev] [PATCH 1/3] net/enic: restrict several handlers to\n\tprimary process", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "These eth_dev_ops handlers should run only in the primary process.\n- filter_ctrl\n- reta_update\n- rss_hash_update\n- set_mc_addr_list\n- udp_tunnel_port_add\n- udp_tunnel_port_del\n\nFixes: c2fec27b5cb0 (\"net/enic: allow to change RSS settings\")\nFixes: 8d496995346c (\"net/enic: support multicast filtering\")\nFixes: 8a4efd17410c (\"net/enic: add handlers to add/delete vxlan port number\")\nCc: stable@dpdk.org\n\nReported-by: Dirk-Holger Lenz <dirk.lenz@ng4t.com>\nSigned-off-by: Hyong Youb Kim <hyonkim@cisco.com>\nTested-by: Dirk-Holger Lenz <dirk.lenz@ng4t.com>\nReviewed-by: John Daley <johndale@cisco.com>\n---\n drivers/net/enic/enic_ethdev.c | 12 ++++++++++++\n 1 file changed, 12 insertions(+)", "diff": "diff --git a/drivers/net/enic/enic_ethdev.c b/drivers/net/enic/enic_ethdev.c\nindex 06dc67122..85d785e62 100644\n--- a/drivers/net/enic/enic_ethdev.c\n+++ b/drivers/net/enic/enic_ethdev.c\n@@ -129,6 +129,8 @@ enicpmd_dev_filter_ctrl(struct rte_eth_dev *dev,\n {\n \tint ret = 0;\n \n+\tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n+\t\treturn -E_RTE_SECONDARY;\n \tENICPMD_FUNC_TRACE();\n \n \tswitch (filter_type) {\n@@ -710,6 +712,8 @@ static int enicpmd_set_mc_addr_list(struct rte_eth_dev *eth_dev,\n \tuint32_t i, j;\n \tint ret;\n \n+\tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n+\t\treturn -E_RTE_SECONDARY;\n \tENICPMD_FUNC_TRACE();\n \n \t/* Validate the given addresses first */\n@@ -826,6 +830,8 @@ static int enicpmd_dev_rss_reta_update(struct rte_eth_dev *dev,\n \tunion vnic_rss_cpu rss_cpu;\n \tuint16_t i, idx, shift;\n \n+\tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n+\t\treturn -E_RTE_SECONDARY;\n \tENICPMD_FUNC_TRACE();\n \tif (reta_size != ENIC_RSS_RETA_SIZE) {\n \t\tdev_err(enic, \"reta_update: wrong reta_size. given=%u\"\n@@ -854,6 +860,8 @@ static int enicpmd_dev_rss_hash_update(struct rte_eth_dev *dev,\n {\n \tstruct enic *enic = pmd_priv(dev);\n \n+\tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n+\t\treturn -E_RTE_SECONDARY;\n \tENICPMD_FUNC_TRACE();\n \treturn enic_set_rss_conf(enic, rss_conf);\n }\n@@ -986,6 +994,8 @@ static int enicpmd_dev_udp_tunnel_port_add(struct rte_eth_dev *eth_dev,\n \tstruct enic *enic = pmd_priv(eth_dev);\n \tint ret;\n \n+\tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n+\t\treturn -E_RTE_SECONDARY;\n \tENICPMD_FUNC_TRACE();\n \tret = udp_tunnel_common_check(enic, tnl);\n \tif (ret)\n@@ -1008,6 +1018,8 @@ static int enicpmd_dev_udp_tunnel_port_del(struct rte_eth_dev *eth_dev,\n \tstruct enic *enic = pmd_priv(eth_dev);\n \tint ret;\n \n+\tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n+\t\treturn -E_RTE_SECONDARY;\n \tENICPMD_FUNC_TRACE();\n \tret = udp_tunnel_common_check(enic, tnl);\n \tif (ret)\n", "prefixes": [ "1/3" ] }