Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/58718/?format=api
{ "id": 58718, "url": "http://patches.dpdk.org/api/patches/58718/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190906120058.108073-8-yahui.cao@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190906120058.108073-8-yahui.cao@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190906120058.108073-8-yahui.cao@intel.com", "date": "2019-09-06T12:00:53", "name": "[07/12] net/ice: enable FDIR queue group", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "bc58d25c627c35578d4bb588bb82430a85043420", "submitter": { "id": 1176, "url": "http://patches.dpdk.org/api/people/1176/?format=api", "name": "Cao, Yahui", "email": "yahui.cao@intel.com" }, "delegate": { "id": 31221, "url": "http://patches.dpdk.org/api/users/31221/?format=api", "username": "yexl", "first_name": "xiaolong", "last_name": "ye", "email": "xiaolong.ye@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190906120058.108073-8-yahui.cao@intel.com/mbox/", "series": [ { "id": 6273, "url": "http://patches.dpdk.org/api/series/6273/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6273", "date": "2019-09-06T12:00:46", "name": "net/ice: add ice Flow Director driver", "version": 1, "mbox": "http://patches.dpdk.org/series/6273/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/58718/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/58718/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 047EE1F122;\n\tFri, 6 Sep 2019 06:16:35 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id BF0D31F104\n\tfor <dev@dpdk.org>; Fri, 6 Sep 2019 06:16:25 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t05 Sep 2019 21:16:25 -0700", "from dpdk-yahui-skylake.sh.intel.com ([10.67.119.16])\n\tby FMSMGA003.fm.intel.com with ESMTP; 05 Sep 2019 21:16:24 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.64,472,1559545200\"; d=\"scan'208\";a=\"190709728\"", "From": "Yahui Cao <yahui.cao@intel.com>", "To": "Qiming Yang <qiming.yang@intel.com>,\n\tWenzhuo Lu <wenzhuo.lu@intel.com>", "Cc": "dev@dpdk.org, Qi Zhang <qi.z.zhang@intel.com>,\n\tXiaolong Ye <xiaolong.ye@intel.com>,\n\tBeilei Xing <beilei.xing@intel.com>, Yahui Cao <yahui.cao@intel.com>", "Date": "Fri, 6 Sep 2019 20:00:53 +0800", "Message-Id": "<20190906120058.108073-8-yahui.cao@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20190906120058.108073-1-yahui.cao@intel.com>", "References": "<20190906120058.108073-1-yahui.cao@intel.com>", "Subject": "[dpdk-dev] [dpdk-dev 07/12] net/ice: enable FDIR queue group", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "FDIR can send packet to a group of queues and distruibte it by RSS.\n\nSigned-off-by: Yahui Cao <yahui.cao@intel.com>\n---\n drivers/net/ice/ice_fdir_filter.c | 65 +++++++++++++++++++++++++++++++\n 1 file changed, 65 insertions(+)", "diff": "diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir_filter.c\nindex df4d0329c..ebbe1bd6c 100644\n--- a/drivers/net/ice/ice_fdir_filter.c\n+++ b/drivers/net/ice/ice_fdir_filter.c\n@@ -741,6 +741,62 @@ static struct ice_flow_engine ice_fdir_engine = {\n \t.type = ICE_FLOW_ENGINE_FDIR,\n };\n \n+static int\n+ice_fdir_parse_action_qregion(struct ice_pf *pf,\n+\t\t\t struct rte_flow_error *error,\n+\t\t\t const struct rte_flow_action *act,\n+\t\t\t struct ice_fdir_filter_conf *filter)\n+{\n+\tconst struct rte_flow_action_rss *rss = act->conf;\n+\tuint32_t i;\n+\n+\tif (act->type != RTE_FLOW_ACTION_TYPE_RSS) {\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION, act,\n+\t\t\t\t \"Invalid action.\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\tif (rss->queue_num <= 1) {\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION, act,\n+\t\t\t\t \"Queue region size can't be 0 or 1.\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\t/* check if queue index for queue region is continuos */\n+\tfor (i = 0; i < rss->queue_num - 1; i++) {\n+\t\tif (rss->queue[i + 1] != rss->queue[i] + 1) {\n+\t\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION, act,\n+\t\t\t\t\t \"Invalid queue region indexes.\");\n+\t\t\treturn -rte_errno;\n+\t\t}\n+\t}\n+\n+\tif (rss->queue[rss->queue_num - 1] >= pf->dev_data->nb_rx_queues) {\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION, act,\n+\t\t\t\t \"Invalid queue region indexes.\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\tif (!(rte_is_power_of_2(rss->queue_num) && (rss->queue_num <= 128))) {\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION, act,\n+\t\t\t\t \"The region sizes should be any of the following values:\"\n+\t\t\t\t \"1, 2, 4, 8, 16, 32, 64, 128 as long as the total number \"\n+\t\t\t\t \"of queues do not exceed the VSI allocation.\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\tfilter->input.q_index = rss->queue[0];\n+\tfilter->input.q_region = rte_fls_u32(rss->queue_num) - 1;\n+\tfilter->input.dest_ctl = ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_QGROUP;\n+\n+\treturn 0;\n+}\n+\n static int\n ice_fdir_parse_action(struct ice_adapter *ad,\n \t\t const struct rte_flow_action actions[],\n@@ -752,6 +808,7 @@ ice_fdir_parse_action(struct ice_adapter *ad,\n \tconst struct rte_flow_action_mark *mark_spec = NULL;\n \tuint32_t dest_num = 0;\n \tuint32_t mark_num = 0;\n+\tint ret;\n \n \tfor (; actions->type != RTE_FLOW_ACTION_TYPE_END; actions++) {\n \t\tswitch (actions->type) {\n@@ -785,6 +842,14 @@ ice_fdir_parse_action(struct ice_adapter *ad,\n \t\t\t\tICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_QINDEX;\n \t\t\tfilter->input.q_index = 0;\n \t\t\tbreak;\n+\t\tcase RTE_FLOW_ACTION_TYPE_RSS:\n+\t\t\tdest_num++;\n+\n+\t\t\tret = ice_fdir_parse_action_qregion(pf,\n+\t\t\t\t\t\terror, actions, filter);\n+\t\t\tif (ret)\n+\t\t\t\treturn ret;\n+\t\t\tbreak;\n \t\tcase RTE_FLOW_ACTION_TYPE_MARK:\n \t\t\tmark_num++;\n \n", "prefixes": [ "07/12" ] }