Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/58659/?format=api
http://patches.dpdk.org/api/patches/58659/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190905145315.19395-5-ferruh.yigit@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190905145315.19395-5-ferruh.yigit@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190905145315.19395-5-ferruh.yigit@intel.com", "date": "2019-09-05T14:53:09", "name": "[04/10] crypto/octeontx: fix global variable multiple definitions", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "8be2b7ef061fb1acf7ff137bc15d7a9d9ba744c5", "submitter": { "id": 324, "url": "http://patches.dpdk.org/api/people/324/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@intel.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190905145315.19395-5-ferruh.yigit@intel.com/mbox/", "series": [ { "id": 6259, "url": "http://patches.dpdk.org/api/series/6259/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6259", "date": "2019-09-05T14:53:05", "name": "fix global variable multiple definitions", "version": 1, "mbox": "http://patches.dpdk.org/series/6259/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/58659/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/58659/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id F2C7F1EFF4;\n\tThu, 5 Sep 2019 16:53:34 +0200 (CEST)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n\tby dpdk.org (Postfix) with ESMTP id 6D3F41EF61;\n\tThu, 5 Sep 2019 16:53:25 +0200 (CEST)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n\tby fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t05 Sep 2019 07:53:25 -0700", "from silpixa00399752.ir.intel.com (HELO\n\tsilpixa00399752.ger.corp.intel.com) ([10.237.223.78])\n\tby fmsmga008.fm.intel.com with ESMTP; 05 Sep 2019 07:53:24 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.64,470,1559545200\"; d=\"scan'208\";a=\"182846351\"", "From": "Ferruh Yigit <ferruh.yigit@intel.com>", "To": "Anoob Joseph <anoobj@marvell.com>", "Cc": "dev@dpdk.org,\n\tstable@dpdk.org", "Date": "Thu, 5 Sep 2019 15:53:09 +0100", "Message-Id": "<20190905145315.19395-5-ferruh.yigit@intel.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190905145315.19395-1-ferruh.yigit@intel.com>", "References": "<20190905145315.19395-1-ferruh.yigit@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 04/10] crypto/octeontx: fix global variable\n\tmultiple definitions", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "'cpt_logtype' & 'otx_cryptodev_driver_id' global variables are defined\nin a header file which was causing multiple definitions of the\nvariables, fixed it by moving them to the .c file.\n\nIssue has been detected by '-fno-common' gcc flag.\n\nFixes: bfe2ae495ee2 (\"crypto/octeontx: add PMD skeleton\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ferruh Yigit <ferruh.yigit@intel.com>\n---\n drivers/common/cpt/cpt_pmd_logs.h | 2 +-\n drivers/crypto/octeontx/otx_cryptodev.c | 2 ++\n drivers/crypto/octeontx/otx_cryptodev.h | 2 +-\n 3 files changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/common/cpt/cpt_pmd_logs.h b/drivers/common/cpt/cpt_pmd_logs.h\nindex 4cbec4e36..2681d1286 100644\n--- a/drivers/common/cpt/cpt_pmd_logs.h\n+++ b/drivers/common/cpt/cpt_pmd_logs.h\n@@ -45,6 +45,6 @@\n * cpt_logtype will be used for common logging. This field would be initialized\n * by otx_* driver routines during PCI probe.\n */\n-int cpt_logtype;\n+extern int cpt_logtype;\n \n #endif /* _CPT_PMD_LOGS_H_ */\ndiff --git a/drivers/crypto/octeontx/otx_cryptodev.c b/drivers/crypto/octeontx/otx_cryptodev.c\nindex fc64a5f30..604dc2cdb 100644\n--- a/drivers/crypto/octeontx/otx_cryptodev.c\n+++ b/drivers/crypto/octeontx/otx_cryptodev.c\n@@ -16,6 +16,8 @@\n #include \"otx_cryptodev_ops.h\"\n \n static int otx_cryptodev_logtype;\n+int cpt_logtype;\n+uint8_t otx_cryptodev_driver_id;\n \n static struct rte_pci_id pci_id_cpt_table[] = {\n \t{\ndiff --git a/drivers/crypto/octeontx/otx_cryptodev.h b/drivers/crypto/octeontx/otx_cryptodev.h\nindex 6c2871d71..0b204320a 100644\n--- a/drivers/crypto/octeontx/otx_cryptodev.h\n+++ b/drivers/crypto/octeontx/otx_cryptodev.h\n@@ -15,6 +15,6 @@\n /*\n * Crypto device driver ID\n */\n-uint8_t otx_cryptodev_driver_id;\n+extern uint8_t otx_cryptodev_driver_id;\n \n #endif /* _OTX_CRYPTODEV_H_ */\n", "prefixes": [ "04/10" ] }{ "id": 58659, "url": "