Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/58656/?format=api
http://patches.dpdk.org/api/patches/58656/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190905145315.19395-2-ferruh.yigit@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190905145315.19395-2-ferruh.yigit@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190905145315.19395-2-ferruh.yigit@intel.com", "date": "2019-09-05T14:53:06", "name": "[01/10] bus/fslmc: fix global variable multiple definitions", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "f7e6b77186d80cd0337f38164c17f2d8f1a06a74", "submitter": { "id": 324, "url": "http://patches.dpdk.org/api/people/324/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@intel.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190905145315.19395-2-ferruh.yigit@intel.com/mbox/", "series": [ { "id": 6259, "url": "http://patches.dpdk.org/api/series/6259/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6259", "date": "2019-09-05T14:53:05", "name": "fix global variable multiple definitions", "version": 1, "mbox": "http://patches.dpdk.org/series/6259/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/58656/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/58656/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DE9AC1EFA8;\n\tThu, 5 Sep 2019 16:53:27 +0200 (CEST)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n\tby dpdk.org (Postfix) with ESMTP id 6B6121EF3E;\n\tThu, 5 Sep 2019 16:53:22 +0200 (CEST)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n\tby fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t05 Sep 2019 07:53:21 -0700", "from silpixa00399752.ir.intel.com (HELO\n\tsilpixa00399752.ger.corp.intel.com) ([10.237.223.78])\n\tby fmsmga008.fm.intel.com with ESMTP; 05 Sep 2019 07:53:20 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.64,470,1559545200\"; d=\"scan'208\";a=\"182846336\"", "From": "Ferruh Yigit <ferruh.yigit@intel.com>", "To": "Hemant Agrawal <hemant.agrawal@nxp.com>,\n\tSachin Saxena <sachin.saxena@nxp.com>", "Cc": "dev@dpdk.org,\n\tstable@dpdk.org", "Date": "Thu, 5 Sep 2019 15:53:06 +0100", "Message-Id": "<20190905145315.19395-2-ferruh.yigit@intel.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190905145315.19395-1-ferruh.yigit@intel.com>", "References": "<20190905145315.19395-1-ferruh.yigit@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 01/10] bus/fslmc: fix global variable multiple\n\tdefinitions", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "'qman_version' global variable is defined in a header file which was\ncausing multiple definitions of the variable, fixed it by moving it to\nthe .c file.\n\nIssue has been detected by '-fno-common' gcc flag.\n\nFixes: 293c0ca94c36 (\"bus/fslmc: support memory backed portals with QBMAN 5.0\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ferruh Yigit <ferruh.yigit@intel.com>\n---\n drivers/bus/fslmc/qbman/qbman_portal.c | 2 ++\n drivers/bus/fslmc/qbman/qbman_portal.h | 2 +-\n 2 files changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/bus/fslmc/qbman/qbman_portal.c b/drivers/bus/fslmc/qbman/qbman_portal.c\nindex e6066ce35..12a718117 100644\n--- a/drivers/bus/fslmc/qbman/qbman_portal.c\n+++ b/drivers/bus/fslmc/qbman/qbman_portal.c\n@@ -61,6 +61,8 @@ enum qbman_sdqcr_fc {\n #define MAX_QBMAN_PORTALS 64\n static struct qbman_swp *portal_idx_map[MAX_QBMAN_PORTALS];\n \n+uint32_t qman_version;\n+\n /* Internal Function declaration */\n static int\n qbman_swp_enqueue_array_mode_direct(struct qbman_swp *s,\ndiff --git a/drivers/bus/fslmc/qbman/qbman_portal.h b/drivers/bus/fslmc/qbman/qbman_portal.h\nindex e54f2661c..0e9de8a1b 100644\n--- a/drivers/bus/fslmc/qbman/qbman_portal.h\n+++ b/drivers/bus/fslmc/qbman/qbman_portal.h\n@@ -11,7 +11,7 @@\n #include \"qbman_sys.h\"\n #include <fsl_qbman_portal.h>\n \n-uint32_t qman_version;\n+extern uint32_t qman_version;\n #define QMAN_REV_4000 0x04000000\n #define QMAN_REV_4100 0x04010000\n #define QMAN_REV_4101 0x04010001\n", "prefixes": [ "01/10" ] }{ "id": 58656, "url": "