Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/58655/?format=api
{ "id": 58655, "url": "http://patches.dpdk.org/api/patches/58655/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190905145315.19395-1-ferruh.yigit@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190905145315.19395-1-ferruh.yigit@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190905145315.19395-1-ferruh.yigit@intel.com", "date": "2019-09-05T14:53:05", "name": "[00/10] fix global variable multiple definitions", "commit_ref": null, "pull_url": null, "state": null, "archived": false, "hash": null, "submitter": { "id": 324, "url": "http://patches.dpdk.org/api/people/324/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190905145315.19395-1-ferruh.yigit@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/58655/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/58655/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0DEA31EF55;\n\tThu, 5 Sep 2019 16:53:24 +0200 (CEST)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n\tby dpdk.org (Postfix) with ESMTP id 9829D1EF3E\n\tfor <dev@dpdk.org>; Thu, 5 Sep 2019 16:53:21 +0200 (CEST)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n\tby fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t05 Sep 2019 07:53:20 -0700", "from silpixa00399752.ir.intel.com (HELO\n\tsilpixa00399752.ger.corp.intel.com) ([10.237.223.78])\n\tby fmsmga008.fm.intel.com with ESMTP; 05 Sep 2019 07:53:19 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.64,470,1559545200\"; d=\"scan'208\";a=\"182846335\"", "From": "Ferruh Yigit <ferruh.yigit@intel.com>", "To": "dev@dpdk.org", "Date": "Thu, 5 Sep 2019 15:53:05 +0100", "Message-Id": "<20190905145315.19395-1-ferruh.yigit@intel.com>", "X-Mailer": "git-send-email 2.21.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 00/10] fix global variable multiple definitions", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Issue has been detected by '-fno-common' gcc flag. By default compiler\nstill can figure out that multiple definition are the same variable and\nuse same storage for all definitions but this is implementation specific\nbehaviour and better to fix it.\n\nMany of the cases below it is nice to have to use 'extern' keyword but\nthere are some defects in 'virtio, ''dpaa2_sec' & 'test' that multiple\ncomponents share same global variable unintentionally.\n\nFerruh Yigit (10):\n bus/fslmc: fix global variable multiple definitions\n net/igb: fix global variable multiple definitions\n crypto/null: fix global variable multiple definitions\n crypto/octeontx: fix global variable multiple definitions\n crypto/dpaa2_sec: fix global variable multiple definitions\n crypto/virtio: fix global variable multiple definitions\n compress/octeontx: fix global variable multiple definitions\n app/testpmd: fix global variable multiple definitions\n app/test-pipeline: fix global variable multiple definitions\n test: fix global variable multiple definitions\n\n app/test-pipeline/config.c | 2 +-\n app/test-pmd/cmdline_flow.c | 77 +++++++++++++++----\n app/test-pmd/testpmd.c | 35 ---------\n app/test-pmd/testpmd.h | 18 +++--\n app/test/test_bitratestats.c | 6 +-\n app/test/test_distributor_perf.c | 2 +-\n app/test/test_efd.c | 2 +-\n app/test/test_efd_perf.c | 6 +-\n app/test/test_hash_perf.c | 12 +--\n app/test/test_hash_readwrite_lf.c | 8 +-\n app/test/test_latencystats.c | 6 +-\n app/test/test_member_perf.c | 16 ++--\n app/test/test_rcu_qsbr.c | 10 +--\n drivers/bus/fslmc/qbman/qbman_portal.c | 2 +\n drivers/bus/fslmc/qbman/qbman_portal.h | 2 +-\n drivers/common/cpt/cpt_pmd_logs.h | 2 +-\n drivers/compress/octeontx/otx_zip.h | 2 +-\n drivers/compress/octeontx/otx_zip_pmd.c | 2 +\n drivers/crypto/caam_jr/caam_jr.c | 5 +-\n drivers/crypto/caam_jr/caam_jr_hw.c | 3 +\n drivers/crypto/caam_jr/caam_jr_uio.c | 3 +\n drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 5 +-\n drivers/crypto/dpaa2_sec/hw/rta.h | 1 -\n .../dpaa2_sec/hw/rta/fifo_load_store_cmd.h | 2 -\n drivers/crypto/dpaa2_sec/hw/rta/header_cmd.h | 2 -\n drivers/crypto/dpaa2_sec/hw/rta/jump_cmd.h | 2 -\n drivers/crypto/dpaa2_sec/hw/rta/key_cmd.h | 2 -\n drivers/crypto/dpaa2_sec/hw/rta/load_cmd.h | 2 -\n drivers/crypto/dpaa2_sec/hw/rta/math_cmd.h | 2 -\n drivers/crypto/dpaa2_sec/hw/rta/move_cmd.h | 2 -\n drivers/crypto/dpaa2_sec/hw/rta/nfifo_cmd.h | 2 -\n .../crypto/dpaa2_sec/hw/rta/operation_cmd.h | 2 -\n .../crypto/dpaa2_sec/hw/rta/protocol_cmd.h | 2 -\n .../dpaa2_sec/hw/rta/seq_in_out_ptr_cmd.h | 2 -\n drivers/crypto/dpaa2_sec/hw/rta/store_cmd.h | 2 -\n drivers/crypto/dpaa_sec/dpaa_sec.c | 5 +-\n drivers/crypto/null/null_crypto_pmd.c | 1 +\n drivers/crypto/null/null_crypto_pmd_private.h | 2 +-\n drivers/crypto/octeontx/otx_cryptodev.c | 2 +\n drivers/crypto/octeontx/otx_cryptodev.h | 2 +-\n drivers/crypto/virtio/virtio_pci.c | 4 +-\n drivers/crypto/virtio/virtio_pci.h | 6 +-\n drivers/net/e1000/e1000_ethdev.h | 12 +--\n drivers/net/e1000/igb_flow.c | 7 ++\n 44 files changed, 151 insertions(+), 141 deletions(-)", "diff": null, "prefixes": [ "00/10" ] }