Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/58631/?format=api
{ "id": 58631, "url": "http://patches.dpdk.org/api/patches/58631/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190905093239.27187-7-amo@semihalf.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190905093239.27187-7-amo@semihalf.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190905093239.27187-7-amo@semihalf.com", "date": "2019-09-05T09:32:35", "name": "[06/10] net/dpaa2: fix possible use of uninitialized vars", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d3f49597d01259cde6b58b9033fe98e13b52ca57", "submitter": { "id": 1112, "url": "http://patches.dpdk.org/api/people/1112/?format=api", "name": "Andrzej Ostruszka", "email": "amo@semihalf.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190905093239.27187-7-amo@semihalf.com/mbox/", "series": [ { "id": 6250, "url": "http://patches.dpdk.org/api/series/6250/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6250", "date": "2019-09-05T09:32:29", "name": "Add an option to use LTO for DPDK build", "version": 1, "mbox": "http://patches.dpdk.org/series/6250/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/58631/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/58631/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 14D591EF3E;\n\tThu, 5 Sep 2019 11:32:57 +0200 (CEST)", "from mail-lj1-f195.google.com (mail-lj1-f195.google.com\n\t[209.85.208.195]) by dpdk.org (Postfix) with ESMTP id 836111EDED\n\tfor <dev@dpdk.org>; Thu, 5 Sep 2019 11:32:45 +0200 (CEST)", "by mail-lj1-f195.google.com with SMTP id a4so1697032ljk.8\n\tfor <dev@dpdk.org>; Thu, 05 Sep 2019 02:32:45 -0700 (PDT)", "from localhost.localdomain (31-172-191-173.noc.fibertech.net.pl.\n\t[31.172.191.173]) by smtp.googlemail.com with ESMTPSA id\n\tb25sm363060lfa.90.2019.09.05.02.32.44\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 05 Sep 2019 02:32:44 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=semihalf-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=bK9nl/qV04wjIKeztaLOLubH2UF/0ajtfJqFha0o/9s=;\n\tb=ARDOlnys48Lb+0hMvm7qqu8QlowKGjcOdiP3knBHbW+sn1mJOdVzRBYovpLXWOxZ+9\n\t/wYBTlfkk+i1hXRmiSEENiU3Lgm3xmkbBhkJSGwuv4RdwQgmaGMHY+63ncBvmm0sazGk\n\thh9fBMs4o1AO0/W6bF7swWww3RGTPtzdlvD1UnBg1KNI7qSBNcTVhwWapoayPOJTnuu+\n\t3rK/UIVJa/nNNbrlbfUUyf7ZcWXUSfGkOTSDg/VhBqJpRLuqZvFZkGx6scLXr1P30CJ6\n\tkhxwAa1oexXFs9R15sR2a7fn2WOa9AYkfJlUy/FUDha8WmCTDlRVGnwza1QJmKoCIT/J\n\tnDaw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=bK9nl/qV04wjIKeztaLOLubH2UF/0ajtfJqFha0o/9s=;\n\tb=LSqlxFulL4AcAAVsKIEP3shR4OJbDpR4jMcagjb5AzqEm8qRh7bbkDczKHfbybCSRB\n\tdxK/FfzAnwsT5tVcN3hBoybLTGImN6KsA6IS6G6LaK8MilOjYTCtprXEVTF8Ojv/Q5Wj\n\tSUqGteX+lTvnu57LrsZ1iWdF7ZAEGZ9o4NuT1QmuQSlc1o+OPmhRQAQ+SyFm/9Ve2jLc\n\tfFicuOc5mevLXftOhnaUkQMIQuZWQqDCswH33Og+ay0kxZ1u4ooCkuSUi9zx0rypT8im\n\txaGiHMIwn0jH6wnXvxzB4SQuefq9x3Ph5tZNj/SDKZsCp8k/vcyY5fNp0zotgFIUoXbM\n\t6WZw==", "X-Gm-Message-State": "APjAAAU15e7sAWBuPb92o75c43ZTgLqV4Wq21j1gAaWl/8+DOAKH83Xk\n\tE75LWOip/WaFxFJMYKKFxWJgkQwG+fgS0g==", "X-Google-Smtp-Source": "APXvYqzPkdwFIYUNzdFG7/poSvhFzGegjOsQA9cPX6sIa2w+vHI+wQqJMd1sJWTsoOZYLYAGIQSqWw==", "X-Received": "by 2002:a2e:7502:: with SMTP id q2mr1360853ljc.202.1567675965100;\n\tThu, 05 Sep 2019 02:32:45 -0700 (PDT)", "From": "Andrzej Ostruszka <amo@semihalf.com>", "To": "dev@dpdk.org", "Cc": "Andrzej Ostruszka <aostruszka@marvell.com>", "Date": "Thu, 5 Sep 2019 11:32:35 +0200", "Message-Id": "<20190905093239.27187-7-amo@semihalf.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20190905093239.27187-1-amo@semihalf.com>", "References": "<20190905093239.27187-1-amo@semihalf.com>", "Subject": "[dpdk-dev] [PATCH 06/10] net/dpaa2: fix possible use of\n\tuninitialized vars", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch fixes 'maybe-uninitialized' warnings reported by compiler\nwhen using LTO.\n\nSigned-off-by: Andrzej Ostruszka <aostruszka@marvell.com>\n---\n drivers/net/dpaa2/base/dpaa2_hw_dpni.c | 1 +\n drivers/net/dpaa2/mc/dpkg.c | 2 +-\n drivers/net/dpaa2/mc/dpni.c | 9 ++++++---\n 3 files changed, 8 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/dpaa2/base/dpaa2_hw_dpni.c b/drivers/net/dpaa2/base/dpaa2_hw_dpni.c\nindex 56e2e56a3..2f6534a31 100644\n--- a/drivers/net/dpaa2/base/dpaa2_hw_dpni.c\n+++ b/drivers/net/dpaa2/base/dpaa2_hw_dpni.c\n@@ -51,6 +51,7 @@ rte_pmd_dpaa2_set_custom_hash(uint16_t port_id,\n \tkg_cfg.extracts[0].type = DPKG_EXTRACT_FROM_DATA;\n \tkg_cfg.extracts[0].extract.from_data.offset = offset;\n \tkg_cfg.extracts[0].extract.from_data.size = size;\n+\tkg_cfg.extracts[0].num_of_byte_masks = 0;\n \tkg_cfg.num_extracts = 1;\n \n \tret = dpkg_prepare_key_cfg(&kg_cfg, p_params);\ndiff --git a/drivers/net/dpaa2/mc/dpkg.c b/drivers/net/dpaa2/mc/dpkg.c\nindex 80f94f40e..7aa63ea12 100644\n--- a/drivers/net/dpaa2/mc/dpkg.c\n+++ b/drivers/net/dpaa2/mc/dpkg.c\n@@ -63,7 +63,7 @@ dpkg_prepare_key_cfg(const struct dpkg_profile_cfg *cfg, uint8_t *key_cfg_buf)\n \t\tdpkg_set_field(extr->extract_type, EXTRACT_TYPE,\n \t\t\t cfg->extracts[i].type);\n \n-\t\tfor (j = 0; j < DPKG_NUM_OF_MASKS; j++) {\n+\t\tfor (j = 0; j < extr->num_of_byte_masks; j++) {\n \t\t\textr->masks[j].mask = cfg->extracts[i].masks[j].mask;\n \t\t\textr->masks[j].offset =\n \t\t\t\tcfg->extracts[i].masks[j].offset;\ndiff --git a/drivers/net/dpaa2/mc/dpni.c b/drivers/net/dpaa2/mc/dpni.c\nindex 362cd476f..b74a1a317 100644\n--- a/drivers/net/dpaa2/mc/dpni.c\n+++ b/drivers/net/dpaa2/mc/dpni.c\n@@ -1803,10 +1803,13 @@ int dpni_set_congestion_notification(struct fsl_mc_io *mc_io,\n \tcmd_params->qtype = qtype;\n \tcmd_params->tc = tc_id;\n \tcmd_params->congestion_point = cfg->cg_point;\n-\tcmd_params->cgid = (uint8_t)cfg->cgid;\n-\tcmd_params->dest_id = cpu_to_le32(cfg->dest_cfg.dest_id);\n+\tif (cfg->cg_point == DPNI_CP_CONGESTION_GROUP)\n+\t\tcmd_params->cgid = (uint8_t)cfg->cgid;\n+\tif (cfg->dest_cfg.dest_type != DPNI_DEST_NONE) {\n+\t\tcmd_params->dest_id = cpu_to_le32(cfg->dest_cfg.dest_id);\n+\t\tcmd_params->dest_priority = cfg->dest_cfg.priority;\n+\t}\n \tcmd_params->notification_mode = cpu_to_le16(cfg->notification_mode);\n-\tcmd_params->dest_priority = cfg->dest_cfg.priority;\n \tcmd_params->message_iova = cpu_to_le64(cfg->message_iova);\n \tcmd_params->message_ctx = cpu_to_le64(cfg->message_ctx);\n \tcmd_params->threshold_entry = cpu_to_le32(cfg->threshold_entry);\n", "prefixes": [ "06/10" ] }