Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/58428/?format=api
{ "id": 58428, "url": "http://patches.dpdk.org/api/patches/58428/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190903021901.25895-7-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190903021901.25895-7-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190903021901.25895-7-ajit.khaparde@broadcom.com", "date": "2019-09-03T02:18:50", "name": "[06/17] net/bnxt: parse priority attribute for flow creation", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "b4a838df5c9aba2645b6ca3bd3ed4d816fbb40ad", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190903021901.25895-7-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 6209, "url": "http://patches.dpdk.org/api/series/6209/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6209", "date": "2019-09-03T02:18:44", "name": "bnxt patchset to improve rte flow support", "version": 1, "mbox": "http://patches.dpdk.org/series/6209/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/58428/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/58428/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 18FCA1EAE6;\n\tTue, 3 Sep 2019 04:19:24 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n\t[192.19.229.170]) by dpdk.org (Postfix) with ESMTP id 832881E8D5\n\tfor <dev@dpdk.org>; Tue, 3 Sep 2019 04:19:08 +0200 (CEST)", "from nis-sj1-27.broadcom.com (nis-sj1-27.lvn.broadcom.net\n\t[10.75.144.136])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 040DD30C1F3;\n\tMon, 2 Sep 2019 19:19:01 -0700 (PDT)", "from localhost.localdomain (unknown [10.230.30.225])\n\tby nis-sj1-27.broadcom.com (Postfix) with ESMTP id 163C6AC06AB;\n\tMon, 2 Sep 2019 19:19:07 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 040DD30C1F3", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1567477141;\n\tbh=jDRQO4Ttf94x8W+sYBrtuFHwWPuMKzMAvg2ouQtbXF0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=cfkGvM9xOBqxwfloUue8sF8v9UOwc8Ddjj0tzuWwVun5Eqmx0YGCCxdKkBc01CYW/\n\tCXKc5idC4LgPIj63Z8FWbbYwSlROx3E6zf1StzjBjgWxWbxhn3yHAGpcFkAtiA/o76\n\t6iZCke+8YYIv+bSpAt5XaO+46eFDKKXf5frqFPy8=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, Rahul Gupta <rahul.gupta@broadcom.com>,\n\tLance Richardson <lance.richardson@broadcom.com>", "Date": "Mon, 2 Sep 2019 19:18:50 -0700", "Message-Id": "<20190903021901.25895-7-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.20.1 (Apple Git-117)", "In-Reply-To": "<20190903021901.25895-1-ajit.khaparde@broadcom.com>", "References": "<20190903021901.25895-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 06/17] net/bnxt: parse priority attribute for\n\tflow creation", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Parse priority attribute during flow creation.\nThis information will be used to give a hint to the FW to\nplace the flow rule accordingly in the CFA tables.\n\nReviewed-by: Rahul Gupta <rahul.gupta@broadcom.com>\nReviewed-by: Lance Richardson <lance.richardson@broadcom.com>\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_filter.h | 1 +\n drivers/net/bnxt/bnxt_flow.c | 25 +++++++++++--------------\n 2 files changed, 12 insertions(+), 14 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_filter.h b/drivers/net/bnxt/bnxt_filter.h\nindex 52d3582ba..bcb9d6031 100644\n--- a/drivers/net/bnxt/bnxt_filter.h\n+++ b/drivers/net/bnxt/bnxt_filter.h\n@@ -66,6 +66,7 @@ struct bnxt_filter_info {\n \tuint16_t ip_protocol;\n \tuint16_t ip_addr_type;\n \tuint16_t ethertype;\n+\tuint32_t\t\tpriority;\n };\n \n struct bnxt_filter_info *bnxt_alloc_filter(struct bnxt *bp);\ndiff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c\nindex 1328f25bc..2d107a892 100644\n--- a/drivers/net/bnxt/bnxt_flow.c\n+++ b/drivers/net/bnxt/bnxt_flow.c\n@@ -225,6 +225,9 @@ bnxt_validate_and_parse_flow_type(struct bnxt *bp,\n \t\t\t\tvalid_flags |= inner ?\n \t\t\t\t\tBNXT_FLOW_L2_INNER_DST_VALID_FLAG :\n \t\t\t\t\tBNXT_FLOW_L2_DST_VALID_FLAG;\n+\t\t\t\tfilter->priority = attr->priority;\n+\t\t\t\tPMD_DRV_LOG(DEBUG,\n+\t\t\t\t\t \"Creating a priority flow\\n\");\n \t\t\t}\n \n \t\t\tif (rte_is_broadcast_ether_addr(ð_mask->src)) {\n@@ -710,15 +713,6 @@ bnxt_flow_parse_attr(const struct rte_flow_attr *attr,\n \t\treturn -rte_errno;\n \t}\n \n-\t/* Not supported */\n-\tif (attr->priority) {\n-\t\trte_flow_error_set(error,\n-\t\t\t\t EINVAL,\n-\t\t\t\t RTE_FLOW_ERROR_TYPE_ATTR_PRIORITY,\n-\t\t\t\t attr,\n-\t\t\t\t \"No support for priority.\");\n-\t\treturn -rte_errno;\n-\t}\n \treturn 0;\n }\n \n@@ -764,13 +758,16 @@ bnxt_get_l2_filter(struct bnxt *bp, struct bnxt_filter_info *nf,\n \t\tmemcpy(filter1->l2_addr, nf->dst_macaddr, RTE_ETHER_ADDR_LEN);\n \t}\n \n-\tif (nf->valid_flags & BNXT_FLOW_L2_DST_VALID_FLAG ||\n-\t nf->valid_flags & BNXT_FLOW_L2_INNER_DST_VALID_FLAG) {\n+\tif (nf->priority &&\n+\t (nf->valid_flags & BNXT_FLOW_L2_DST_VALID_FLAG ||\n+\t nf->valid_flags & BNXT_FLOW_L2_INNER_DST_VALID_FLAG)) {\n \t\t/* Tell the FW where to place the filter in the table. */\n-\t\tfilter1->pri_hint =\n+\t\tif (nf->priority > 65535) {\n+\t\t\tfilter1->pri_hint =\n \t\t\tHWRM_CFA_L2_FILTER_ALLOC_INPUT_PRI_HINT_BELOW_FILTER;\n-\t\t/* This will place the filter in TCAM */\n-\t\tfilter1->l2_filter_id_hint = (uint64_t)-1;\n+\t\t\t/* This will place the filter in TCAM */\n+\t\t\tfilter1->l2_filter_id_hint = (uint64_t)-1;\n+\t\t}\n \t}\n \n \tfilter1->enables = HWRM_CFA_L2_FILTER_ALLOC_INPUT_ENABLES_L2_ADDR |\n", "prefixes": [ "06/17" ] }