Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/58387/?format=api
{ "id": 58387, "url": "http://patches.dpdk.org/api/patches/58387/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190902121734.926-8-akhil.goyal@nxp.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190902121734.926-8-akhil.goyal@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190902121734.926-8-akhil.goyal@nxp.com", "date": "2019-09-02T12:17:21", "name": "[07/20] crypto/dpaa2_sec/hw: update 12bit SN desc for null auth for ERA8", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e1c8754f57fb4a0519aa173648196ef885ae3fe0", "submitter": { "id": 517, "url": "http://patches.dpdk.org/api/people/517/?format=api", "name": "Akhil Goyal", "email": "akhil.goyal@nxp.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190902121734.926-8-akhil.goyal@nxp.com/mbox/", "series": [ { "id": 6199, "url": "http://patches.dpdk.org/api/series/6199/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6199", "date": "2019-09-02T12:17:14", "name": "crypto/dpaaX_sec: Support Wireless algos", "version": 1, "mbox": "http://patches.dpdk.org/series/6199/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/58387/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/58387/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 82D731E911;\n\tMon, 2 Sep 2019 14:32:24 +0200 (CEST)", "from inva020.nxp.com (inva020.nxp.com [92.121.34.13])\n\tby dpdk.org (Postfix) with ESMTP id B6A601C43F\n\tfor <dev@dpdk.org>; Mon, 2 Sep 2019 14:32:05 +0200 (CEST)", "from inva020.nxp.com (localhost [127.0.0.1])\n\tby inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 9AB041A069C;\n\tMon, 2 Sep 2019 14:32:05 +0200 (CEST)", "from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com\n\t[165.114.16.14])\n\tby inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 65BD91A0649;\n\tMon, 2 Sep 2019 14:32:03 +0200 (CEST)", "from GDB1.ap.freescale.net (GDB1.ap.freescale.net [10.232.132.179])\n\tby invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id 3A3614031C;\n\tMon, 2 Sep 2019 20:32:00 +0800 (SGT)" ], "From": "Akhil Goyal <akhil.goyal@nxp.com>", "To": "dev@dpdk.org", "Cc": "hemant.agrawal@nxp.com, vakul.garg@nxp.com,\n\tAkhil Goyal <akhil.goyal@nxp.com>", "Date": "Mon, 2 Sep 2019 17:47:21 +0530", "Message-Id": "<20190902121734.926-8-akhil.goyal@nxp.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20190902121734.926-1-akhil.goyal@nxp.com>", "References": "<20190902121734.926-1-akhil.goyal@nxp.com>", "X-Virus-Scanned": "ClamAV using ClamSMTP", "Subject": "[dpdk-dev] [PATCH 07/20] crypto/dpaa2_sec/hw: update 12bit SN desc\n\tfor null auth for ERA8", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "For sec era 8, NULL auth using protocol command does not add\n4 bytes of null MAC-I and treat NULL integrity as no integrity which\nis not correct.\nHence converting this particular case of null integrity on 12b SN\non SEC ERA 8 from protocol offload to non-protocol offload case.\n\nSigned-off-by: Akhil Goyal <akhil.goyal@nxp.com>\nSigned-off-by: Vakul Garg <vakul.garg@nxp.com>\nAcked-by: Akhil Goyal <akhil.goyal@nxp.com>\n---\n drivers/crypto/dpaa2_sec/hw/desc/pdcp.h | 32 +++++++++++++++++++++----\n 1 file changed, 28 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/crypto/dpaa2_sec/hw/desc/pdcp.h b/drivers/crypto/dpaa2_sec/hw/desc/pdcp.h\nindex 4bf1d69f9..0b074ec80 100644\n--- a/drivers/crypto/dpaa2_sec/hw/desc/pdcp.h\n+++ b/drivers/crypto/dpaa2_sec/hw/desc/pdcp.h\n@@ -43,6 +43,14 @@\n #define PDCP_C_PLANE_SN_MASK\t\t0x1F000000\n #define PDCP_C_PLANE_SN_MASK_BE\t\t0x0000001F\n \n+/**\n+ * PDCP_12BIT_SN_MASK - This mask is used in the PDCP descriptors for\n+ * extracting the sequence number (SN) from the\n+ * PDCP User Plane header.\n+ */\n+#define PDCP_12BIT_SN_MASK\t\t0xFF0F0000\n+#define PDCP_12BIT_SN_MASK_BE\t\t0x00000FFF\n+\n /**\n * PDCP_U_PLANE_15BIT_SN_MASK - This mask is used in the PDCP descriptors for\n * extracting the sequence number (SN) from the\n@@ -776,8 +784,10 @@ pdcp_insert_cplane_enc_only_op(struct program *p,\n \tKEY(p, KEY1, cipherdata->key_enc_flags, cipherdata->key,\n \t cipherdata->keylen, INLINE_KEY(cipherdata));\n \n-\tif ((rta_sec_era >= RTA_SEC_ERA_8 && sn_size != PDCP_SN_SIZE_18) ||\n-\t\t(rta_sec_era == RTA_SEC_ERA_10)) {\n+\tif ((rta_sec_era >= RTA_SEC_ERA_8 && sn_size != PDCP_SN_SIZE_18 &&\n+\t\t\t!(rta_sec_era == RTA_SEC_ERA_8 &&\n+\t\t\t\tauthdata->algtype == 0))\n+\t\t\t|| (rta_sec_era == RTA_SEC_ERA_10)) {\n \t\tif (sn_size == PDCP_SN_SIZE_5)\n \t\t\tPROTOCOL(p, dir, OP_PCLID_LTE_PDCP_CTRL_MIXED,\n \t\t\t\t (uint16_t)cipherdata->algtype << 8);\n@@ -800,12 +810,16 @@ pdcp_insert_cplane_enc_only_op(struct program *p,\n \t\tsn_mask = (swap == false) ? PDCP_U_PLANE_18BIT_SN_MASK :\n \t\t\t\t\tPDCP_U_PLANE_18BIT_SN_MASK_BE;\n \t\tbreak;\n-\tcase PDCP_SN_SIZE_7:\n \tcase PDCP_SN_SIZE_12:\n+\t\toffset = 6;\n+\t\tlength = 2;\n+\t\tsn_mask = (swap == false) ? PDCP_12BIT_SN_MASK :\n+\t\t\t\t\tPDCP_12BIT_SN_MASK_BE;\n+\t\tbreak;\n+\tcase PDCP_SN_SIZE_7:\n \tcase PDCP_SN_SIZE_15:\n \t\tpr_err(\"Invalid sn_size for %s\\n\", __func__);\n \t\treturn -ENOTSUP;\n-\n \t}\n \n \tSEQLOAD(p, MATH0, offset, length, 0);\n@@ -2796,6 +2810,16 @@ cnstr_shdsc_pdcp_u_plane_encap(uint32_t *descbuf,\n \t\tcase PDCP_CIPHER_TYPE_AES:\n \t\tcase PDCP_CIPHER_TYPE_SNOW:\n \t\tcase PDCP_CIPHER_TYPE_NULL:\n+\t\t\tif (rta_sec_era == RTA_SEC_ERA_8 &&\n+\t\t\t\t\tauthdata && authdata->algtype == 0){\n+\t\t\t\terr = pdcp_insert_uplane_with_int_op(p, swap,\n+\t\t\t\t\t\tcipherdata, authdata,\n+\t\t\t\t\t\tsn_size, era_2_sw_hfn_ovrd,\n+\t\t\t\t\t\tOP_TYPE_ENCAP_PROTOCOL);\n+\t\t\t\tif (err)\n+\t\t\t\t\treturn err;\n+\t\t\t\tbreak;\n+\t\t\t}\n \t\t\t/* Insert auth key if requested */\n \t\t\tif (authdata && authdata->algtype) {\n \t\t\t\tKEY(p, KEY2, authdata->key_enc_flags,\n", "prefixes": [ "07/20" ] }