Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/58275/?format=api
http://patches.dpdk.org/api/patches/58275/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190829102737.13267-26-sachin.saxena@nxp.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190829102737.13267-26-sachin.saxena@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190829102737.13267-26-sachin.saxena@nxp.com", "date": "2019-08-29T10:27:32", "name": "[v2,25/30] bus/fslmc: update PA-VA dpaax library only in PA mode", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "17a33aacb5ec9a521c4339102ed692d8df0b68e8", "submitter": { "id": 1054, "url": "http://patches.dpdk.org/api/people/1054/?format=api", "name": "Sachin Saxena", "email": "sachin.saxena@nxp.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190829102737.13267-26-sachin.saxena@nxp.com/mbox/", "series": [ { "id": 6169, "url": "http://patches.dpdk.org/api/series/6169/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6169", "date": "2019-08-29T10:27:07", "name": "Enhancements and fixes in NXP dpaax drivers and fsl-mc bus", "version": 2, "mbox": "http://patches.dpdk.org/series/6169/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/58275/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/58275/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0BB371E8D0;\n\tThu, 29 Aug 2019 12:43:12 +0200 (CEST)", "from inva021.nxp.com (inva021.nxp.com [92.121.34.21])\n\tby dpdk.org (Postfix) with ESMTP id 154A31DFE8\n\tfor <dev@dpdk.org>; Thu, 29 Aug 2019 12:42:01 +0200 (CEST)", "from inva021.nxp.com (localhost [127.0.0.1])\n\tby inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id C857E200332;\n\tThu, 29 Aug 2019 12:42:00 +0200 (CEST)", "from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com\n\t[165.114.16.14])\n\tby inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id C67BD200336;\n\tThu, 29 Aug 2019 12:41:58 +0200 (CEST)", "from GDB1.ap.freescale.net (GDB1.ap.freescale.net [10.232.132.179])\n\tby invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id C5898402D7;\n\tThu, 29 Aug 2019 18:41:55 +0800 (SGT)" ], "From": "Sachin Saxena <sachin.saxena@nxp.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net,\n\tShreyansh Jain <shreyansh.jain@nxp.com>", "Date": "Thu, 29 Aug 2019 15:57:32 +0530", "Message-Id": "<20190829102737.13267-26-sachin.saxena@nxp.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20190829102737.13267-1-sachin.saxena@nxp.com>", "References": "<20190827070730.11206-1-sachin.saxena@nxp.com>\n\t<20190829102737.13267-1-sachin.saxena@nxp.com>", "X-Virus-Scanned": "ClamAV using ClamSMTP", "Subject": "[dpdk-dev] [PATCH v2 25/30] bus/fslmc: update PA-VA dpaax library\n\tonly in PA mode", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Shreyansh Jain <shreyansh.jain@nxp.com>\n\nThe address translation support for PA->VA is required only in\ncase of PA mode operation of DPDK. This was causing warning to\nbe reported on running any DPAA2 application in VA mode:\n\n Add: Incorrect entry for PA->VA Table(xxxxxxxxxx)\n Add: Lowest address: xxxxxxxxxxxx\n\nThis was caused by call to update the DPAAX table when VA mode\nwas enabled, in which case the VA==IOVA address.\n\nSigned-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>\nReviewed-by: Sachin Saxena <sachin.saxena@nxp.com>\n---\n drivers/bus/fslmc/fslmc_bus.c | 8 ++++++--\n 1 file changed, 6 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bus.c\nindex 9b2dd51c4..aa90d686f 100644\n--- a/drivers/bus/fslmc/fslmc_bus.c\n+++ b/drivers/bus/fslmc/fslmc_bus.c\n@@ -421,8 +421,11 @@ rte_fslmc_probe(void)\n \t *\n \t * Error is ignored as relevant logs are handled within dpaax and\n \t * handling for unavailable dpaax table too is transparent to caller.\n+\t *\n+\t * And, the IOVA table is only applicable in case of PA mode.\n \t */\n-\tdpaax_iova_table_populate();\n+\tif (rte_eal_iova_mode() == RTE_IOVA_PA)\n+\t\tdpaax_iova_table_populate();\n \n \tTAILQ_FOREACH(dev, &rte_fslmc_bus.device_list, next) {\n \t\tTAILQ_FOREACH(drv, &rte_fslmc_bus.driver_list, next) {\n@@ -519,7 +522,8 @@ rte_fslmc_driver_unregister(struct rte_dpaa2_driver *driver)\n \t/* Cleanup the PA->VA Translation table; From whereever this function\n \t * is called from.\n \t */\n-\tdpaax_iova_table_depopulate();\n+\tif (rte_eal_iova_mode() == RTE_IOVA_PA)\n+\t\tdpaax_iova_table_depopulate();\n \n \tTAILQ_REMOVE(&fslmc_bus->driver_list, driver, next);\n \t/* Update Bus references */\n", "prefixes": [ "v2", "25/30" ] }{ "id": 58275, "url": "