Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/58220/?format=api
{ "id": 58220, "url": "http://patches.dpdk.org/api/patches/58220/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190829080000.20806-3-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190829080000.20806-3-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190829080000.20806-3-maxime.coquelin@redhat.com", "date": "2019-08-29T07:59:47", "name": "[02/15] vhost: configure vDPA as soon as the device is ready", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "c622a587fc705189b5bcd11993162cd1ec7529a6", "submitter": { "id": 512, "url": "http://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190829080000.20806-3-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 6163, "url": "http://patches.dpdk.org/api/series/6163/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6163", "date": "2019-08-29T07:59:45", "name": "Introduce Virtio vDPA driver", "version": 1, "mbox": "http://patches.dpdk.org/series/6163/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/58220/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/58220/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5C6771D414;\n\tThu, 29 Aug 2019 10:00:26 +0200 (CEST)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id 02EEC1D16E;\n\tThu, 29 Aug 2019 10:00:24 +0200 (CEST)", "from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 5AE9759455;\n\tThu, 29 Aug 2019 08:00:23 +0000 (UTC)", "from localhost.localdomain (ovpn-112-52.ams2.redhat.com\n\t[10.36.112.52])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 01D805D6B2;\n\tThu, 29 Aug 2019 08:00:20 +0000 (UTC)" ], "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "tiwei.bie@intel.com, zhihong.wang@intel.com, amorenoz@redhat.com,\n\txiao.w.wang@intel.com, dev@dpdk.org, jfreimann@redhat.com", "Cc": "stable@dpdk.org, Maxime Coquelin <maxime.coquelin@redhat.com>,\n\txiaolong.ye@intel.com", "Date": "Thu, 29 Aug 2019 09:59:47 +0200", "Message-Id": "<20190829080000.20806-3-maxime.coquelin@redhat.com>", "In-Reply-To": "<20190829080000.20806-1-maxime.coquelin@redhat.com>", "References": "<20190829080000.20806-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.15", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]); Thu, 29 Aug 2019 08:00:23 +0000 (UTC)", "Subject": "[dpdk-dev] [PATCH 02/15] vhost: configure vDPA as soon as the\n\tdevice is ready", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "There might not have any VHOST_USER_SET_VRING_CALL requests\nsent once virtio device is ready. When it happens, the vDPA\ndevice's dev_conf() callback may never be called.\n\nFixes: 9f9014512822 (\"vhost: configure vDPA device after set vring call message\")\nCc: stable@dpdk.org\nCc: xiaolong.ye@intel.com\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n lib/librte_vhost/vhost_user.c | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)", "diff": "diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c\nindex 0b72648a5..b1ea80c52 100644\n--- a/lib/librte_vhost/vhost_user.c\n+++ b/lib/librte_vhost/vhost_user.c\n@@ -2112,8 +2112,7 @@ vhost_user_msg_handler(int vid, int fd)\n \tdid = dev->vdpa_dev_id;\n \tvdpa_dev = rte_vdpa_get_device(did);\n \tif (vdpa_dev && virtio_is_ready(dev) &&\n-\t\t\t!(dev->flags & VIRTIO_DEV_VDPA_CONFIGURED) &&\n-\t\t\tmsg.request.master == VHOST_USER_SET_VRING_CALL) {\n+\t\t\t!(dev->flags & VIRTIO_DEV_VDPA_CONFIGURED)) {\n \t\tif (vdpa_dev->ops->dev_conf)\n \t\t\tvdpa_dev->ops->dev_conf(dev->vid);\n \t\tdev->flags |= VIRTIO_DEV_VDPA_CONFIGURED;\n", "prefixes": [ "02/15" ] }