Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/58091/?format=api
http://patches.dpdk.org/api/patches/58091/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1566915962-5472-51-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1566915962-5472-51-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1566915962-5472-51-git-send-email-arybchenko@solarflare.com", "date": "2019-08-27T14:26:01", "name": "[50/51] examples/ethtool: check status of getting ethdev info", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "80d21d60c08bcf608e0cfb9680f87d1a922427ce", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1566915962-5472-51-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 6138, "url": "http://patches.dpdk.org/api/series/6138/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6138", "date": "2019-08-27T14:25:13", "name": "ethdev: change rte_eth_dev_info_get() return value to int", "version": 1, "mbox": "http://patches.dpdk.org/series/6138/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/58091/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/58091/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 40E7C1D451;\n\tTue, 27 Aug 2019 16:28:11 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[67.231.154.164]) by dpdk.org (Postfix) with ESMTP id D3EC21C1E1\n\tfor <dev@dpdk.org>; Tue, 27 Aug 2019 16:26:46 +0200 (CEST)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us4.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n\t07C48140063; Tue, 27 Aug 2019 14:26:46 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1395.4; Tue, 27 Aug 2019 07:26:27 -0700", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1395.4 via Frontend Transport; Tue, 27 Aug 2019 07:26:27 -0700", "from ukv-loginhost.uk.solarflarecom.com\n\t(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tx7REQQxQ004299; Tue, 27 Aug 2019 15:26:26 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n\tby ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id\n\t5349A1613D1; Tue, 27 Aug 2019 15:26:26 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "Marko Kovacevic <marko.kovacevic@intel.com>, Ori Kam <orika@mellanox.com>,\n\tBruce Richardson <bruce.richardson@intel.com>, Pablo de Lara\n\t<pablo.de.lara.guarch@intel.com>, Radu Nicolau <radu.nicolau@intel.com>, \n\tAkhil Goyal <akhil.goyal@nxp.com>, Tomasz Kantecki\n\t<tomasz.kantecki@intel.com>", "CC": "<dev@dpdk.org>, Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>", "Date": "Tue, 27 Aug 2019 15:26:01 +0100", "Message-ID": "<1566915962-5472-51-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1566915962-5472-1-git-send-email-arybchenko@solarflare.com>", "References": "<1566915962-5472-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.5.1010-24872.005", "X-TM-AS-Result": "No-3.860000-4.000000-10", "X-TMASE-MatchedRID": "cxaTYRzWUivDOgXZFRFV8+b3p4cnIXGNAPiR4btCEeZ+SLLtNOiBhvFo\n\tO2munXhOyOrHSvvEufhw5T4Iaj538mJZXQNDzktSGjzBgnFZvQ5KgIbix5+XxEFungmhsSsCUl0\n\t3SIY6fe0vNUCPMwUWx3bryR8otWaR/MSiuOz98mW8vOGpEA2TcEloPruIq9jTpzG+Ju2gKrcYp/\n\t+9ZfRvsClWwQNqTXmGSjLlYugtawofE8yM4pjsDwtuKBGekqUpm+MB6kaZ2g4WuPcekv6jjWRk5\n\tS1kRDdIAsFDU1VmZJRJFkYdJRyBvibJct4L7B93yrzP0zdJjatKyeNXacsjJpeg4vwf7AJfkQpn\n\t/aIJ+9nkA8OrYHdwDGfYlY/yoV/0Up6EHOb2+c7kHZDO53QSwjflzkGcoK72", "X-TM-AS-User-Approved-Sender": "No", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--3.860000-4.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.5.1010-24872.005", "X-MDID": "1566916006-8SUHR7ms-5vw", "Subject": "[dpdk-dev] [PATCH 50/51] examples/ethtool: check status of getting\n\tethdev info", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>\n\nrte_eth_dev_info_get() return value was changed from void to\nint, so this patch modify rte_eth_dev_info_get() usage across\nexamples/ethtool according to its new return type.\n\nSigned-off-by: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n examples/ethtool/ethtool-app/main.c | 8 +++++++-\n examples/ethtool/lib/rte_ethtool.c | 21 ++++++++++++++++++---\n 2 files changed, 25 insertions(+), 4 deletions(-)", "diff": "diff --git a/examples/ethtool/ethtool-app/main.c b/examples/ethtool/ethtool-app/main.c\nindex 3d2a70d..774df7e 100644\n--- a/examples/ethtool/ethtool-app/main.c\n+++ b/examples/ethtool/ethtool-app/main.c\n@@ -95,6 +95,7 @@ static void setup_ports(struct app_config *app_cfg, int cnt_ports)\n \tchar str_name[16];\n \tuint16_t nb_rxd = PORT_RX_QUEUE_SIZE;\n \tuint16_t nb_txd = PORT_TX_QUEUE_SIZE;\n+\tint ret;\n \n \tmemset(&cfg_port, 0, sizeof(cfg_port));\n \tcfg_port.txmode.mq_mode = ETH_MQ_TX_NONE;\n@@ -102,7 +103,12 @@ static void setup_ports(struct app_config *app_cfg, int cnt_ports)\n \tfor (idx_port = 0; idx_port < cnt_ports; idx_port++) {\n \t\tstruct app_port *ptr_port = &app_cfg->ports[idx_port];\n \n-\t\trte_eth_dev_info_get(idx_port, &dev_info);\n+\t\tret = rte_eth_dev_info_get(idx_port, &dev_info);\n+\t\tif (ret != 0)\n+\t\t\trte_exit(EXIT_FAILURE,\n+\t\t\t\t\"Error during getting device (port %u) info: %s\\n\",\n+\t\t\t\tidx_port, strerror(-ret));\n+\n \t\tsize_pktpool = dev_info.rx_desc_lim.nb_max +\n \t\t\tdev_info.tx_desc_lim.nb_max + PKTPOOL_EXTRA_SIZE;\n \ndiff --git a/examples/ethtool/lib/rte_ethtool.c b/examples/ethtool/lib/rte_ethtool.c\nindex 571c4e5..3954376 100644\n--- a/examples/ethtool/lib/rte_ethtool.c\n+++ b/examples/ethtool/lib/rte_ethtool.c\n@@ -42,7 +42,14 @@\n \t\t \"the minimum size should be %d\\n\", ret);\n \n \tmemset(&dev_info, 0, sizeof(dev_info));\n-\trte_eth_dev_info_get(port_id, &dev_info);\n+\n+\tret = rte_eth_dev_info_get(port_id, &dev_info);\n+\tif (ret != 0) {\n+\t\tprintf(\"Error during getting device (port %u) info: %s\\n\",\n+\t\t\t\tport_id, strerror(-ret));\n+\n+\t\treturn ret;\n+\t}\n \n \tstrlcpy(drvinfo->driver, dev_info.driver_name,\n \t\tsizeof(drvinfo->driver));\n@@ -371,9 +378,14 @@\n \tuint16_t num_vfs;\n \tstruct rte_eth_dev_info dev_info;\n \tuint16_t vf;\n+\tint ret;\n \n \tmemset(&dev_info, 0, sizeof(dev_info));\n-\trte_eth_dev_info_get(port_id, &dev_info);\n+\n+\tret = rte_eth_dev_info_get(port_id, &dev_info);\n+\tif (ret != 0)\n+\t\treturn ret;\n+\n \tnum_vfs = dev_info.max_vfs;\n \n \t/* Set VF vf_rx_mode, VF unsupport status is discard */\n@@ -399,11 +411,14 @@\n \tstruct rte_eth_rxq_info rx_qinfo;\n \tstruct rte_eth_txq_info tx_qinfo;\n \tint stat;\n+\tint ret;\n \n \tif (ring_param == NULL)\n \t\treturn -EINVAL;\n \n-\trte_eth_dev_info_get(port_id, &dev_info);\n+\tret = rte_eth_dev_info_get(port_id, &dev_info);\n+\tif (ret != 0)\n+\t\treturn ret;\n \n \tstat = rte_eth_rx_queue_info_get(port_id, 0, &rx_qinfo);\n \tif (stat != 0)\n", "prefixes": [ "50/51" ] }{ "id": 58091, "url": "