Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/58052/?format=api
{ "id": 58052, "url": "http://patches.dpdk.org/api/patches/58052/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1566915962-5472-10-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1566915962-5472-10-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1566915962-5472-10-git-send-email-arybchenko@solarflare.com", "date": "2019-08-27T14:25:20", "name": "[09/51] app/test: check status of getting ethdev info in bonding", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d60680723f54f5424fc71d75796776e63cedb0c8", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1566915962-5472-10-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 6138, "url": "http://patches.dpdk.org/api/series/6138/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6138", "date": "2019-08-27T14:25:13", "name": "ethdev: change rte_eth_dev_info_get() return value to int", "version": 1, "mbox": "http://patches.dpdk.org/series/6138/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/58052/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/58052/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D35331C1BF;\n\tTue, 27 Aug 2019 16:26:49 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 57F5C1C12A\n\tfor <dev@dpdk.org>; Tue, 27 Aug 2019 16:26:22 +0200 (CEST)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us5.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n\tBED9D40068; Tue, 27 Aug 2019 14:26:17 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1395.4; Tue, 27 Aug 2019 07:26:15 -0700", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1395.4 via Frontend Transport; Tue, 27 Aug 2019 07:26:14 -0700", "from ukv-loginhost.uk.solarflarecom.com\n\t(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tx7REQCg8004167; Tue, 27 Aug 2019 15:26:13 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n\tby ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id\n\tE1F941613D2; Tue, 27 Aug 2019 15:26:13 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "Chas Williams <chas3@att.com>", "CC": "<dev@dpdk.org>, Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>", "Date": "Tue, 27 Aug 2019 15:25:20 +0100", "Message-ID": "<1566915962-5472-10-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1566915962-5472-1-git-send-email-arybchenko@solarflare.com>", "References": "<1566915962-5472-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.5.1010-24872.005", "X-TM-AS-Result": "No-2.576400-4.000000-10", "X-TMASE-MatchedRID": "qkiRFh4owgU8UztDKMPiNn4neC0h7SADY/L2/AZJAWSYkF7ZtFfCU0kx\n\tAPClfhN0ezYFSWzv4AiPQi9XuOWoOIG9V0kqQ2uQimHWEC28pk1+jSWdx0YUU+D3XFrJfgvzILZ\n\t66KAKcu8SndgYhkle2blbD6rjGES/7PE1ojYEvaEHtOpEBhWiFkkQGNGmCuF4myiLZetSf8mfop\n\t0ytGwvXiq2rl3dzGQ1Sftcc/gfizpQ6eumfqwoCO8339yS8nUhIAlBofDWyFm2NFyMwAehFEspv\n\tmXV5SvbqrYTXId556lvx/RO84qSocfZv0sv4r2pQK3Ij3iKlkU4oGQUCbwY5Q+g7mdwjo656FtD\n\tZCmYBJ1ty4Dch3o7okMMprcbiest", "X-TM-AS-User-Approved-Sender": "No", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--2.576400-4.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.5.1010-24872.005", "X-MDID": "1566915978-kyKSPLBVeilV", "Subject": "[dpdk-dev] [PATCH 09/51] app/test: check status of getting ethdev\n\tinfo in bonding", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>\n\nrte_eth_dev_info_get() return value was changed from void to int,\nso this patch modify rte_eth_dev_info_get() usage across\napp/test/test_link_bonding_rssconf.c according to its new return type.\n\nSigned-off-by: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n app/test/test_link_bonding_rssconf.c | 33 ++++++++++++++++++++++++++++-----\n 1 file changed, 28 insertions(+), 5 deletions(-)", "diff": "diff --git a/app/test/test_link_bonding_rssconf.c b/app/test/test_link_bonding_rssconf.c\nindex 65de3b9..1a9571e 100644\n--- a/app/test/test_link_bonding_rssconf.c\n+++ b/app/test/test_link_bonding_rssconf.c\n@@ -329,7 +329,11 @@ struct link_bonding_rssconf_unittest_params {\n \tuint64_t rss_hf = 0;\n \tuint64_t default_rss_hf = 0;\n \n-\trte_eth_dev_info_get(test_params.bond_port_id, &test_params.bond_dev_info);\n+\tretval = rte_eth_dev_info_get(test_params.bond_port_id,\n+\t\t\t\t\t\t&test_params.bond_dev_info);\n+\tTEST_ASSERT((retval == 0),\n+\t\t\t\"Error during getting device (port %u) info: %s\\n\",\n+\t\t\ttest_params.bond_port_id, strerror(-retval));\n \n \t/*\n \t * Test hash function propagation\n@@ -443,10 +447,16 @@ struct link_bonding_rssconf_unittest_params {\n \t/**\n \t * Configure bonding port in RSS mq mode\n \t */\n+\tint ret;\n+\n \tTEST_ASSERT_SUCCESS(configure_ethdev(test_params.bond_port_id,\n \t\t\t&rss_pmd_conf, 0), \"Failed to configure bonding device\\n\");\n \n-\trte_eth_dev_info_get(test_params.bond_port_id, &test_params.bond_dev_info);\n+\tret = rte_eth_dev_info_get(test_params.bond_port_id,\n+\t\t\t\t\t&test_params.bond_dev_info);\n+\tTEST_ASSERT((ret == 0),\n+\t\t\t\"Error during getting device (port %u) info: %s\\n\",\n+\t\t\ttest_params.bond_port_id, strerror(-ret));\n \n \tTEST_ASSERT_SUCCESS(bond_slaves(), \"Bonding slaves failed\");\n \n@@ -468,10 +478,16 @@ struct link_bonding_rssconf_unittest_params {\n static int\n test_rss_lazy(void)\n {\n+\tint ret;\n+\n \tTEST_ASSERT_SUCCESS(configure_ethdev(test_params.bond_port_id,\n \t\t\t&default_pmd_conf, 0), \"Failed to configure bonding device\\n\");\n \n-\trte_eth_dev_info_get(test_params.bond_port_id, &test_params.bond_dev_info);\n+\tret = rte_eth_dev_info_get(test_params.bond_port_id,\n+\t\t\t\t\t\t&test_params.bond_dev_info);\n+\tTEST_ASSERT((ret == 0),\n+\t\t\t\"Error during getting device (port %u) info: %s\\n\",\n+\t\t\ttest_params.bond_port_id, strerror(-ret));\n \n \tTEST_ASSERT_SUCCESS(bond_slaves(), \"Bonding slaves failed\");\n \n@@ -532,6 +548,10 @@ struct link_bonding_rssconf_unittest_params {\n \t\trte_eth_dev_default_mac_addr_set(port->port_id, &mac_addr);\n \n \t\trte_eth_dev_info_get(port->port_id, &port->dev_info);\n+\t\tretval = rte_eth_dev_info_get(port->port_id, &port->dev_info);\n+\t\tTEST_ASSERT((retval == 0),\n+\t\t\t\t\"Error during getting device (port %u) info: %s\\n\",\n+\t\t\t\ttest_params.bond_port_id, strerror(-retval));\n \t}\n \n \tif (test_params.bond_port_id == INVALID_PORT_ID) {\n@@ -545,8 +565,11 @@ struct link_bonding_rssconf_unittest_params {\n \t\tTEST_ASSERT_SUCCESS(configure_ethdev(test_params.bond_port_id,\n \t\t\t\t&default_pmd_conf, 0), \"Failed to configure bonding device\\n\");\n \n-\t\trte_eth_dev_info_get(test_params.bond_port_id,\n-\t\t\t\t&test_params.bond_dev_info);\n+\t\tretval = rte_eth_dev_info_get(test_params.bond_port_id,\n+\t\t\t\t\t\t&test_params.bond_dev_info);\n+\t\tTEST_ASSERT((retval == 0),\n+\t\t\t\t\"Error during getting device (port %u) info: %s\\n\",\n+\t\t\t\ttest_params.bond_port_id, strerror(-retval));\n \t}\n \n \treturn TEST_SUCCESS;\n", "prefixes": [ "09/51" ] }