Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/57998/?format=api
{ "id": 57998, "url": "http://patches.dpdk.org/api/patches/57998/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190827070730.11206-4-sachin.saxena@nxp.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190827070730.11206-4-sachin.saxena@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190827070730.11206-4-sachin.saxena@nxp.com", "date": "2019-08-27T07:07:03", "name": "[v1,03/30] bus/dpaa: remove un-necessary thread affinity", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "14e3dd9edec49671d1423cc9ae64bc39d349cb6a", "submitter": { "id": 1054, "url": "http://patches.dpdk.org/api/people/1054/?format=api", "name": "Sachin Saxena", "email": "sachin.saxena@nxp.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190827070730.11206-4-sachin.saxena@nxp.com/mbox/", "series": [ { "id": 6130, "url": "http://patches.dpdk.org/api/series/6130/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6130", "date": "2019-08-27T07:07:00", "name": "Enhancements and fixes in NXP dpaax drivers and fsl-mc bus", "version": 1, "mbox": "http://patches.dpdk.org/series/6130/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/57998/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/57998/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 52DD01BFC6;\n\tTue, 27 Aug 2019 09:09:22 +0200 (CEST)", "from inva021.nxp.com (inva021.nxp.com [92.121.34.21])\n\tby dpdk.org (Postfix) with ESMTP id 5383E1BF7D\n\tfor <dev@dpdk.org>; Tue, 27 Aug 2019 09:09:16 +0200 (CEST)", "from inva021.nxp.com (localhost [127.0.0.1])\n\tby inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id E1D08200131;\n\tTue, 27 Aug 2019 09:09:15 +0200 (CEST)", "from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com\n\t[165.114.16.14])\n\tby inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 9EFB92005C6;\n\tTue, 27 Aug 2019 09:09:13 +0200 (CEST)", "from bf-netperf1.ap.freescale.net (bf-netperf1.ap.freescale.net\n\t[10.232.133.63])\n\tby invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id 20F5A402EB;\n\tTue, 27 Aug 2019 15:09:10 +0800 (SGT)" ], "From": "Sachin Saxena <sachin.saxena@nxp.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net,\n\tNipun Gupta <nipun.gupta@nxp.com>", "Date": "Tue, 27 Aug 2019 12:37:03 +0530", "Message-Id": "<20190827070730.11206-4-sachin.saxena@nxp.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20190827070730.11206-1-sachin.saxena@nxp.com>", "References": "<20190827070730.11206-1-sachin.saxena@nxp.com>", "X-Virus-Scanned": "ClamAV using ClamSMTP", "Subject": "[dpdk-dev] [PATCH v1 03/30] bus/dpaa: remove un-necessary thread\n\taffinity", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Nipun Gupta <nipun.gupta@nxp.com>\n\nThread affinity is already taken care by DPDK. Remove them from bus.\n\nSigned-off-by: Nipun Gupta <nipun.gupta@nxp.com>\n---\n drivers/bus/dpaa/base/qbman/qman_driver.c | 56 ++---------------------\n drivers/bus/dpaa/dpaa_bus.c | 13 ------\n 2 files changed, 3 insertions(+), 66 deletions(-)", "diff": "diff --git a/drivers/bus/dpaa/base/qbman/qman_driver.c b/drivers/bus/dpaa/base/qbman/qman_driver.c\nindex ba153396d..5c773669a 100644\n--- a/drivers/bus/dpaa/base/qbman/qman_driver.c\n+++ b/drivers/bus/dpaa/base/qbman/qman_driver.c\n@@ -1,7 +1,7 @@\n /* SPDX-License-Identifier: (BSD-3-Clause OR GPL-2.0)\n *\n * Copyright 2008-2016 Freescale Semiconductor Inc.\n- * Copyright 2017 NXP\n+ * Copyright 2017,2019 NXP\n *\n */\n \n@@ -32,31 +32,9 @@ static __thread struct dpaa_ioctl_portal_map map = {\n \n static int fsl_qman_portal_init(uint32_t index, int is_shared)\n {\n-\tcpu_set_t cpuset;\n \tstruct qman_portal *portal;\n-\tint loop, ret;\n \tstruct dpaa_ioctl_irq_map irq_map;\n-\n-\t/* Verify the thread's cpu-affinity */\n-\tret = pthread_getaffinity_np(pthread_self(), sizeof(cpu_set_t),\n-\t\t\t\t &cpuset);\n-\tif (ret) {\n-\t\terror(0, ret, \"pthread_getaffinity_np()\");\n-\t\treturn ret;\n-\t}\n-\tqpcfg.cpu = -1;\n-\tfor (loop = 0; loop < CPU_SETSIZE; loop++)\n-\t\tif (CPU_ISSET(loop, &cpuset)) {\n-\t\t\tif (qpcfg.cpu != -1) {\n-\t\t\t\tpr_err(\"Thread is not affine to 1 cpu\\n\");\n-\t\t\t\treturn -EINVAL;\n-\t\t\t}\n-\t\t\tqpcfg.cpu = loop;\n-\t\t}\n-\tif (qpcfg.cpu == -1) {\n-\t\tpr_err(\"Bug in getaffinity handling!\\n\");\n-\t\treturn -EINVAL;\n-\t}\n+\tint ret;\n \n \t/* Allocate and map a qman portal */\n \tmap.index = index;\n@@ -145,14 +123,11 @@ void qman_thread_irq(void)\n \n struct qman_portal *fsl_qman_portal_create(void)\n {\n-\tcpu_set_t cpuset;\n \tstruct qman_portal *res;\n-\n \tstruct qm_portal_config *q_pcfg;\n-\tint loop, ret;\n \tstruct dpaa_ioctl_irq_map irq_map;\n \tstruct dpaa_ioctl_portal_map q_map = {0};\n-\tint q_fd;\n+\tint q_fd, ret;\n \n \tq_pcfg = kzalloc((sizeof(struct qm_portal_config)), 0);\n \tif (!q_pcfg) {\n@@ -160,31 +135,6 @@ struct qman_portal *fsl_qman_portal_create(void)\n \t\treturn NULL;\n \t}\n \n-\t/* Verify the thread's cpu-affinity */\n-\tret = pthread_getaffinity_np(pthread_self(), sizeof(cpu_set_t),\n-\t\t\t\t &cpuset);\n-\tif (ret) {\n-\t\terror(0, ret, \"pthread_getaffinity_np()\");\n-\t\tkfree(q_pcfg);\n-\t\treturn NULL;\n-\t}\n-\n-\tq_pcfg->cpu = -1;\n-\tfor (loop = 0; loop < CPU_SETSIZE; loop++)\n-\t\tif (CPU_ISSET(loop, &cpuset)) {\n-\t\t\tif (q_pcfg->cpu != -1) {\n-\t\t\t\tpr_err(\"Thread is not affine to 1 cpu\\n\");\n-\t\t\t\tkfree(q_pcfg);\n-\t\t\t\treturn NULL;\n-\t\t\t}\n-\t\t\tq_pcfg->cpu = loop;\n-\t\t}\n-\tif (q_pcfg->cpu == -1) {\n-\t\tpr_err(\"Bug in getaffinity handling!\\n\");\n-\t\tkfree(q_pcfg);\n-\t\treturn NULL;\n-\t}\n-\n \t/* Allocate and map a qman portal */\n \tq_map.type = dpaa_portal_qman;\n \tq_map.index = QBMAN_ANY_PORTAL_IDX;\ndiff --git a/drivers/bus/dpaa/dpaa_bus.c b/drivers/bus/dpaa/dpaa_bus.c\nindex f7d1a5b63..b0e68c4a4 100644\n--- a/drivers/bus/dpaa/dpaa_bus.c\n+++ b/drivers/bus/dpaa/dpaa_bus.c\n@@ -250,11 +250,9 @@ dpaa_clean_device_list(void)\n \n int rte_dpaa_portal_init(void *arg)\n {\n-\tpthread_t id;\n \tunsigned int cpu, lcore = rte_lcore_id();\n \tint ret;\n \tstruct dpaa_portal *dpaa_io_portal;\n-\trte_cpuset_t cpuset;\n \n \tBUS_INIT_FUNC_TRACE();\n \n@@ -266,17 +264,6 @@ int rte_dpaa_portal_init(void *arg)\n \n \tcpu = rte_lcore_to_cpu_id(lcore);\n \n-\t/* Set CPU affinity for this thread.*/\n-\tid = pthread_self();\n-\tcpuset = rte_lcore_cpuset(lcore);\n-\tret = pthread_setaffinity_np(id, sizeof(cpu_set_t),\n-\t\t\t\t &cpuset);\n-\tif (ret) {\n-\t\tDPAA_BUS_LOG(ERR, \"pthread_setaffinity_np failed on core :%u\"\n-\t\t\t \" (lcore=%u) with ret: %d\", cpu, lcore, ret);\n-\t\treturn ret;\n-\t}\n-\n \t/* Initialise bman thread portals */\n \tret = bman_thread_init();\n \tif (ret) {\n", "prefixes": [ "v1", "03/30" ] }