Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/57898/?format=api
{ "id": 57898, "url": "http://patches.dpdk.org/api/patches/57898/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190826105105.19121-3-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190826105105.19121-3-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190826105105.19121-3-qi.z.zhang@intel.com", "date": "2019-08-26T10:50:04", "name": "[02/63] net/ice/base: add function to get FW mode", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "194de546e8880f4aa1635ef781f39b915e7632db", "submitter": { "id": 504, "url": "http://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190826105105.19121-3-qi.z.zhang@intel.com/mbox/", "series": [ { "id": 6119, "url": "http://patches.dpdk.org/api/series/6119/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6119", "date": "2019-08-26T10:50:02", "name": "net/ice/base: update base code", "version": 1, "mbox": "http://patches.dpdk.org/series/6119/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/57898/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/57898/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E7EE71BFB3;\n\tMon, 26 Aug 2019 12:48:32 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id EB4CA1BF7D\n\tfor <dev@dpdk.org>; Mon, 26 Aug 2019 12:48:29 +0200 (CEST)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t26 Aug 2019 03:48:29 -0700", "from dpdk51.sh.intel.com ([10.67.110.245])\n\tby orsmga003.jf.intel.com with ESMTP; 26 Aug 2019 03:48:27 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.64,431,1559545200\"; d=\"scan'208\";a=\"182402059\"", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "wenzhuo.lu@intel.com,\n\tqiming.yang@intel.com", "Cc": "dev@dpdk.org, xiaolong.ye@intel.com, Qi Zhang <qi.z.zhang@intel.com>,\n\tAnirudh Venkataramanan <anirudh.venkataramanan@intel.com>,\n\tPaul M Stillwell Jr <paul.m.stillwell.jr@intel.com>", "Date": "Mon, 26 Aug 2019 18:50:04 +0800", "Message-Id": "<20190826105105.19121-3-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.13.6", "In-Reply-To": "<20190826105105.19121-1-qi.z.zhang@intel.com>", "References": "<20190826105105.19121-1-qi.z.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH 02/63] net/ice/base: add function to get FW mode", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add a helper function to get FW mode. The FW mode can be normal,\ndebug, recovery or rollback.\n\nThis makes ice_is_fw_in_rec_mode redundant, so remove it.\n\nSigned-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>\nSigned-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n drivers/net/ice/base/ice_common.c | 23 ++++++++++++++++-------\n drivers/net/ice/base/ice_common.h | 4 ++--\n 2 files changed, 18 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/ice/base/ice_common.c b/drivers/net/ice/base/ice_common.c\nindex 52fd8c897..681740cee 100644\n--- a/drivers/net/ice/base/ice_common.c\n+++ b/drivers/net/ice/base/ice_common.c\n@@ -4102,16 +4102,25 @@ ice_sched_query_elem(struct ice_hw *hw, u32 node_teid,\n }\n \n /**\n- * ice_is_fw_in_rec_mode\n+ * ice_get_fw_mode - returns FW mode\n * @hw: pointer to the HW struct\n- *\n- * This function returns true if fw is in recovery mode\n */\n-bool ice_is_fw_in_rec_mode(struct ice_hw *hw)\n+enum ice_fw_modes ice_get_fw_mode(struct ice_hw *hw)\n {\n-\tu32 reg;\n+#define ICE_FW_MODE_DBG_M BIT(0)\n+#define ICE_FW_MODE_REC_M BIT(1)\n+#define ICE_FW_MODE_ROLLBACK_M BIT(2)\n+\tu32 fw_mode;\n \n \t/* check the current FW mode */\n-\treg = rd32(hw, GL_MNG_FWSM);\n-\treturn (reg & GL_MNG_FWSM_FW_MODES_M) > ICE_FW_MODE_DBG;\n+\tfw_mode = rd32(hw, GL_MNG_FWSM) & GL_MNG_FWSM_FW_MODES_M;\n+\n+\tif (fw_mode & ICE_FW_MODE_DBG_M)\n+\t\treturn ICE_FW_MODE_DBG;\n+\telse if (fw_mode & ICE_FW_MODE_REC_M)\n+\t\treturn ICE_FW_MODE_REC;\n+\telse if (fw_mode & ICE_FW_MODE_ROLLBACK_M)\n+\t\treturn ICE_FW_MODE_ROLLBACK;\n+\telse\n+\t\treturn ICE_FW_MODE_NORMAL;\n }\ndiff --git a/drivers/net/ice/base/ice_common.h b/drivers/net/ice/base/ice_common.h\nindex 2063295ce..1d8701d64 100644\n--- a/drivers/net/ice/base/ice_common.h\n+++ b/drivers/net/ice/base/ice_common.h\n@@ -14,7 +14,7 @@ enum ice_fw_modes {\n \tICE_FW_MODE_NORMAL,\n \tICE_FW_MODE_DBG,\n \tICE_FW_MODE_REC,\n-\tICE_FW_MODE_DBG_REC\n+\tICE_FW_MODE_ROLLBACK\n };\n \n enum ice_status ice_nvm_validate_checksum(struct ice_hw *hw);\n@@ -198,8 +198,8 @@ ice_stat_update40(struct ice_hw *hw, u32 reg, bool prev_stat_loaded,\n void\n ice_stat_update32(struct ice_hw *hw, u32 reg, bool prev_stat_loaded,\n \t\t u64 *prev_stat, u64 *cur_stat);\n+enum ice_fw_modes ice_get_fw_mode(struct ice_hw *hw);\n enum ice_status\n ice_sched_query_elem(struct ice_hw *hw, u32 node_teid,\n \t\t struct ice_aqc_get_elem *buf);\n-bool ice_is_fw_in_rec_mode(struct ice_hw *hw);\n #endif /* _ICE_COMMON_H_ */\n", "prefixes": [ "02/63" ] }