Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/57877/?format=api
{ "id": 57877, "url": "http://patches.dpdk.org/api/patches/57877/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190823144602.58213-13-jasvinder.singh@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190823144602.58213-13-jasvinder.singh@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190823144602.58213-13-jasvinder.singh@intel.com", "date": "2019-08-23T14:45:59", "name": "[12/15] net/softnic: add subport config flexibility to TM function", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "846a6618d52ba6215177ed9e0d8ecb56f3cafe6f", "submitter": { "id": 285, "url": "http://patches.dpdk.org/api/people/285/?format=api", "name": "Jasvinder Singh", "email": "jasvinder.singh@intel.com" }, "delegate": { "id": 10018, "url": "http://patches.dpdk.org/api/users/10018/?format=api", "username": "cristian_dumitrescu", "first_name": "Cristian", "last_name": "Dumitrescu", "email": "cristian.dumitrescu@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190823144602.58213-13-jasvinder.singh@intel.com/mbox/", "series": [ { "id": 6115, "url": "http://patches.dpdk.org/api/series/6115/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6115", "date": "2019-08-23T14:45:47", "name": "sched: subport level configuration of pipe nodes", "version": 1, "mbox": "http://patches.dpdk.org/series/6115/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/57877/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/57877/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 434721C0D5;\n\tFri, 23 Aug 2019 16:46:36 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id CE6D81C02C\n\tfor <dev@dpdk.org>; Fri, 23 Aug 2019 16:46:19 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t23 Aug 2019 07:46:19 -0700", "from silpixa00381635.ir.intel.com (HELO\n\tsilpixa00381635.ger.corp.intel.com) ([10.237.223.4])\n\tby orsmga001.jf.intel.com with ESMTP; 23 Aug 2019 07:46:18 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.64,421,1559545200\"; d=\"scan'208\";a=\"263211312\"", "From": "Jasvinder Singh <jasvinder.singh@intel.com>", "To": "dev@dpdk.org", "Cc": "cristian.dumitrescu@intel.com,\n\tLukasz Krakowiak <lukaszx.krakowiak@intel.com>", "Date": "Fri, 23 Aug 2019 15:45:59 +0100", "Message-Id": "<20190823144602.58213-13-jasvinder.singh@intel.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190823144602.58213-1-jasvinder.singh@intel.com>", "References": "<20190823144602.58213-1-jasvinder.singh@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 12/15] net/softnic: add subport config\n\tflexibility to TM function", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Modify softnic traffic management function to allow different\nsubports of the same port to have different configuration in\nterms of number of pipes, pipe queue sizes, etc.\n\nSigned-off-by: Jasvinder Singh <jasvinder.singh@intel.com>\nSigned-off-by: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>\n---\n drivers/net/softnic/rte_eth_softnic_tm.c | 51 ++++++++++++------------\n 1 file changed, 26 insertions(+), 25 deletions(-)", "diff": "diff --git a/drivers/net/softnic/rte_eth_softnic_tm.c b/drivers/net/softnic/rte_eth_softnic_tm.c\nindex 61c3adc82..8fb728d7d 100644\n--- a/drivers/net/softnic/rte_eth_softnic_tm.c\n+++ b/drivers/net/softnic/rte_eth_softnic_tm.c\n@@ -85,7 +85,8 @@ softnic_tmgr_port_create(struct pmd_internals *p,\n \t/* Subport */\n \tn_subports = t->port_params.n_subports_per_port;\n \tfor (subport_id = 0; subport_id < n_subports; subport_id++) {\n-\t\tuint32_t n_pipes_per_subport = t->port_params.n_pipes_per_subport;\n+\t\tuint32_t n_pipes_per_subport =\n+\t\t\tt->subport_params[subport_id].n_pipes_per_subport;\n \t\tuint32_t pipe_id;\n \t\tint status;\n \n@@ -2211,10 +2212,11 @@ tm_tc_wred_profile_get(struct rte_eth_dev *dev, uint32_t tc_id)\n #ifdef RTE_SCHED_RED\n \n static void\n-wred_profiles_set(struct rte_eth_dev *dev)\n+wred_profiles_set(struct rte_eth_dev *dev, uint32_t subport_id)\n {\n \tstruct pmd_internals *p = dev->data->dev_private;\n-\tstruct rte_sched_port_params *pp = &p->soft.tm.params.port_params;\n+\tstruct rte_sched_subport_params *pp =\n+\t\t&p->soft.tm.params.subport_params[subport_id];\n \n \tuint32_t tc_id;\n \tenum rte_color color;\n@@ -2234,7 +2236,7 @@ wred_profiles_set(struct rte_eth_dev *dev)\n \n #else\n \n-#define wred_profiles_set(dev)\n+#define wred_profiles_set(dev, subport_id)\n \n #endif\n \n@@ -2526,29 +2528,10 @@ hierarchy_blueprints_create(struct rte_eth_dev *dev)\n \t\t.frame_overhead =\n \t\t\troot->shaper_profile->params.pkt_length_adjust,\n \t\t.n_subports_per_port = root->n_children,\n-\t\t.n_pipes_per_subport = h->n_tm_nodes[TM_NODE_LEVEL_PIPE] /\n-\t\t\th->n_tm_nodes[TM_NODE_LEVEL_SUBPORT],\n-\t\t.qsize = {p->params.tm.qsize[0],\n-\t\t\tp->params.tm.qsize[1],\n-\t\t\tp->params.tm.qsize[2],\n-\t\t\tp->params.tm.qsize[3],\n-\t\t\tp->params.tm.qsize[4],\n-\t\t\tp->params.tm.qsize[5],\n-\t\t\tp->params.tm.qsize[6],\n-\t\t\tp->params.tm.qsize[7],\n-\t\t\tp->params.tm.qsize[8],\n-\t\t\tp->params.tm.qsize[9],\n-\t\t\tp->params.tm.qsize[10],\n-\t\t\tp->params.tm.qsize[11],\n-\t\t\tp->params.tm.qsize[12],\n-\t\t},\n-\t\t.pipe_profiles = t->pipe_profiles,\n-\t\t.n_pipe_profiles = t->n_pipe_profiles,\n+\t\t.n_max_pipes_per_subport = TM_MAX_PIPES_PER_SUBPORT,\n \t\t.n_max_pipe_profiles = TM_MAX_PIPE_PROFILE,\n \t};\n \n-\twred_profiles_set(dev);\n-\n \tsubport_id = 0;\n \tTAILQ_FOREACH(n, nl, node) {\n \t\tuint64_t tc_rate[RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE];\n@@ -2588,8 +2571,26 @@ hierarchy_blueprints_create(struct rte_eth_dev *dev)\n \t\t\t\t\ttc_rate[12],\n \t\t\t\t},\n \t\t\t\t.tc_period = SUBPORT_TC_PERIOD,\n+\t\t\t\t.n_pipes_per_subport = h->n_tm_nodes[TM_NODE_LEVEL_PIPE] /\n+\t\t\t\t\th->n_tm_nodes[TM_NODE_LEVEL_SUBPORT],\n+\t\t\t\t.qsize = {p->params.tm.qsize[0],\n+\t\t\t\t\tp->params.tm.qsize[1],\n+\t\t\t\t\tp->params.tm.qsize[2],\n+\t\t\t\t\tp->params.tm.qsize[3],\n+\t\t\t\t\tp->params.tm.qsize[4],\n+\t\t\t\t\tp->params.tm.qsize[5],\n+\t\t\t\t\tp->params.tm.qsize[6],\n+\t\t\t\t\tp->params.tm.qsize[7],\n+\t\t\t\t\tp->params.tm.qsize[8],\n+\t\t\t\t\tp->params.tm.qsize[9],\n+\t\t\t\t\tp->params.tm.qsize[10],\n+\t\t\t\t\tp->params.tm.qsize[11],\n+\t\t\t\t\tp->params.tm.qsize[12],\n+\t\t\t\t},\n+\t\t\t\t.pipe_profiles = t->pipe_profiles,\n+\t\t\t\t.n_pipe_profiles = t->n_pipe_profiles,\n \t\t};\n-\n+\t\twred_profiles_set(dev, subport_id);\n \t\tsubport_id++;\n \t}\n }\n", "prefixes": [ "12/15" ] }