Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 57677,
    "url": "http://patches.dpdk.org/api/patches/57677/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1565771263-27353-3-git-send-email-phil.yang@arm.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1565771263-27353-3-git-send-email-phil.yang@arm.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1565771263-27353-3-git-send-email-phil.yang@arm.com",
    "date": "2019-08-14T08:27:43",
    "name": "[v9,3/3] eal/stack: enable lock-free stack for aarch64",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "8ea3eed23d6e0c70e2eb11b5614d82ddeddf8f9b",
    "submitter": {
        "id": 833,
        "url": "http://patches.dpdk.org/api/people/833/?format=api",
        "name": "Phil Yang",
        "email": "phil.yang@arm.com"
    },
    "delegate": {
        "id": 24651,
        "url": "http://patches.dpdk.org/api/users/24651/?format=api",
        "username": "dmarchand",
        "first_name": "David",
        "last_name": "Marchand",
        "email": "david.marchand@redhat.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1565771263-27353-3-git-send-email-phil.yang@arm.com/mbox/",
    "series": [
        {
            "id": 6041,
            "url": "http://patches.dpdk.org/api/series/6041/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6041",
            "date": "2019-08-14T08:27:41",
            "name": "[v9,1/3] eal/arm64: add 128-bit atomic compare exchange",
            "version": 9,
            "mbox": "http://patches.dpdk.org/series/6041/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/57677/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/57677/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id AE9471BE91;\n\tWed, 14 Aug 2019 10:29:30 +0200 (CEST)",
            "from foss.arm.com (foss.arm.com [217.140.110.172])\n\tby dpdk.org (Postfix) with ESMTP id E5CFA1BE89\n\tfor <dev@dpdk.org>; Wed, 14 Aug 2019 10:29:28 +0200 (CEST)",
            "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n\tby usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4F49A337;\n\tWed, 14 Aug 2019 01:29:28 -0700 (PDT)",
            "from phil-VirtualBox.shanghai.arm.com (unknown [10.169.109.153])\n\tby usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id\n\t6147D3F694; Wed, 14 Aug 2019 01:29:26 -0700 (PDT)"
        ],
        "From": "Phil Yang <phil.yang@arm.com>",
        "To": "thomas@monjalon.net, jerinj@marvell.com, gage.eads@intel.com,\n\tdev@dpdk.org",
        "Cc": "hemant.agrawal@nxp.com, Honnappa.Nagarahalli@arm.com, gavin.hu@arm.com, \n\tnd@arm.com",
        "Date": "Wed, 14 Aug 2019 16:27:43 +0800",
        "Message-Id": "<1565771263-27353-3-git-send-email-phil.yang@arm.com>",
        "X-Mailer": "git-send-email 2.7.4",
        "In-Reply-To": "<1565771263-27353-1-git-send-email-phil.yang@arm.com>",
        "References": "<20190723070536.30342-1-jerinj@marvell.com>\n\t<1565771263-27353-1-git-send-email-phil.yang@arm.com>",
        "Subject": "[dpdk-dev] [PATCH v9 3/3] eal/stack: enable lock-free stack for\n\taarch64",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Enable both c11 atomic and non c11 atomic lock-free stack for aarch64.\n\nIntroduced a new header to reduce the ifdef clutter across generic and c11\nfiles. The rte_stack_lf_stubs.h contains stub implementations of\n__rte_stack_lf_count, __rte_stack_lf_push_elems and\n__rte_stack_lf_pop_elems.\n\nSuggested-by: Gage Eads <gage.eads@intel.com>\nSuggested-by: Jerin Jacob <jerinj@marvell.com>\nSigned-off-by: Phil Yang <phil.yang@arm.com>\nReviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\nTested-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\nAcked-by: Jerin Jacob <jerinj@marvell.com>\n---\n doc/guides/prog_guide/env_abstraction_layer.rst |  4 +--\n doc/guides/rel_notes/release_19_11.rst          |  3 ++\n lib/librte_stack/Makefile                       |  3 +-\n lib/librte_stack/rte_stack_lf.h                 |  4 +++\n lib/librte_stack/rte_stack_lf_c11.h             | 16 ---------\n lib/librte_stack/rte_stack_lf_generic.h         | 16 ---------\n lib/librte_stack/rte_stack_lf_stubs.h           | 44 +++++++++++++++++++++++++\n 7 files changed, 55 insertions(+), 35 deletions(-)\n create mode 100644 lib/librte_stack/rte_stack_lf_stubs.h",
    "diff": "diff --git a/doc/guides/prog_guide/env_abstraction_layer.rst b/doc/guides/prog_guide/env_abstraction_layer.rst\nindex 94f30fd..6e59fae 100644\n--- a/doc/guides/prog_guide/env_abstraction_layer.rst\n+++ b/doc/guides/prog_guide/env_abstraction_layer.rst\n@@ -648,8 +648,8 @@ Known Issues\n   Alternatively, applications can use the lock-free stack mempool handler. When\n   considering this handler, note that:\n \n-  - It is currently limited to the x86_64 platform, because it uses an\n-    instruction (16-byte compare-and-swap) that is not yet available on other\n+  - It is currently limited to the aarch64 and x86_64 platforms, because it uses\n+    an instruction (16-byte compare-and-swap) that is not yet available on other\n     platforms.\n   - It has worse average-case performance than the non-preemptive rte_ring, but\n     software caching (e.g. the mempool cache) can mitigate this by reducing the\ndiff --git a/doc/guides/rel_notes/release_19_11.rst b/doc/guides/rel_notes/release_19_11.rst\nindex 8490d89..60ffd70 100644\n--- a/doc/guides/rel_notes/release_19_11.rst\n+++ b/doc/guides/rel_notes/release_19_11.rst\n@@ -56,6 +56,9 @@ New Features\n      Also, make sure to start the actual text at the margin.\n      =========================================================\n \n+* **Added Lock-free Stack for aarch64.**\n+\n+  The lock-free stack implementation is enabled for aarch64 platforms.\n \n Removed Items\n -------------\ndiff --git a/lib/librte_stack/Makefile b/lib/librte_stack/Makefile\nindex 8d18ce5..c337ab7 100644\n--- a/lib/librte_stack/Makefile\n+++ b/lib/librte_stack/Makefile\n@@ -24,6 +24,7 @@ SYMLINK-$(CONFIG_RTE_LIBRTE_STACK)-include := rte_stack.h \\\n \t\t\t\t\t      rte_stack_std.h \\\n \t\t\t\t\t      rte_stack_lf.h \\\n \t\t\t\t\t      rte_stack_lf_generic.h \\\n-\t\t\t\t\t      rte_stack_lf_c11.h\n+\t\t\t\t\t      rte_stack_lf_c11.h \\\n+\t\t\t\t\t\t  rte_stack_lf_stubs.h\n \n include $(RTE_SDK)/mk/rte.lib.mk\ndiff --git a/lib/librte_stack/rte_stack_lf.h b/lib/librte_stack/rte_stack_lf.h\nindex f5581f0..e67630c 100644\n--- a/lib/librte_stack/rte_stack_lf.h\n+++ b/lib/librte_stack/rte_stack_lf.h\n@@ -5,11 +5,15 @@\n #ifndef _RTE_STACK_LF_H_\n #define _RTE_STACK_LF_H_\n \n+#if !(defined(RTE_ARCH_X86_64) || defined(RTE_ARCH_ARM64))\n+#include \"rte_stack_lf_stubs.h\"\n+#else\n #ifdef RTE_USE_C11_MEM_MODEL\n #include \"rte_stack_lf_c11.h\"\n #else\n #include \"rte_stack_lf_generic.h\"\n #endif\n+#endif\n \n /**\n  * @internal Push several objects on the lock-free stack (MT-safe).\ndiff --git a/lib/librte_stack/rte_stack_lf_c11.h b/lib/librte_stack/rte_stack_lf_c11.h\nindex 3d677ae..999359f 100644\n--- a/lib/librte_stack/rte_stack_lf_c11.h\n+++ b/lib/librte_stack/rte_stack_lf_c11.h\n@@ -36,12 +36,6 @@ __rte_stack_lf_push_elems(struct rte_stack_lf_list *list,\n \t\t\t  struct rte_stack_lf_elem *last,\n \t\t\t  unsigned int num)\n {\n-#ifndef RTE_ARCH_X86_64\n-\tRTE_SET_USED(first);\n-\tRTE_SET_USED(last);\n-\tRTE_SET_USED(list);\n-\tRTE_SET_USED(num);\n-#else\n \tstruct rte_stack_lf_head old_head;\n \tint success;\n \n@@ -79,7 +73,6 @@ __rte_stack_lf_push_elems(struct rte_stack_lf_list *list,\n \t * to the LIFO len update.\n \t */\n \t__atomic_add_fetch(&list->len, num, __ATOMIC_RELEASE);\n-#endif\n }\n \n static __rte_always_inline struct rte_stack_lf_elem *\n@@ -88,14 +81,6 @@ __rte_stack_lf_pop_elems(struct rte_stack_lf_list *list,\n \t\t\t void **obj_table,\n \t\t\t struct rte_stack_lf_elem **last)\n {\n-#ifndef RTE_ARCH_X86_64\n-\tRTE_SET_USED(obj_table);\n-\tRTE_SET_USED(last);\n-\tRTE_SET_USED(list);\n-\tRTE_SET_USED(num);\n-\n-\treturn NULL;\n-#else\n \tstruct rte_stack_lf_head old_head;\n \tuint64_t len;\n \tint success;\n@@ -169,7 +154,6 @@ __rte_stack_lf_pop_elems(struct rte_stack_lf_list *list,\n \t} while (success == 0);\n \n \treturn old_head.top;\n-#endif\n }\n \n #endif /* _RTE_STACK_LF_C11_H_ */\ndiff --git a/lib/librte_stack/rte_stack_lf_generic.h b/lib/librte_stack/rte_stack_lf_generic.h\nindex 3182151..3abbb53 100644\n--- a/lib/librte_stack/rte_stack_lf_generic.h\n+++ b/lib/librte_stack/rte_stack_lf_generic.h\n@@ -36,12 +36,6 @@ __rte_stack_lf_push_elems(struct rte_stack_lf_list *list,\n \t\t\t  struct rte_stack_lf_elem *last,\n \t\t\t  unsigned int num)\n {\n-#ifndef RTE_ARCH_X86_64\n-\tRTE_SET_USED(first);\n-\tRTE_SET_USED(last);\n-\tRTE_SET_USED(list);\n-\tRTE_SET_USED(num);\n-#else\n \tstruct rte_stack_lf_head old_head;\n \tint success;\n \n@@ -75,7 +69,6 @@ __rte_stack_lf_push_elems(struct rte_stack_lf_list *list,\n \t} while (success == 0);\n \n \trte_atomic64_add((rte_atomic64_t *)&list->len, num);\n-#endif\n }\n \n static __rte_always_inline struct rte_stack_lf_elem *\n@@ -84,14 +77,6 @@ __rte_stack_lf_pop_elems(struct rte_stack_lf_list *list,\n \t\t\t void **obj_table,\n \t\t\t struct rte_stack_lf_elem **last)\n {\n-#ifndef RTE_ARCH_X86_64\n-\tRTE_SET_USED(obj_table);\n-\tRTE_SET_USED(last);\n-\tRTE_SET_USED(list);\n-\tRTE_SET_USED(num);\n-\n-\treturn NULL;\n-#else\n \tstruct rte_stack_lf_head old_head;\n \tint success;\n \n@@ -159,7 +144,6 @@ __rte_stack_lf_pop_elems(struct rte_stack_lf_list *list,\n \t} while (success == 0);\n \n \treturn old_head.top;\n-#endif\n }\n \n #endif /* _RTE_STACK_LF_GENERIC_H_ */\ndiff --git a/lib/librte_stack/rte_stack_lf_stubs.h b/lib/librte_stack/rte_stack_lf_stubs.h\nnew file mode 100644\nindex 0000000..a05abf1\n--- /dev/null\n+++ b/lib/librte_stack/rte_stack_lf_stubs.h\n@@ -0,0 +1,44 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(c) 2019 Arm Limited\n+ */\n+\n+#ifndef _RTE_STACK_LF_STUBS_H_\n+#define _RTE_STACK_LF_STUBS_H_\n+\n+#include <rte_common.h>\n+\n+static __rte_always_inline unsigned int\n+__rte_stack_lf_count(struct rte_stack *s)\n+{\n+\tRTE_SET_USED(s);\n+\n+\treturn 0;\n+}\n+\n+static __rte_always_inline void\n+__rte_stack_lf_push_elems(struct rte_stack_lf_list *list,\n+\t\t\t  struct rte_stack_lf_elem *first,\n+\t\t\t  struct rte_stack_lf_elem *last,\n+\t\t\t  unsigned int num)\n+{\n+\tRTE_SET_USED(first);\n+\tRTE_SET_USED(last);\n+\tRTE_SET_USED(list);\n+\tRTE_SET_USED(num);\n+}\n+\n+static __rte_always_inline struct rte_stack_lf_elem *\n+__rte_stack_lf_pop_elems(struct rte_stack_lf_list *list,\n+\t\t\t unsigned int num,\n+\t\t\t void **obj_table,\n+\t\t\t struct rte_stack_lf_elem **last)\n+{\n+\tRTE_SET_USED(obj_table);\n+\tRTE_SET_USED(last);\n+\tRTE_SET_USED(list);\n+\tRTE_SET_USED(num);\n+\n+\treturn NULL;\n+}\n+\n+#endif /* _RTE_STACK_LF_STUBS_H_ */\n",
    "prefixes": [
        "v9",
        "3/3"
    ]
}