Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 57240,
    "url": "http://patches.dpdk.org/api/patches/57240/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1564403817-13438-1-git-send-email-matan@mellanox.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1564403817-13438-1-git-send-email-matan@mellanox.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1564403817-13438-1-git-send-email-matan@mellanox.com",
    "date": "2019-07-29T12:36:56",
    "name": "[1/2] app/testpmd: fix scatter offload configuration",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "ca1086bd7b931cf6211a870f11d0ddc65f15d9a9",
    "submitter": {
        "id": 796,
        "url": "http://patches.dpdk.org/api/people/796/?format=api",
        "name": "Matan Azrad",
        "email": "matan@mellanox.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1564403817-13438-1-git-send-email-matan@mellanox.com/mbox/",
    "series": [
        {
            "id": 5811,
            "url": "http://patches.dpdk.org/api/series/5811/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5811",
            "date": "2019-07-29T12:36:56",
            "name": "[1/2] app/testpmd: fix scatter offload configuration",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/5811/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/57240/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/57240/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 381541BF2B;\n\tMon, 29 Jul 2019 14:37:10 +0200 (CEST)",
            "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n\tby dpdk.org (Postfix) with ESMTP id 500C71BF11\n\tfor <dev@dpdk.org>; Mon, 29 Jul 2019 14:37:08 +0200 (CEST)",
            "from Internal Mail-Server by MTLPINE2 (envelope-from\n\tmatan@mellanox.com)\n\twith ESMTPS (AES256-SHA encrypted); 29 Jul 2019 15:37:07 +0300",
            "from pegasus07.mtr.labs.mlnx (pegasus07.mtr.labs.mlnx\n\t[10.210.16.112])\n\tby labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x6TCb7Vk009212;\n\tMon, 29 Jul 2019 15:37:07 +0300"
        ],
        "From": "Matan Azrad <matan@mellanox.com>",
        "To": "Wenzhuo Lu <wenzhuo.lu@intel.com>, Jingjing Wu <jingjing.wu@intel.com>",
        "Cc": "dev@dpdk.org, stable@dpdk.org",
        "Date": "Mon, 29 Jul 2019 12:36:56 +0000",
        "Message-Id": "<1564403817-13438-1-git-send-email-matan@mellanox.com>",
        "X-Mailer": "git-send-email 1.8.3.1",
        "Subject": "[dpdk-dev] [PATCH 1/2] app/testpmd: fix scatter offload\n\tconfiguration",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "When the mbuf data size cannot contain the maximum Rx packet length with\nthe mbuf headroom, a packet should be scattered in more than one mbuf.\n\nThe application did not configure scatter offload in the above case.\n\nEnable the Rx scatter offload in the above case.\n\nFixes: 33f9630fc23d (\"app/testpmd: create mbuf based on max supported segments\")\nCc: stable@dpdk.org\n\nSigned-off-by: Matan Azrad <matan@mellanox.com>\n---\n app/test-pmd/testpmd.c | 11 +++++++++++\n 1 file changed, 11 insertions(+)",
    "diff": "diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\nindex 518865a..4ae70ef 100644\n--- a/app/test-pmd/testpmd.c\n+++ b/app/test-pmd/testpmd.c\n@@ -1191,6 +1191,17 @@ struct extmem_param {\n \t\t\t\twarning = 1;\n \t\t\t}\n \t\t}\n+\t\tif (rx_mode.max_rx_pkt_len + RTE_PKTMBUF_HEADROOM >\n+\t\t    mbuf_data_size) {\n+\t\t\tif (port->dev_info.rx_queue_offload_capa &\n+\t\t\t    DEV_RX_OFFLOAD_SCATTER)\n+\t\t\t\tport->dev_conf.rxmode.offloads |=\n+\t\t\t\t\t\tDEV_RX_OFFLOAD_SCATTER;\n+\t\t\telse\n+\t\t\t\tTESTPMD_LOG(WARNING, \"Configure scatter is\"\n+\t\t\t\t\t    \" needed and cannot be configured\"\n+\t\t\t\t\t    \" in the port %u\\n\", pid);\n+\t\t}\n \t}\n \n \tif (warning)\n",
    "prefixes": [
        "1/2"
    ]
}