Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/57126/?format=api
{ "id": 57126, "url": "http://patches.dpdk.org/api/patches/57126/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190725162903.106262-1-hariprasad.govindharajan@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190725162903.106262-1-hariprasad.govindharajan@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190725162903.106262-1-hariprasad.govindharajan@intel.com", "date": "2019-07-25T16:29:03", "name": "[v2] examples/l3fwd: fix unaligned memory access", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "0407b0ce650cd1ede4af07002a01a7de028f78aa", "submitter": { "id": 1311, "url": "http://patches.dpdk.org/api/people/1311/?format=api", "name": "Hariprasad Govindharajan", "email": "hariprasad.govindharajan@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190725162903.106262-1-hariprasad.govindharajan@intel.com/mbox/", "series": [ { "id": 5760, "url": "http://patches.dpdk.org/api/series/5760/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5760", "date": "2019-07-25T16:29:03", "name": "[v2] examples/l3fwd: fix unaligned memory access", "version": 2, "mbox": "http://patches.dpdk.org/series/5760/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/57126/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/57126/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D40E31C399;\n\tThu, 25 Jul 2019 18:29:11 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id B5D9B1C38F;\n\tThu, 25 Jul 2019 18:29:09 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t25 Jul 2019 09:29:08 -0700", "from silpixa00389816.ir.intel.com ([10.237.222.12])\n\tby fmsmga002.fm.intel.com with ESMTP; 25 Jul 2019 09:29:06 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.64,307,1559545200\"; d=\"scan'208\";a=\"197934133\"", "From": "hgovindh <hariprasad.govindharajan@intel.com>", "To": "Remy Horton <remy.horton@intel.com>,\n\tMarko Kovacevic <marko.kovacevic@intel.com>,\n\tOri Kam <orika@mellanox.com>, \n\tBruce Richardson <bruce.richardson@intel.com>,\n\tPablo de Lara <pablo.de.lara.guarch@intel.com>,\n\tRadu Nicolau <radu.nicolau@intel.com>,\n\tAkhil Goyal <akhil.goyal@nxp.com>, \n\tTomasz Kantecki <tomasz.kantecki@intel.com>", "Cc": "dev@dpdk.org, hgovindh <hariprasad.govindharajan@intel.com>,\n\tmaciej.czekaj@caviumnetworks.com, stable@dpdk.org", "Date": "Thu, 25 Jul 2019 17:29:03 +0100", "Message-Id": "<20190725162903.106262-1-hariprasad.govindharajan@intel.com>", "X-Mailer": "git-send-email 2.22.0", "In-Reply-To": "<20190724164354.18811-1-hariprasad.govindharajan@intel.com>", "References": "<20190724164354.18811-1-hariprasad.govindharajan@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2] examples/l3fwd: fix unaligned memory access", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Fix unaligned memory access when reading IPv6 header which\nleads to segmentation fault by changing aligned memory read\nto unaligned memory read.\n\nBugzilla ID: 279\nFixes: 64d3955de1de (\"examples/l3fwd: fix ARM build\")\nCc: maciej.czekaj@caviumnetworks.com\nCc: stable@dpdk.org\nSigned-off-by: hgovindh <hariprasad.govindharajan@intel.com>\n---\nV2: Added functions which will do unaligned load based on the\nunderlying architecture\n---\n---\n examples/l3fwd/l3fwd_em.c | 26 ++++++++++++++++++++++++--\n 1 file changed, 24 insertions(+), 2 deletions(-)", "diff": "diff --git a/examples/l3fwd/l3fwd_em.c b/examples/l3fwd/l3fwd_em.c\nindex fa8f82be6..f2641586b 100644\n--- a/examples/l3fwd/l3fwd_em.c\n+++ b/examples/l3fwd/l3fwd_em.c\n@@ -244,6 +244,29 @@ em_mask_key(void *key, xmm_t mask)\n #error No vector engine (SSE, NEON, ALTIVEC) available, check your toolchain\n #endif\n \n+#if defined(RTE_MACHINE_CPUFLAG_SSE2)\n+static inline xmm_t\n+em_load_key(void *key)\n+{\n+\treturn _mm_loadu_si128((__m128i *)(key));\n+}\n+#elif defined(RTE_MACHINE_CPUFLAG_NEON)\n+static inline xmm_t\n+em_load_key(void *key)\n+{\n+\treturn vld1q_s32((int32_t *)key);\n+}\n+#elif defined(RTE_MACHINE_CPUFLAG_ALTIVEC)\n+static inline xmm_t\n+em_load_key(void *key)\n+{\n+\treturn vec_ld(0, (xmm_t *)(key));\n+}\n+#else\n+#error No vector engine (SSE, NEON, ALTIVEC) available, check your toolchain\n+#endif\n+\n+\n static inline uint16_t\n em_get_ipv4_dst_port(void *ipv4_hdr, uint16_t portid, void *lookup_struct)\n {\n@@ -285,8 +308,7 @@ em_get_ipv6_dst_port(void *ipv6_hdr, uint16_t portid, void *lookup_struct)\n \t * Get part of 5 tuple: dst IP address lower 96 bits\n \t * and src IP address higher 32 bits.\n \t */\n-\tkey.xmm[1] = *(xmm_t *)data1;\n-\n+\tkey.xmm[1] = em_load_key(data1);\n \t/*\n \t * Get part of 5 tuple: dst port and src port\n \t * and dst IP address higher 32 bits.\n", "prefixes": [ "v2" ] }