Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 57118,
    "url": "http://patches.dpdk.org/api/patches/57118/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190725143831.25116-2-bruce.richardson@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190725143831.25116-2-bruce.richardson@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190725143831.25116-2-bruce.richardson@intel.com",
    "date": "2019-07-25T14:38:28",
    "name": "[19.11,1/4] build: allow compile with stricter fallthrough warnings",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "760c89e3f15935011161dd2ee2988c0d88acf561",
    "submitter": {
        "id": 20,
        "url": "http://patches.dpdk.org/api/people/20/?format=api",
        "name": "Bruce Richardson",
        "email": "bruce.richardson@intel.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190725143831.25116-2-bruce.richardson@intel.com/mbox/",
    "series": [
        {
            "id": 5755,
            "url": "http://patches.dpdk.org/api/series/5755/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5755",
            "date": "2019-07-25T14:38:27",
            "name": "synchronise meson warnings with make",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/5755/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/57118/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/57118/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 115011C37B;\n\tThu, 25 Jul 2019 16:38:41 +0200 (CEST)",
            "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n\tby dpdk.org (Postfix) with ESMTP id 6D0871C36F\n\tfor <dev@dpdk.org>; Thu, 25 Jul 2019 16:38:36 +0200 (CEST)",
            "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t25 Jul 2019 07:38:36 -0700",
            "from silpixa00399126.ir.intel.com (HELO\n\tsilpixa00399126.ger.corp.intel.com) ([10.237.223.2])\n\tby orsmga001.jf.intel.com with ESMTP; 25 Jul 2019 07:38:35 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.64,307,1559545200\"; d=\"scan'208\";a=\"253948998\"",
        "From": "Bruce Richardson <bruce.richardson@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "Bruce Richardson <bruce.richardson@intel.com>",
        "Date": "Thu, 25 Jul 2019 15:38:28 +0100",
        "Message-Id": "<20190725143831.25116-2-bruce.richardson@intel.com>",
        "X-Mailer": "git-send-email 2.21.0",
        "In-Reply-To": "<20190725143831.25116-1-bruce.richardson@intel.com>",
        "References": "<20190725143831.25116-1-bruce.richardson@intel.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH 19.11 1/4] build: allow compile with stricter\n\tfallthrough warnings",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "DPDK currently compiles with implicit-fallthrough=2 warning level. With gcc\n-Wextra flag, the default level is 3, so some minor changes are needed to\nsupport this in DPDK.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n drivers/net/bonding/rte_eth_bond_pmd.c | 3 ++-\n drivers/net/fm10k/base/meson.build     | 3 ++-\n lib/librte_cmdline/cmdline_parse_num.c | 2 +-\n 3 files changed, 5 insertions(+), 3 deletions(-)",
    "diff": "diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c\nindex 6a6ed890a..728915d4a 100644\n--- a/drivers/net/bonding/rte_eth_bond_pmd.c\n+++ b/drivers/net/bonding/rte_eth_bond_pmd.c\n@@ -2521,7 +2521,8 @@ bond_ethdev_link_update(struct rte_eth_dev *ethdev, int wait_to_complete)\n \t\t\t\tbond_ctx->mode4.slave_link.link_autoneg;\n \t\tethdev->data->dev_link.link_duplex =\n \t\t\t\tbond_ctx->mode4.slave_link.link_duplex;\n-\t\t/* fall through to update link speed */\n+\t\t/* fall through */\n+\t\t/* to update link speed */\n \tcase BONDING_MODE_ROUND_ROBIN:\n \tcase BONDING_MODE_BALANCE:\n \tcase BONDING_MODE_TLB:\ndiff --git a/drivers/net/fm10k/base/meson.build b/drivers/net/fm10k/base/meson.build\nindex 5525cdc82..9e1022fef 100644\n--- a/drivers/net/fm10k/base/meson.build\n+++ b/drivers/net/fm10k/base/meson.build\n@@ -12,7 +12,8 @@ sources = [\n \n error_cflags = ['-Wno-unused-parameter', '-Wno-unused-value',\n \t'-Wno-strict-aliasing', '-Wno-format-extra-args',\n-\t'-Wno-unused-variable', '-Wno-missing-field-initializers'\n+\t'-Wno-unused-variable', '-Wno-missing-field-initializers',\n+\t'-Wno-implicit-fallthrough'\n ]\n c_args = cflags\n if allow_experimental_apis\ndiff --git a/lib/librte_cmdline/cmdline_parse_num.c b/lib/librte_cmdline/cmdline_parse_num.c\nindex 182ac12f0..478f181b4 100644\n--- a/lib/librte_cmdline/cmdline_parse_num.c\n+++ b/lib/librte_cmdline/cmdline_parse_num.c\n@@ -196,7 +196,7 @@ cmdline_parse_num(cmdline_parse_token_hdr_t *tk, const char *srcbuf, void *res,\n \n \t\tcase HEX:\n \t\t\tst = HEX_OK;\n-\t\t\t/* fall-through no break */\n+\t\t\t/* fall-through */\n \t\tcase HEX_OK:\n \t\t\tif (c >= '0' && c <= '9') {\n \t\t\t\tif (add_to_res(c - '0', &res1, 16) < 0)\n",
    "prefixes": [
        "19.11",
        "1/4"
    ]
}