Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/5703/?format=api
{ "id": 5703, "url": "http://patches.dpdk.org/api/patches/5703/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1435024235-19483-16-git-send-email-helin.zhang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1435024235-19483-16-git-send-email-helin.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1435024235-19483-16-git-send-email-helin.zhang@intel.com", "date": "2015-06-23T01:50:32", "name": "[dpdk-dev,v8,15/18] examples/l3fwd-acl: replace bit mask based packet type with unified packet type", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "5dfba36e0f6c5ca15595cd0525ecac5bbbc5f549", "submitter": { "id": 14, "url": "http://patches.dpdk.org/api/people/14/?format=api", "name": "Zhang, Helin", "email": "helin.zhang@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1435024235-19483-16-git-send-email-helin.zhang@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/5703/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/5703/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 9644CC8FC;\n\tTue, 23 Jun 2015 03:51:54 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 19798C8C2\n\tfor <dev@dpdk.org>; Tue, 23 Jun 2015 03:51:24 +0200 (CEST)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga102.jf.intel.com with ESMTP; 22 Jun 2015 18:51:24 -0700", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby orsmga003.jf.intel.com with ESMTP; 22 Jun 2015 18:51:22 -0700", "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id t5N1pJHc024388;\n\tTue, 23 Jun 2015 09:51:19 +0800", "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid t5N1pG8U019733; Tue, 23 Jun 2015 09:51:18 +0800", "(from hzhan75@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id t5N1pFcQ019728; \n\tTue, 23 Jun 2015 09:51:15 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.13,663,1427785200\"; d=\"scan'208\";a=\"592903803\"", "From": "Helin Zhang <helin.zhang@intel.com>", "To": "dev@dpdk.org", "Date": "Tue, 23 Jun 2015 09:50:32 +0800", "Message-Id": "<1435024235-19483-16-git-send-email-helin.zhang@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1435024235-19483-1-git-send-email-helin.zhang@intel.com>", "References": "<1434701661-9943-1-git-send-email-helin.zhang@intel.com>\n\t<1435024235-19483-1-git-send-email-helin.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH v8 15/18] examples/l3fwd-acl: replace bit mask\n\tbased packet type with unified packet type", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "To unify packet types among all PMDs, bit masks of packet type for\n'ol_flags' are replaced by unified packet type.\nTo avoid breaking ABI compatibility, all the changes would be\nenabled by RTE_NEXT_ABI, which is disabled by default.\n\nSigned-off-by: Helin Zhang <helin.zhang@intel.com>\n---\n examples/l3fwd-acl/main.c | 29 +++++++++++++++++++++++------\n 1 file changed, 23 insertions(+), 6 deletions(-)\n\nv2 changes:\n* Used redefined packet types and enlarged packet_type field in mbuf.\n\nv5 changes:\n* Re-worded the commit logs.\n\nv6 changes:\n* Disabled the code changes for unified packet type by default, to\n avoid breaking ABI compatibility.\n\nv7 changes:\n* Renamed RTE_UNIFIED_PKT_TYPE to RTE_NEXT_ABI.", "diff": "diff --git a/examples/l3fwd-acl/main.c b/examples/l3fwd-acl/main.c\nindex a5d4f25..78b6df2 100644\n--- a/examples/l3fwd-acl/main.c\n+++ b/examples/l3fwd-acl/main.c\n@@ -645,10 +645,13 @@ prepare_one_packet(struct rte_mbuf **pkts_in, struct acl_search_t *acl,\n \tstruct ipv4_hdr *ipv4_hdr;\n \tstruct rte_mbuf *pkt = pkts_in[index];\n \n+#ifdef RTE_NEXT_ABI\n+\tif (RTE_ETH_IS_IPV4_HDR(pkt->packet_type)) {\n+#else\n \tint type = pkt->ol_flags & (PKT_RX_IPV4_HDR | PKT_RX_IPV6_HDR);\n \n \tif (type == PKT_RX_IPV4_HDR) {\n-\n+#endif\n \t\tipv4_hdr = (struct ipv4_hdr *)(rte_pktmbuf_mtod(pkt,\n \t\t\tunsigned char *) + sizeof(struct ether_hdr));\n \n@@ -667,9 +670,11 @@ prepare_one_packet(struct rte_mbuf **pkts_in, struct acl_search_t *acl,\n \t\t\t/* Not a valid IPv4 packet */\n \t\t\trte_pktmbuf_free(pkt);\n \t\t}\n-\n+#ifdef RTE_NEXT_ABI\n+\t} else if (RTE_ETH_IS_IPV6_HDR(pkt->packet_type)) {\n+#else\n \t} else if (type == PKT_RX_IPV6_HDR) {\n-\n+#endif\n \t\t/* Fill acl structure */\n \t\tacl->data_ipv6[acl->num_ipv6] = MBUF_IPV6_2PROTO(pkt);\n \t\tacl->m_ipv6[(acl->num_ipv6)++] = pkt;\n@@ -687,17 +692,22 @@ prepare_one_packet(struct rte_mbuf **pkts_in, struct acl_search_t *acl,\n {\n \tstruct rte_mbuf *pkt = pkts_in[index];\n \n+#ifdef RTE_NEXT_ABI\n+\tif (RTE_ETH_IS_IPV4_HDR(pkt->packet_type)) {\n+#else\n \tint type = pkt->ol_flags & (PKT_RX_IPV4_HDR | PKT_RX_IPV6_HDR);\n \n \tif (type == PKT_RX_IPV4_HDR) {\n-\n+#endif\n \t\t/* Fill acl structure */\n \t\tacl->data_ipv4[acl->num_ipv4] = MBUF_IPV4_2PROTO(pkt);\n \t\tacl->m_ipv4[(acl->num_ipv4)++] = pkt;\n \n-\n+#ifdef RTE_NEXT_ABI\n+\t} else if (RTE_ETH_IS_IPV6_HDR(pkt->packet_type)) {\n+#else\n \t} else if (type == PKT_RX_IPV6_HDR) {\n-\n+#endif\n \t\t/* Fill acl structure */\n \t\tacl->data_ipv6[acl->num_ipv6] = MBUF_IPV6_2PROTO(pkt);\n \t\tacl->m_ipv6[(acl->num_ipv6)++] = pkt;\n@@ -745,10 +755,17 @@ send_one_packet(struct rte_mbuf *m, uint32_t res)\n \t\t/* in the ACL list, drop it */\n #ifdef L3FWDACL_DEBUG\n \t\tif ((res & ACL_DENY_SIGNATURE) != 0) {\n+#ifdef RTE_NEXT_ABI\n+\t\t\tif (RTE_ETH_IS_IPV4_HDR(m->packet_type))\n+\t\t\t\tdump_acl4_rule(m, res);\n+\t\t\telse if (RTE_ETH_IS_IPV6_HDR(m->packet_type))\n+\t\t\t\tdump_acl6_rule(m, res);\n+#else\n \t\t\tif (m->ol_flags & PKT_RX_IPV4_HDR)\n \t\t\t\tdump_acl4_rule(m, res);\n \t\t\telse\n \t\t\t\tdump_acl6_rule(m, res);\n+#endif /* RTE_NEXT_ABI */\n \t\t}\n #endif\n \t\trte_pktmbuf_free(m);\n", "prefixes": [ "dpdk-dev", "v8", "15/18" ] }