Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/56789/?format=api
{ "id": 56789, "url": "http://patches.dpdk.org/api/patches/56789/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190719141825.101844-5-jasvinder.singh@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190719141825.101844-5-jasvinder.singh@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190719141825.101844-5-jasvinder.singh@intel.com", "date": "2019-07-19T14:18:18", "name": "[v6,04/11] sched: rename tc3 params to best-effort tc", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "8834a7f779751dbfc593ef8045b2200ee46ddd31", "submitter": { "id": 285, "url": "http://patches.dpdk.org/api/people/285/?format=api", "name": "Jasvinder Singh", "email": "jasvinder.singh@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190719141825.101844-5-jasvinder.singh@intel.com/mbox/", "series": [ { "id": 5625, "url": "http://patches.dpdk.org/api/series/5625/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5625", "date": "2019-07-19T14:18:14", "name": "sched: feature enhancements", "version": 6, "mbox": "http://patches.dpdk.org/series/5625/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/56789/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/56789/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C779F1B959;\n\tFri, 19 Jul 2019 16:18:32 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 544632C17\n\tfor <dev@dpdk.org>; Fri, 19 Jul 2019 16:18:23 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t19 Jul 2019 07:18:21 -0700", "from silpixa00381635.ir.intel.com (HELO\n\tsilpixa00381635.ger.corp.intel.com) ([10.237.223.4])\n\tby orsmga008.jf.intel.com with ESMTP; 19 Jul 2019 07:18:20 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.64,282,1559545200\"; d=\"scan'208\";a=\"162417184\"", "From": "Jasvinder Singh <jasvinder.singh@intel.com>", "To": "dev@dpdk.org", "Cc": "cristian.dumitrescu@intel.com, Abraham Tovar <abrahamx.tovar@intel.com>, \n\tLukasz Krakowiak <lukaszx.krakowiak@intel.com>", "Date": "Fri, 19 Jul 2019 15:18:18 +0100", "Message-Id": "<20190719141825.101844-5-jasvinder.singh@intel.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190719141825.101844-1-jasvinder.singh@intel.com>", "References": "<20190717144245.138876-2-jasvinder.singh@intel.com>\n\t<20190719141825.101844-1-jasvinder.singh@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v6 04/11] sched: rename tc3 params to best-effort\n\ttc", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Change the traffic class 3 related params name to best-effort(be)\ntraffic class.\n\nSigned-off-by: Jasvinder Singh <jasvinder.singh@intel.com>\nSigned-off-by: Abraham Tovar <abrahamx.tovar@intel.com>\nSigned-off-by: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>\n---\n lib/librte_sched/rte_sched.c | 56 ++++++++++++++++++------------------\n 1 file changed, 28 insertions(+), 28 deletions(-)", "diff": "diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c\nindex e8614ba4c..7e000c249 100644\n--- a/lib/librte_sched/rte_sched.c\n+++ b/lib/librte_sched/rte_sched.c\n@@ -180,7 +180,7 @@ struct rte_sched_port {\n \tuint16_t qsize[RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE];\n \tuint32_t n_pipe_profiles;\n \tuint32_t n_max_pipe_profiles;\n-\tuint32_t pipe_tc3_rate_max;\n+\tuint32_t pipe_tc_be_rate_max;\n #ifdef RTE_SCHED_RED\n \tstruct rte_red_config red_config[RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE][RTE_COLORS];\n #endif\n@@ -323,7 +323,7 @@ pipe_profile_check(struct rte_sched_pipe_params *params,\n \tif (params->tc_period == 0)\n \t\treturn -14;\n \n-\t/* TC3 oversubscription weight: non-zero */\n+\t/* Best effort tc oversubscription weight: non-zero */\n \tif (params->tc_ov_weight == 0)\n \t\treturn -15;\n \n@@ -540,7 +540,7 @@ rte_sched_port_log_pipe_profile(struct rte_sched_port *port, uint32_t i)\n \t\tp->tc_credits_per_period[11],\n \t\tp->tc_credits_per_period[12],\n \n-\t\t/* Traffic class 3 oversubscription */\n+\t\t/* Best-effort traffic class oversubscription */\n \t\tp->tc_ov_weight,\n \n \t\t/* WRR */\n@@ -629,13 +629,13 @@ rte_sched_port_config_pipe_profile_table(struct rte_sched_port *port,\n \t\trte_sched_port_log_pipe_profile(port, i);\n \t}\n \n-\tport->pipe_tc3_rate_max = 0;\n+\tport->pipe_tc_be_rate_max = 0;\n \tfor (i = 0; i < port->n_pipe_profiles; i++) {\n \t\tstruct rte_sched_pipe_params *src = params->pipe_profiles + i;\n-\t\tuint32_t pipe_tc3_rate = src->tc_rate[RTE_SCHED_TRAFFIC_CLASS_BE];\n+\t\tuint32_t pipe_tc_be_rate = src->tc_rate[RTE_SCHED_TRAFFIC_CLASS_BE];\n \n-\t\tif (port->pipe_tc3_rate_max < pipe_tc3_rate)\n-\t\t\tport->pipe_tc3_rate_max = pipe_tc3_rate;\n+\t\tif (port->pipe_tc_be_rate_max < pipe_tc_be_rate)\n+\t\t\tport->pipe_tc_be_rate_max = pipe_tc_be_rate;\n \t}\n }\n \n@@ -839,7 +839,7 @@ rte_sched_port_log_subport_config(struct rte_sched_port *port, uint32_t i)\n \t\ts->tc_credits_per_period[11],\n \t\ts->tc_credits_per_period[12],\n \n-\t\t/* Traffic class 3 oversubscription */\n+\t\t/* Best effort traffic class oversubscription */\n \t\ts->tc_ov_wm_min,\n \t\ts->tc_ov_wm_max);\n }\n@@ -915,7 +915,7 @@ rte_sched_subport_config(struct rte_sched_port *port,\n \t/* TC oversubscription */\n \ts->tc_ov_wm_min = port->mtu;\n \ts->tc_ov_wm_max = rte_sched_time_ms_to_bytes(params->tc_period,\n-\t\t\t\t\t\t port->pipe_tc3_rate_max);\n+\t\t\t\t\t\t port->pipe_tc_be_rate_max);\n \ts->tc_ov_wm = s->tc_ov_wm_max;\n \ts->tc_ov_period_id = 0;\n \ts->tc_ov = 0;\n@@ -960,21 +960,21 @@ rte_sched_pipe_config(struct rte_sched_port *port,\n \tif (p->tb_time) {\n \t\tparams = port->pipe_profiles + p->profile;\n \n-\t\tdouble subport_tc3_rate = (double) s->tc_credits_per_period[RTE_SCHED_TRAFFIC_CLASS_BE]\n+\t\tdouble subport_tc_be_rate = (double) s->tc_credits_per_period[RTE_SCHED_TRAFFIC_CLASS_BE]\n \t\t\t/ (double) s->tc_period;\n-\t\tdouble pipe_tc3_rate = (double) params->tc_credits_per_period[RTE_SCHED_TRAFFIC_CLASS_BE]\n+\t\tdouble pipe_tc_be_rate = (double) params->tc_credits_per_period[RTE_SCHED_TRAFFIC_CLASS_BE]\n \t\t\t/ (double) params->tc_period;\n-\t\tuint32_t tc3_ov = s->tc_ov;\n+\t\tuint32_t tc_be_ov = s->tc_ov;\n \n \t\t/* Unplug pipe from its subport */\n \t\ts->tc_ov_n -= params->tc_ov_weight;\n-\t\ts->tc_ov_rate -= pipe_tc3_rate;\n-\t\ts->tc_ov = s->tc_ov_rate > subport_tc3_rate;\n+\t\ts->tc_ov_rate -= pipe_tc_be_rate;\n+\t\ts->tc_ov = s->tc_ov_rate > subport_tc_be_rate;\n \n-\t\tif (s->tc_ov != tc3_ov) {\n+\t\tif (s->tc_ov != tc_be_ov) {\n \t\t\tRTE_LOG(DEBUG, SCHED,\n-\t\t\t\t\"Subport %u TC3 oversubscription is OFF (%.4lf >= %.4lf)\\n\",\n-\t\t\t\tsubport_id, subport_tc3_rate, s->tc_ov_rate);\n+\t\t\t\t\"Subport %u Best effort TC oversubscription is OFF (%.4lf >= %.4lf)\\n\",\n+\t\t\t\tsubport_id, subport_tc_be_rate, s->tc_ov_rate);\n \t\t}\n \n \t\t/* Reset the pipe */\n@@ -1000,23 +1000,23 @@ rte_sched_pipe_config(struct rte_sched_port *port,\n \t\t\tp->tc_credits[i] = params->tc_credits_per_period[i];\n \n \t{\n-\t\t/* Subport TC3 oversubscription */\n-\t\tdouble subport_tc3_rate =\n+\t\t/* Subport best effort tc oversubscription */\n+\t\tdouble subport_tc_be_rate =\n \t\t\t(double) s->tc_credits_per_period[RTE_SCHED_TRAFFIC_CLASS_BE]\n \t\t\t/ (double) s->tc_period;\n-\t\tdouble pipe_tc3_rate =\n+\t\tdouble pipe_tc_be_rate =\n \t\t\t(double) params->tc_credits_per_period[RTE_SCHED_TRAFFIC_CLASS_BE]\n \t\t\t/ (double) params->tc_period;\n-\t\tuint32_t tc3_ov = s->tc_ov;\n+\t\tuint32_t tc_be_ov = s->tc_ov;\n \n \t\ts->tc_ov_n += params->tc_ov_weight;\n-\t\ts->tc_ov_rate += pipe_tc3_rate;\n-\t\ts->tc_ov = s->tc_ov_rate > subport_tc3_rate;\n+\t\ts->tc_ov_rate += pipe_tc_be_rate;\n+\t\ts->tc_ov = s->tc_ov_rate > subport_tc_be_rate;\n \n-\t\tif (s->tc_ov != tc3_ov) {\n+\t\tif (s->tc_ov != tc_be_ov) {\n \t\t\tRTE_LOG(DEBUG, SCHED,\n-\t\t\t\t\"Subport %u TC3 oversubscription is ON (%.4lf < %.4lf)\\n\",\n-\t\t\t\tsubport_id, subport_tc3_rate, s->tc_ov_rate);\n+\t\t\t\t\"Subport %u Best effort TC oversubscription is ON (%.4lf < %.4lf)\\n\",\n+\t\t\t\tsubport_id, subport_tc_be_rate, s->tc_ov_rate);\n \t\t}\n \t\tp->tc_ov_period_id = s->tc_ov_period_id;\n \t\tp->tc_ov_credits = s->tc_ov_wm;\n@@ -1059,8 +1059,8 @@ rte_sched_port_pipe_profile_add(struct rte_sched_port *port,\n \t*pipe_profile_id = port->n_pipe_profiles;\n \tport->n_pipe_profiles++;\n \n-\tif (port->pipe_tc3_rate_max < params->tc_rate[RTE_SCHED_TRAFFIC_CLASS_BE])\n-\t\tport->pipe_tc3_rate_max = params->tc_rate[RTE_SCHED_TRAFFIC_CLASS_BE];\n+\tif (port->pipe_tc_be_rate_max < params->tc_rate[RTE_SCHED_TRAFFIC_CLASS_BE])\n+\t\tport->pipe_tc_be_rate_max = params->tc_rate[RTE_SCHED_TRAFFIC_CLASS_BE];\n \n \trte_sched_port_log_pipe_profile(port, *pipe_profile_id);\n \n", "prefixes": [ "v6", "04/11" ] }