Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/56745/?format=api
{ "id": 56745, "url": "http://patches.dpdk.org/api/patches/56745/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1563531994-10076-1-git-send-email-xiao.zhang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1563531994-10076-1-git-send-email-xiao.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1563531994-10076-1-git-send-email-xiao.zhang@intel.com", "date": "2019-07-19T10:26:34", "name": "[v3] net/i40e: fix SFP X722 not work with FW4.16", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "662eb0745d9ec683f0f82b3b48bffc9c006d5985", "submitter": { "id": 1352, "url": "http://patches.dpdk.org/api/people/1352/?format=api", "name": "Xiao Zhang", "email": "xiao.zhang@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1563531994-10076-1-git-send-email-xiao.zhang@intel.com/mbox/", "series": [ { "id": 5610, "url": "http://patches.dpdk.org/api/series/5610/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5610", "date": "2019-07-19T10:26:34", "name": "[v3] net/i40e: fix SFP X722 not work with FW4.16", "version": 3, "mbox": "http://patches.dpdk.org/series/5610/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/56745/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/56745/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 94A7F322C;\n\tFri, 19 Jul 2019 03:31:03 +0200 (CEST)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby dpdk.org (Postfix) with ESMTP id 946CB28EE;\n\tFri, 19 Jul 2019 03:31:01 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t18 Jul 2019 18:31:00 -0700", "from npg-dpdk-zhangxiao.sh.intel.com ([10.67.110.190])\n\tby orsmga008.jf.intel.com with ESMTP; 18 Jul 2019 18:30:58 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.64,280,1559545200\"; d=\"scan'208\";a=\"162261878\"", "From": "Xiao Zhang <xiao.zhang@intel.com>", "To": "dev@dpdk.org", "Cc": "beilei.xing@intel.com, haiyue.wang@intel.com, qi.z.zhang@intel.com,\n\tXiao Zhang <xiao.zhang@intel.com>, stable@dpdk.org", "Date": "Fri, 19 Jul 2019 18:26:34 +0800", "Message-Id": "<1563531994-10076-1-git-send-email-xiao.zhang@intel.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1563490319-53151-1-git-send-email-xiao.zhang@intel.com>", "References": "<1563490319-53151-1-git-send-email-xiao.zhang@intel.com>", "Subject": "[dpdk-dev] [v3] net/i40e: fix SFP X722 not work with FW4.16", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "set_switch_config adminq operation was used to set TPID for SFP X722\nwith FW4.16, but adminq is not supported which lead to failure. Since\nall FW versions of SFP X722 do not support adminq, disable adminq flag\nto use resigter setting to make it work.\n\nFixes: 73cd7d6dc8e1 (\"net/i40e: use set switch AQ instead of register\nsetting\")\nCc: stable@dpdk.org\n\nSigned-off-by: Xiao Zhang <xiao.zhang@intel.com>\n---\nv3\nModify the commit log to make it not confused and add fixed line.\nv2\nUnset adminq flag instead of only checking device id when set TPID.\nv1\nCheck device id when setting TPID, use adminq if not SFP X722, else \nuse register.\n---\n drivers/net/i40e/i40e_ethdev.c | 4 ++++\n 1 file changed, 4 insertions(+)", "diff": "diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c\nindex 2b9fc45..2b2c877 100644\n--- a/drivers/net/i40e/i40e_ethdev.c\n+++ b/drivers/net/i40e/i40e_ethdev.c\n@@ -1358,6 +1358,10 @@ eth_i40e_dev_init(struct rte_eth_dev *dev, void *init_params __rte_unused)\n \t\tPMD_INIT_LOG(ERR, \"Failed to init adminq: %d\", ret);\n \t\treturn -EIO;\n \t}\n+\t/* Firmware of SFP x722 does not support adminq option */\n+\tif (hw->device_id == I40E_DEV_ID_SFP_X722)\n+\t\thw->flags &= ~I40E_HW_FLAG_802_1AD_CAPABLE;\n+\n \tPMD_INIT_LOG(INFO, \"FW %d.%d API %d.%d NVM %02d.%02d.%02d eetrack %04x\",\n \t\t hw->aq.fw_maj_ver, hw->aq.fw_min_ver,\n \t\t hw->aq.api_maj_ver, hw->aq.api_min_ver,\n", "prefixes": [ "v3" ] }